fix(resources): drop the double blank before the set confirm hint (Bugbot #375)

After removing the intro banner, flag-driven interactive `resources set` (no
--yes/--dry-run) opened with TWO blank lines: a Newline() immediately before
PromptHint, which already self-leads with a newline. The dry-run path dropped
its redundant Newline() (Section supplies one) but the confirm path kept the
stacked pair, so the command no longer opened with a single blank line.
Remove the redundant Newline() — PromptHint's own leading newline gives the one
blank the PR's spacing contract promises. Adds TestSet_ConfirmOpensWithSingleBlank
(drives the flag confirm path via runSet) to pin it.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

Author: LukasWodka

internal/cli/resources_set.go

@@ -266,7 +266,10 @@ func applyResourcesSet(ctx context.Context, p *ui.Printer, pr prompter, target *
 return&exitError{code: exitFailure, err: fmt.Errorf(
 "refusing to change the ceiling without confirmation: pass --yes, or run on a terminal")}
  }
-p.Newline()
+// PromptHint self-leads with a blank line, so this opens with a single
+// blank — no preceding Newline() (that stacked two: the #375 banner-
+// removal regression Bugbot caught). Mirrors the dry-run path, which
+// leans on Section's own leading newline.
 p.PromptHint("tracebloc keeps about 1 core and 3 GiB for itself on top of this — it fits on this machine.")
 proceed, cerr:=pr.Confirm(fmt.Sprintf("Let each training run use up to %s?", perRunSize(desired)), true)
 ifcerr!=nil {

internal/cli/resources_set_test.go

@@ -670,3 +670,41 @@ func TestSet_UntouchedGPUIsKept(t *testing.T) {
 }
 
 funcboolPtr(bbool) *bool { return&b }
+
+// proceedingPrompter answers the final confirm "yes"; the wizard prompts are
+// unused on the flag-driven path.
+typeproceedingPrompterstruct{}
+
+func (proceedingPrompter) Input(string, string, string, func(string) error) (string, error) {
+return"", errInteractiveCancelled
+}
+func (proceedingPrompter) Select(string, string, []string, string) (string, error) {
+return"", errInteractiveCancelled
+}
+func (proceedingPrompter) Confirm(string, bool) (bool, error) { returntrue, nil }
+
+// TestSet_ConfirmOpensWithSingleBlank: after the banner removal (#375) the
+// flag-driven confirm path must still open with exactly ONE blank line.
+// PromptHint self-leads with a newline, so a preceding Newline() stacked two —
+// the command opened with a double blank (Bugbot #375). Pins the single-blank
+// opening so the redundant Newline() can't creep back.
+funcTestSet_ConfirmOpensWithSingleBlank(t*testing.T) {
+fakeHelm(t)
+cs:=csWith("8", "32Gi", map[string]string{"RESOURCE_LIMITS": "cpu=2,memory=8Gi"})
+out, err:=runSet(t, cs, proceedingPrompter{}, setReq{cores: "4", coresSet: true})
+iferr!=nil {
+t.Fatalf("flag-driven confirm + proceed should succeed: %v\n%s", err, out)
+	}
+head:=out
+iflen(head) >48 {
+head=head[:48]
+	}
+// PromptHint emits "\n <hint>\n": exactly one leading newline, then two
+// spaces. A double blank ("\n\n…") is the regression.
+if!strings.HasPrefix(out, "\n ") {
+t.Errorf("confirm path must open with a single blank line then the hint, got %q", head)
+	}
+ifstrings.HasPrefix(out, "\n\n") {
+t.Errorf("confirm path opens with a DOUBLE blank line (banner-removal regression): %q", head)
+	}
+}