fix(core): remove duplicate error logging and improve AggregateError messages

github-actions[bot] · ericallam · github-actions[bot] · commit d7eae6491310 · 2026-05-12T14:35:13.000Z
- Remove per-provider console.error calls (rely on AggregateError for error propagation)
- Include failed provider names in AggregateError message for better debugging

Co-authored-by: Eric Allam &lt;ericallam@users.noreply.github.com&gt;
diff --git a/packages/core/src/v3/otel/tracingSDK.ts b/packages/core/src/v3/otel/tracingSDK.ts
@@ -376,14 +376,15 @@ export class TracingSDK {
 ]);
 const providerNames = ["trace", "log", "meter"] as const;
 const errors: Error[] = [];
+ const failedNames: string[] = [];
 results.forEach((result, index) => {
 if (result.status === "rejected") {
- console.error(`Failed to flush ${providerNames[index]} provider:`, result.reason);
+ failedNames.push(providerNames[index]);
 errors.push(result.reason instanceof Error ? result.reason : new Error(String(result.reason)));
 }
 });
 if (errors.length > 0) {
- throw new AggregateError(errors, "One or more providers failed to flush");
+ throw new AggregateError(errors, `One or more providers failed to flush: ${failedNames.join(", ")}`);
 }
 }
 
@@ -395,14 +396,15 @@ export class TracingSDK {
 ]);
 const providerNames = ["trace", "log", "meter"] as const;
 const errors: Error[] = [];
+ const failedNames: string[] = [];
 results.forEach((result, index) => {
 if (result.status === "rejected") {
- console.error(`Failed to shutdown ${providerNames[index]} provider:`, result.reason);
+ failedNames.push(providerNames[index]);
 errors.push(result.reason instanceof Error ? result.reason : new Error(String(result.reason)));
 }
 });
 if (errors.length > 0) {
- throw new AggregateError(errors, "One or more providers failed to shutdown");
+ throw new AggregateError(errors, `One or more providers failed to shutdown: ${failedNames.join(", ")}`);
 }
 }
 }

Original file line number	Diff line number	Diff line change
`@@ -376,14 +376,15 @@ export class TracingSDK {`
`376`	`376`	`]);`
`377`	`377`	`constproviderNames=["trace","log","meter"]asconst;`
`378`	`378`	`consterrors: Error[]=[];`
	`379`	`+constfailedNames: string[]=[];`
`379`	`380`	`results.forEach((result,index)=>{`
`380`	`381`	`if(result.status==="rejected"){`
`381`		-console.error(`Failed to flush ${providerNames[index]} provider:`,result.reason);
	`382`	`+failedNames.push(providerNames[index]);`
`382`	`383`	`errors.push(result.reasoninstanceofError ? result.reason : newError(String(result.reason)));`
`383`	`384`	`}`
`384`	`385`	`});`
`385`	`386`	`if(errors.length>0){`
`386`		`-thrownewAggregateError(errors,"One or more providers failed to flush");`
	`387`	+thrownewAggregateError(errors,`One or more providers failed to flush: ${failedNames.join(", ")}`);
`387`	`388`	`}`
`388`	`389`	`}`
`389`	`390`
`@@ -395,14 +396,15 @@ export class TracingSDK {`
`395`	`396`	`]);`
`396`	`397`	`constproviderNames=["trace","log","meter"]asconst;`
`397`	`398`	`consterrors: Error[]=[];`
	`399`	`+constfailedNames: string[]=[];`
`398`	`400`	`results.forEach((result,index)=>{`
`399`	`401`	`if(result.status==="rejected"){`
`400`		-console.error(`Failed to shutdown ${providerNames[index]} provider:`,result.reason);
	`402`	`+failedNames.push(providerNames[index]);`
`401`	`403`	`errors.push(result.reasoninstanceofError ? result.reason : newError(String(result.reason)));`
`402`	`404`	`}`
`403`	`405`	`});`
`404`	`406`	`if(errors.length>0){`
`405`		`-thrownewAggregateError(errors,"One or more providers failed to shutdown");`
	`407`	+thrownewAggregateError(errors,`One or more providers failed to shutdown: ${failedNames.join(", ")}`);
`406`	`408`	`}`
`407`	`409`	`}`
`408`	`410`	`}`