fix: avoid SSR requests in waitForRequestIdle (#16246)

patak-cat · web-flow · commit 7093f779b7db · 2024-03-24T07:28:57.000+01:00
diff --git a/packages/vite/src/node/server/transformRequest.ts b/packages/vite/src/node/server/transformRequest.ts
@@ -183,9 +183,14 @@ async function doTransform(
 resolved,
 )
 
- const depsOptimizer = getDepsOptimizer(config, ssr)
- if (!depsOptimizer?.isOptimizedDepFile(id)) {
- server._registerRequestProcessing(id, () => result)
+ if (!ssr) {
+ // Only register client requests, server.waitForRequestsIdle should
+ // have been called server.waitForClientRequestsIdle. We can rename
+ // it as part of the environment API work
+ const depsOptimizer = getDepsOptimizer(config, ssr)
+ if (!depsOptimizer?.isOptimizedDepFile(id)) {
+ server._registerRequestProcessing(id, () => result)
+ }
 }
 
 return result

-Original file line number
+Diff line change
 resolved,
+)
 -constdepsOptimizer=getDepsOptimizer(config,ssr)
 -if(!depsOptimizer?.isOptimizedDepFile(id)){
 -server._registerRequestProcessing(id,()=>result)
 +if(!ssr){
 +// Only register client requests, server.waitForRequestsIdle should
 +// have been called server.waitForClientRequestsIdle. We can rename
 +// it as part of the environment API work
 +constdepsOptimizer=getDepsOptimizer(config,ssr)
 +if(!depsOptimizer?.isOptimizedDepFile(id)){
 +server._registerRequestProcessing(id,()=>result)
 +}
+}
 returnresult