fix: sideEffects: [] should work as sideEffects: false (#16152)

Author: sapphi-red

packages/vite/src/node/packages.ts

@@ -176,21 +176,27 @@ export function loadPackageData(pkgPath: string): PackageData {
 if(typeofsideEffects==='boolean'){
 hasSideEffects=()=>sideEffects
 }elseif(Array.isArray(sideEffects)){
-constfinalPackageSideEffects=sideEffects.map((sideEffect)=>{
-/*
- * The array accepts simple glob patterns to the relevant files... Patterns like *.css, which do not include a /, will be treated like **\/*.css.
- * https://webpack.js.org/guides/tree-shaking/
- * https://github.com/vitejs/vite/pull/11807
- */
-if(sideEffect.includes('/')){
-returnsideEffect
-}
-return`**/${sideEffect}`
-})
+if(sideEffects.length<=0){
+// createFilter always returns true if `includes` is an empty array
+// but here we want it to always return false
+hasSideEffects=()=>false
+}else{
+constfinalPackageSideEffects=sideEffects.map((sideEffect)=>{
+/*
+ * The array accepts simple glob patterns to the relevant files... Patterns like *.css, which do not include a /, will be treated like **\/*.css.
+ * https://webpack.js.org/guides/tree-shaking/
+ * https://github.com/vitejs/vite/pull/11807
+ */
+if(sideEffect.includes('/')){
+returnsideEffect
+}
+return`**/${sideEffect}`
+})
 
-hasSideEffects=createFilter(finalPackageSideEffects,null,{
-resolve: pkgDir,
-})
+hasSideEffects=createFilter(finalPackageSideEffects,null,{
+resolve: pkgDir,
+})
+}
 }else{
 hasSideEffects=()=>null
 }