fix: avoid crashing on process.versions stub (#9174)

AriPerkkio · web-flow · commit 78cfbf99ae8c · 2025-12-05T11:58:43.000+01:00
diff --git a/packages/vitest/src/utils/modules.ts b/packages/vitest/src/utils/modules.ts
@@ -11,12 +11,14 @@ const BUN_BUILTIN_NAMESPACE = 'bun:'
 // Some runtimes like Bun injects namespaced modules here, which is not a node builtin
 const nodeBuiltins = builtinModules.filter(id => !id.includes(':'))
 
+const { bun: isBun, deno: isDeno } = process.versions
+
 // TODO: Use `isBuiltin` from `node:module`, but Deno doesn't support it
 export function isBuiltin(id: string): boolean {
- if (process.versions.deno && id.startsWith(NPM_BUILTIN_NAMESPACE)) {
+ if (isDeno && id.startsWith(NPM_BUILTIN_NAMESPACE)) {
 return true
 }
- if (process.versions.bun && id.startsWith(BUN_BUILTIN_NAMESPACE)) {
+ if (isBun && id.startsWith(BUN_BUILTIN_NAMESPACE)) {
 return true
 }
 return isNodeBuiltin(id)
@@ -47,7 +49,7 @@ export function toBuiltin(id: string): string {
 ) {
 return id
 }
- if (process.versions.deno || process.versions.bun) {
+ if (isDeno || isBun) {
 return id
 }
 return `node:${id}`
diff --git a/test/core/test/stubbed-process.test.ts b/test/core/test/stubbed-process.test.ts
@@ -5,3 +5,7 @@ vi.stubGlobal('process', { badMock: true })
 it('should not hang', () => {
 expect(1).toBe(1)
 })
+
+it('should not crash (#9173)', async () => {
+ await import('./fixtures/increment')
+})

Original file line number	Diff line number	Diff line change
`@@ -11,12 +11,14 @@ const BUN_BUILTIN_NAMESPACE = 'bun:'`
`11`	`11`	`// Some runtimes like Bun injects namespaced modules here, which is not a node builtin`
`12`	`12`	`constnodeBuiltins=builtinModules.filter(id=>!id.includes(':'))`
`13`	`13`
	`14`	`+const{bun: isBun,deno: isDeno}=process.versions`
	`15`	`+`
`14`	`16`	// TODO: Use `isBuiltin` from `node:module`, but Deno doesn't support it
`15`	`17`	`exportfunctionisBuiltin(id: string): boolean{`
`16`		`-if(process.versions.deno&&id.startsWith(NPM_BUILTIN_NAMESPACE)){`
	`18`	`+if(isDeno&&id.startsWith(NPM_BUILTIN_NAMESPACE)){`
`17`	`19`	`returntrue`
`18`	`20`	`}`
`19`		`-if(process.versions.bun&&id.startsWith(BUN_BUILTIN_NAMESPACE)){`
	`21`	`+if(isBun&&id.startsWith(BUN_BUILTIN_NAMESPACE)){`
`20`	`22`	`returntrue`
`21`	`23`	`}`
`22`	`24`	`returnisNodeBuiltin(id)`
`@@ -47,7 +49,7 @@ export function toBuiltin(id: string): string {`
`47`	`49`	`){`
`48`	`50`	`returnid`
`49`	`51`	`}`
`50`		`-if(process.versions.deno\|\|process.versions.bun){`
	`52`	`+if(isDeno\|\|isBun){`
`51`	`53`	`returnid`
`52`	`54`	`}`
`53`	`55`	return`node:${id}`
-Original file line number
+Diff line change
 it('should not hang',()=>{
 expect(1).toBe(1)
 })
++
 +it('should not crash (#9173)',async()=>{
 +awaitimport('./fixtures/increment')
 +})