Skip to content

Drop PHP versions before 7.2 - #232

Merged
Nyholm merged 4 commits into
webmozarts:masterfrom
Nyholm:php-versions
Jan 18, 2021
Merged

Drop PHP versions before 7.2#232
Nyholm merged 4 commits into
webmozarts:masterfrom
Nyholm:php-versions

Conversation

@Nyholm

@NyholmNyholm commented Jan 18, 2021

Copy link
Copy Markdown
Contributor

This will fix#161

BackEndTea
BackEndTea reviewed Jan 18, 2021
View reviewed changes
Comment threadcomposer.json Outdated
BackEndTea
BackEndTea reviewed Jan 18, 2021
View reviewed changes
Comment threadtests/BaseTestCase.php Outdated
@Nyholm

Nyholm commented Jan 18, 2021

Copy link
Copy Markdown
ContributorAuthor

Thank you for the review. I've updated the PR

@Nyholm
Nyholm merged commit 1838a0f into webmozarts:masterJan 18, 2021
@Nyholm
Nyholm deleted the php-versions branch January 18, 2021 12:28
roelvanduijnhoven pushed a commit to roelvanduijnhoven/assert that referenced this pull request Jan 25, 2021
@Nyholm@roelvanduijnhoven
Drop PHP versions before 7.2 (webmozarts#232)
1c057be
* Drop PHP versions before 7.2
* Remove derprecaed phpunit code
* Fixes according to review
* Typo
This was referenced Mar 10, 2021
Merged
Closed
Merged
Merged
Merged
Merged
Closed
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BackEndTeaBackEndTeaBackEndTea approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Nyholm@BackEndTea