fix: check for name of HotModuleReplacementPlugin to avoid RangeError (#2146)

Author: jdb8

lib/utils/addEntries.js

@@ -93,8 +93,9 @@ function addEntries(config, options, server) {
 config.plugins=config.plugins||[];
 if(
 !config.plugins.find(
-(plugin)=>
-plugin.constructor===webpack.HotModuleReplacementPlugin
+// Check for the name rather than the constructor reference in case
+// there are multiple copies of webpack installed
+(plugin)=>plugin.constructor.name==='HotModuleReplacementPlugin'
 )
 ){
 config.plugins.push(newwebpack.HotModuleReplacementPlugin());

test/server/utils/addEntries.test.js

@@ -246,6 +246,26 @@ describe('addEntries util', () => {
 ]);
 });
 
+it("should not add the HMR plugin again if it's already there from a different webpack",()=>{
+constexistingPlugin=newwebpack.BannerPlugin('bruce');
+
+// Simulate the inclusion of another webpack's HotModuleReplacementPlugin
+classHotModuleReplacementPlugin{}
+
+constwebpackOptions=Object.assign({},config,{
+plugins: [newHotModuleReplacementPlugin(),existingPlugin],
+});
+constdevServerOptions={hot: true};
+
+addEntries(webpackOptions,devServerOptions);
+
+expect(webpackOptions.plugins).toEqual([
+// Nothing should be injected
+newHotModuleReplacementPlugin(),
+existingPlugin,
+]);
+});
+
 it('should can prevent duplicate entries from successive calls',()=>{
 constwebpackOptions=Object.assign({},config);
 constdevServerOptions={hot: true};