Skip to content

fix(test): fix ProvidePlugin.test.js - #2002

Merged
alexander-akait merged 1 commit into
webpack:masterfrom
knagaitsev:provide-plugin-test-fix
Jun 10, 2019
Merged

fix(test): fix ProvidePlugin.test.js#2002
alexander-akait merged 1 commit into
webpack:masterfrom
knagaitsev:provide-plugin-test-fix

Conversation

@knagaitsev

Copy link
Copy Markdown
Contributor
  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Updated ProvidePlugin.test.js

Motivation / Use-Case

We need to provide the compiled version of the client in order for injectedClient === expectedClient to be true.

Breaking Changes

None

Additional Info

@codecov

codecovBot commented Jun 8, 2019

Copy link
Copy Markdown

Codecov Report

Merging #2002 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@ Coverage Diff @@## master #2002 +/- ##
=======================================
Coverage 92.52% 92.52% =======================================
Files 28 28 Lines 1083 1083 Branches 324 324 =======================================
Hits 1002 1002 Misses 77 77 Partials 4 4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce81c69...10782d9. Read the comment docs.

@alexander-akait
alexander-akait merged commit 47453cb into webpack:masterJun 10, 2019
@knagaitsevknagaitsev added gsoc Google Summer of Code scope: ws(s) labels Aug 13, 2019
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gsocGoogle Summer of Codescope: ws(s)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@knagaitsev@alexander-akait