From c7b7c33a72fea212723cbcb9680dd18940e375c0 Mon Sep 17 00:00:00 2001 From: Joseph Callaars Date: Tue, 3 Aug 2021 17:01:19 +0100 Subject: [PATCH 1/2] Don't post a notification if there is no title and no body set. --- .../core/notification/PushNotification.java | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java b/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java index fe1fb94a4..0d9d16526 100644 --- a/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java +++ b/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java @@ -87,9 +87,14 @@ public PushNotificationProps asProps() { } protected int postNotification(Integer notificationId) { + if (mNotificationProps.getTitle() == null && mNotificationProps.getBody() == null) { + return -1; + } + final PendingIntent pendingIntent = getCTAPendingIntent(); final Notification notification = buildNotification(pendingIntent); return postNotification(notification, notificationId); + } protected void digestNotification() { From f1d4a70339d09b694f2c8ac40464cbae3418f25c Mon Sep 17 00:00:00 2001 From: Joseph Callaars Date: Tue, 3 Aug 2021 18:36:53 +0100 Subject: [PATCH 2/2] Update PushNotification.java Accidental extra line break. --- .../core/notification/PushNotification.java | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java b/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java index 0d9d16526..19fb07ef2 100644 --- a/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java +++ b/lib/android/app/src/main/java/com/wix/reactnativenotifications/core/notification/PushNotification.java @@ -94,7 +94,6 @@ protected int postNotification(Integer notificationId) { final PendingIntent pendingIntent = getCTAPendingIntent(); final Notification notification = buildNotification(pendingIntent); return postNotification(notification, notificationId); - } protected void digestNotification() {