Uh oh!
There was an error while loading. Please reload this page.
emit connect, disconnect events - #91
Conversation
bombela
commented
May 31, 2017
are the tests passing for you? |
I have passed all your available tests. I run tests at local, addition you can check in The Travis CI build result. |
bombela
commented
May 31, 2017
It looks like the tests are passing fine, but the test program never terminates. So travis waits 10 minutes then give up. Make sure the test runner is not lingering around after passing the tests. It could be a some scheduled callbacks waiting for something that never happens. |
dichnd
commented
May 31, 2017
please help me check my commit. is setTimeout cause the problem. I think i didn't add any new schedule callbacks |
bombela
commented
May 31, 2017
via email
I will try to find some time to look into it. No guarantee though. …On Wed, May 31, 2017 at 1:30 PM Dich ***@***.***> wrote:
please help me check my commit. is setTimeout cause the problem. I think i
didn't add any new schedule callbacks
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#91 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AANMjHdH564zA-EXPXVm65Ah-wRo9QyHks5r_c31gaJpZM4NsFAF>
.
|
mfrye
commented
Oct 17, 2018
👍 This would be great to have. Apart from the heartbeat error when you try to make a connection and it times out, there's no other notice when the connection is broken... |
emit "connect" and "disconnect" event so client can control connect status