fix: prefer rent price for mixed buy-rent search results

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.

[ADikmarov]

Summary

• Pass the requested search offering type into search-result parsing.
• Prefer rent_price fields for category="rent" results when Funda returns mixed koophuur listings with both sale and rent prices.
• Add regression coverage for mixed buy/rent search hits and parser invocation.

Why

Funda can return listings whose offering_type is ['buy', 'rent'] for rental searches. Previously the parser selected the first offering type (buy) and therefore exposed the sale price (for example 400000) even though the user searched category="rent" and the raw payload also contained rent_price (for example 2250).

Verification

• uv run python -m py_compile funda/*.py examples/*.py tests/*.py
• uv run python -m unittest discover -s tests -v
• PYFUNDA_LIVE=1 uv run python -m unittest tests.test_live -v
• uv build
• Manual smoke: client.search('amsterdam', category='rent', max_price=2500)[0] now returns offering_type == 'rent' and price.amount == raw['_source']['price']['rent_price'][0].

[0xMH]

A few concerns before merging.

Inconsistent offering_type application: _hit now resolves the offering type via the preferred hint, but _property_details still uses first(source.get("offering_type")). For a mixed ["buy", "rent"] listing this can yield offering_type="rent" on the Listing while raw_offering_type/status are derived from "buy". The preferred type should either flow through that path too, or the parser should intentionally keep those concepts separate with test coverage.

[0xMH]

The initial range_data = sale_range or rent_range is now dead code since both branches of the if/else immediately reassign it. Please drop that line. The else branch also just re-derives the original behavior, so this could collapse into a single prefer_rent flag instead of duplicating three lines per branch.

[0xMH]

_offering_type() adds a second raw-offering normalization path next to the existing first() + normalize_offering_type() pattern. Since preferred selection is now part of parser behavior, consider centralizing that handling and using it consistently rather than only in _hit.

[0xMH]

Threading preferred_offering_type from the client into the pure parser couples parsing to caller intent. If that context is required to choose between sale and rent fields, can we make it an explicit parser-level decision and apply it consistently through the parsed model? Right now it enters through _hit, but related metadata still follows the old first-offering path.