ethclient: handle single state-sync tx in get block calls - #1435
Merged
Merged
Conversation
- Declare zeroAddress as a constant - If there is only one transaction in the block and the header's txHash is `EmptyTxsHash`, it indicates a state-sync transaction. No error handling is required in this case.
18 tasks
manav2401
approved these changes
Feb 4, 2025
manav2401
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot, waiting for CI to pass.
pratikspatil024
approved these changes
Feb 5, 2025
Contributor
Author
|
It took a long time to apply what was supposed to be a simple fix. Have nice day |
Contributor
It would not be correct to merge half-baked solution which requires more efforts later on from us. Hence, I was suggesting changes to make sure it's done right. Could have done ourselves in a different PR but it's better if feedback is incorporated. Congrats on your first contribution. Thank you for your efforts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refer to previous PR: #1409
Description
This PR resolves an issue where blocks containing system transactions could not be retrieved properly using
getBlock.For such blocks, the
transactionsRootis set toEmptyTxsHash, but theTransactionslist contains one transaction, which leads to a mismatch and prevents block information from being retrieved.The validation logic has been updated to handle these cases correctly.
Example block with system transaction: https://amoy.polygonscan.com/block/16653120
Changes
Breaking changes
No breaking changes have been introduced in this PR.
Nodes audience
This PR affects all nodes and does not include changes limited to a subset of nodes.
Checklist
Cross repository changes
Testing
Manual tests
transactionsRootasEmptyTxsHashbut includingTransactions).Additional comments
See the example block for context:
https://amoy.polygonscan.com/block/16653120