Uh oh!
There was an error while loading. Please reload this page.
Adding ConfigClass for HTTPX - #118
Conversation
If you're new to commit signing, there are different ways to set it up: Sign commits with |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
mattjacksoncello
commented
Jan 28, 2025
Thanks for the review Andy, will refactor the code |
mattjacksoncello
commented
Jan 29, 2025
I've updated the PR to focus solely on the config class changes as requested. Here are the key updates:
Please review these changes and let me know if any adjustments are needed. |
mattjacksoncello
commented
Feb 19, 2025
Hi @AndyTitu Any updates on this? Thanks |
mattjacksoncello
commented
Feb 27, 2025
Hi @AndyTitu |
@mattjacksoncello apologies for missing notifications on this. I'm on it now. |
AndyTitu
left a comment
There was a problem hiding this comment.
Code looks good to me apart from some small suggestions, thank you for the contribution! ❤️
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
LGTM Co-authored-by: Andi Titu <45081667+AndyTitu@users.noreply.github.com>
LGTM Co-authored-by: Andi Titu <45081667+AndyTitu@users.noreply.github.com>
AndyTitu
commented
Mar 5, 2025
@mattjacksoncello some tests are failing for the last changes. |
mattjacksoncello
commented
Mar 6, 2025
Hi Andy, |
mattjacksoncello
commented
Mar 13, 2025
@AndyTitu Could you have another look at this please |
mattjacksoncello
commented
May 30, 2025
@AndyTitu Can you review this please |
mattjacksoncello
commented
Jun 2, 2025
Hi @AndyTitu |

This PR is to implement a config class to allow more control over httpx for things like certificate verification.
I have also merged in the changes from #92
Note: I have used Claude to help with the changes. I have reviewed everything but I am not the strongest coder so there may be mistakes that I have missed