feat(macos): 添加编辑器按行号跳转对话框 - #349
Closed
Wz58luck wants to merge 6 commits into
Closed
Conversation
- Add FindInFileOptions/FindInFileMatcher with Match Case, Whole Words, and Regular Expression matching aligned with project search semantics - Extend FindBarView with an options menu, expandable replace row (Replace / Replace All), and invalid-regex error state - Replace-next routes through insertText for standard undo; replace-all commits via shouldChangeText + textStorage as a single undo step - Register replace-in-file (Cmd+R) in the command catalog, action registry, Navigate menu, Keymap settings, and zh-Hans localization Closes1lck#327
- Unify replacement template docs and comments on $n numeric capture
groups; ${name} named-group templates are not expanded by the current
SDK and return verbatim
- Bind replace notifications to the active document: notifications now
carry documentID and CodeTextView ignores mismatched targets so split
editors never replace the wrong file
- Recompute matches across the whole document for regex queries where
matches can span lines; keep the line-window incremental path for
single-line literal queries
- Add regression tests for cross-line regex matches and notification
document gatingAdd three mouse-reachable entries for jumping to a line: the Navigate menu, the editor context menu, and the status bar caret label, all opening a shared go-to-line bar styled after the find bar. Input accepts 1-based line or line:column, converges out-of-range values against the live document, selects the target line through the existing editorNavigationTarget pathway (now carrying selectsWholeLine), and records navigation history so Cmd+[ returns to the departure position. The bar and the find bar are mutually exclusive; Cmd+L is registered in the command catalog and remappable in Keymap settings.
Swap the in-editor go-to-line bar for a small modal "Go to Line:Column" window: a single [Line] [:column]: input prefilled with the caret's 1-based position and fully selected, with Cancel/OK buttons. Return and OK jump through the same parser and navigation pathway, invalid input disables OK, and Esc, Cancel, or the close button dismiss without side effects. Every entry point (Navigate menu, editor context menu, status bar caret label, Cmd+L) funnels through the chrome visibility flag via a shared presenter, so the workbench and standalone editor windows both stay covered. Also unify all go-to-line comments to English to match the surrounding files.
The dialog panel fell back to the system appearance and rendered light inside a dark-themed editor. Apply the same AppThemePreference window appearance the workbench windows use, so the dialog matches the editor theme in system, light, and dark modes. Widen the private AppThemePreference.windowAppearance helper for reuse.
…og count The Simplified Chinese localization test requires every command catalog entry to carry translated title and subtitle strings, and the keyboard shortcut test pins the catalog size. Cover the new go-to-line command and bump the expected count to 33.
Wz58luck
commented
Aug 30, 2026
ContributorAuthor
已取消：按约定改为基于上游最新 preview 分支重建（不包含 #346 内容）。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes#341
概述
新增 "Go to Line:Column" 按行号跳转对话框——经典 IDE 风格的小型模态浮窗：单个
[Line] [:column]:输入位，打开时预填当前光标的 1-based 位置并全选，附 Cancel / OK 按钮。go-to-line），可在 设置 → Keymap 中修改。120或120:35，容忍空格；非法输入时 OK 按钮置灰，Return 不会跳转。越界行号收敛到最后一行，越界列号收敛到行尾（按 UTF-16 单元计），空文档只定位到文档开头。navigateToEditorLocation——自动打开文档、进入导航历史（Cmd+[ 可回到跳转前的位置），并通过新增的selectsWholeLine标志整行选中目标行（默认false，既有的符号/查找导航保持零长度光标不变）。AppThemePreference外观，在 system / light / dark 模式下都与编辑器保持一致。EditorChromeModel。测试