Change block data request to get witness block

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now

[randomlogin]

Change block data request to get witness block
Add a small test which might be unnecessary.

block() was sending Block instead of WitnessBlock.

ProbabLy this was a regression introduced when the filter-control feature flag was removed (4ed9a55). The original code conditionally used Inventory::WitnessBlock under that feature; when the feature was removed the WitnessBlock path was lost and Inventory::Block became the unconditional default.

Encountered this issue when tried to use kyoto for ldk-node (lightningdevkit/ldk-node#821).

[rustaceanrob]

Most on-chain clients will not be doing block validation, so this would be a waste of bandwidth for some users. Can we instead add this as a builder and Config option that is subsequently passed to the callsite?

[rustaceanrob]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

[randomlogin]

I am going to merge #549 instead. May I have the email associated with your github account to add you as a commit co-author?

You can use randomlogin76 at gmail

[rustaceanrob]

Thanks, you are attributed in #549. Closing this now