Uh oh!
There was an error while loading. Please reload this page.
Add ability to try the decoder over multiple ABIs - #239
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Deploying loop-decoder with |
| Latest commit: | cc791f8 |
| Status: | ✅ Deploy successful! |
| Preview URL: | https://64c5ef51.loop-decoder.pages.dev |
| Branch Preview URL: | https://add-support-for-fallbacks-in.loop-decoder.pages.dev |
There was a problem hiding this comment.
Pull Request Overview
This PR adds the ability to try multiple ABIs when decoding transactions, enhancing resilience against cached ABIs that become invalid. The changes modify the ABI store architecture to support multiple ABI versions per lookup key and implement validation logic that marks failed ABIs as invalid.
- Refactors ABI storage to handle multiple ABIs per lookup key with status tracking
- Implements fallback decoding logic that tries multiple ABIs sequentially
- Adds migration system for SQL store to upgrade schema and preserve existing data
Reviewed Changes
Copilot reviewed 22 out of 22 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/transaction-decoder/src/abi-store.ts | Updates ABI store interface to return arrays and support status tracking |
| packages/transaction-decoder/src/sql/abi-store.ts | Implements new v3 schema with migrations and multi-ABI support |
| packages/transaction-decoder/src/in-memory/abi-store.ts | Updates in-memory store to handle multiple ABIs per key |
| packages/transaction-decoder/src/decoding/abi-decode.ts | Adds validation functions that try multiple ABIs with fallback |
| packages/transaction-decoder/src/abi-loader.ts | Modifies loader to return arrays of ABIs with metadata |
| packages/transaction-decoder/src/decoding/*.ts | Updates decoding functions to use new multi-ABI validation |
| test files | Updates mocks to return arrays instead of single results |
| documentation | Updates interface documentation to reflect new multi-ABI API |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| import { type Hex, type GetTransactionReturnType, Abi, getAddress } from 'viem' | ||
| import { stringify } from '../helpers/stringify.js' | ||
| import { errorFunctionSignatures, panicReasons, solidityError, solidityPanic } from '../helpers/error.js' | ||
| import { e } from 'vitest/dist/types-63abf2e0.js' |
There was a problem hiding this comment.
This import appears to be an accidental leftover from debugging. The variable 'e' is not used anywhere in the file and this import path suggests it's a test-related dependency that shouldn't be in production code.
Suggested change
| import { e } from 'vitest/dist/types-63abf2e0.js' |
| const result = yield* decodeMethod(data, abi) | ||
| if (result == null) { | ||
| return yield* Effect.fail(new DecodeError(`ABI ${abi} failed to decode`)) |
There was a problem hiding this comment.
The error message interpolates the entire ABI object which will result in '[object Object]' being displayed. Consider using a more descriptive error message or abi identifier.
Suggested change
| returnyield*Effect.fail(newDecodeError(`ABI ${abi} failed to decode`)) | |
| returnyield*Effect.fail(newDecodeError(`ABI with id ${id} failed to decode`)) |
| '@3loop/transaction-decoder': minor | ||
| --- | ||
| BREAKING! This version changes the public API for ABI store. If you use built in stores evrything should work out of the box. When using SQL store ensure that migrations complete on start. Additionally the AbiLoader will now also return an array of ABIs when accessing the cached data. These changes allows us to run over multiple ABIs when decoding a transaction, instead of failing when the cached ABI is wrong. |
There was a problem hiding this comment.
Typo: 'evrything' should be 'everything'.
Suggested change
| BREAKING! This version changes the public API for ABI store. If you use built in stores evrything should work out of the box. When using SQL store ensure that migrations complete on start. Additionally the AbiLoader will now also return an array of ABIs when accessing the cached data. These changes allows us to run over multiple ABIs when decoding a transaction, instead of failing when the cached ABI is wrong. | |
| BREAKING! This version changes the public API for ABI store. If you use built in stores everything should work out of the box. When using SQL store ensure that migrations complete on start. Additionally the AbiLoader will now also return an array of ABIs when accessing the cached data. These changes allows us to run over multiple ABIs when decoding a transaction, instead of failing when the cached ABI is wrong. |
Ferossgpforce-pushed
the
add-support-for-fallbacks-in-decode
branch
from
August 19, 2025 18:19
522b5e2 to
66337f2CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This version changes the public API for ABI store. If you use built in stores evrything should work out of the box. When using SQL store ensure that migrations complete on start. Additionally the AbiLoader will now also return an array of ABIs when accessing the cached data. These changes allows us to run over multiple ABIs when decoding a transaction, instead of failing when the cached ABI is wrong.