Uh oh!
There was an error while loading. Please reload this page.
feat(pr-title): Add empty commit step - #167
Closed
chris3ware wants to merge 7 commits into
Closed
Conversation
if: always() is required to run steps that deal with failures. For example, when the PR title is invalid, the step fails but the PR comment should be created and the failure summary should be added. Delete Comment and valid title summary will always run anyway because the preceding steps have succeeded.
This workflow does not need to run when a PR is edited because this event does not generate a new commit.
The trigger step isn't working. So we need to see what is in the action and changes context. Copilot think this needs running on pull_request_target events to have access to the correct contexts.
chris3ware
commented
Mar 5, 2025
MemberAuthor
The step to push the empty commit is not running because access to the required contexts is not available with the Produces: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required check (enforce-all-checks) will fail if the PR title is invalid - as expected.
enforce-all-checks polls the check api for the most recent commit in the PR. Fixing the PR title does not generate a new commit which means re-running the failed checks workflow still results in failing - because it is polling the previous commit.
In this PR a step will be added to push an empty commit to trigger the checks workflow on a new commit where the PR title check has succeeded.
edit to trigger context output debug