Skip to content

Liquid modules - #84

Open
Oskal174 wants to merge 7 commits into
mainfrom
liquid-support
Open

Liquid modules#84
Oskal174 wants to merge 7 commits into
mainfrom
liquid-support

Conversation

@Oskal174

Copy link
Copy Markdown
Collaborator

3xpl modules for Liquid blockchain.
UTXOMainModule was improved with new feature.
Additional module for Liquid assets (it works with off-chain api only).

@Oskal174
Oskal174 requested a review from Har01d as a code ownerMarch 20, 2024 07:17

@Har01dHar01d left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be combined into one module. Also, null assets seem to be unknown (confidential) assets, rather than the native asset (L-BTC).

@Har01d
Har01d self-requested a review March 29, 2024 19:43
Har01d
Har01d previously approved these changes Mar 29, 2024

@Har01dHar01d left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working fine with the fixes: https://3xpl.com/liquid-network

@Har01d

Copy link
Copy Markdown
Collaborator

The only thing that doesn't check out is the balance of the-bridge. It shows as 3848.90272308 L-BTC while other explorers report the circulating amount as 3840.20023942. Could this be connected to 4d32977? @Oskal174

@Har01d
Har01d self-requested a review March 29, 2024 19:48
@Har01d
Har01d dismissed their stale reviewMarch 29, 2024 19:49

Probably a bug in peg-in processing

@alexqrid

Copy link
Copy Markdown
Collaborator

The only thing that doesn't check out is the balance of the-bridge. It shows as 3848.90272308 L-BTC while other explorers report the circulating amount as 3840.20023942.

Tried to get some clarification from the liquid team.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@Oskal174@Har01d@alexqrid