Uh oh!
There was an error while loading. Please reload this page.
Improve add-db-to-osd.sh - #8
Merged
baileyallison merged 1 commit intoNov 13, 2025
Merged
Conversation
Uh oh!
There was an error while loading. Please reload this page.
anthonyelevenforce-pushed
the
improve-add-db-to-osd.sh
branch
from
April 15, 2025 20:30
bac099a to
f657006Comparebkelly16
requested changes
Apr 15, 2025
bkelly16
left a comment
Member
There was a problem hiding this comment.
Thanks for the feedback Anthony
Uh oh!
There was an error while loading. Please reload this page.
| OSD_PER_DB_LIMIT=5 | ||
| while getopts 'b:fo:d:h' OPTION; do | ||
| while getopts 'b:fo:d:h:r' OPTION; do |
Member
There was a problem hiding this comment.
":" needs to trail the r here, not precede
ContributorAuthor
There was a problem hiding this comment.
Ah, haven't used getopts much and was confused re the subtleties. Pushed an ammendment
| ceph osd set noout | ||
| echo "Stop OSD.$OSD_ID" | ||
| systemctl stop ceph-osd@$OSD_ID | ||
| # Is this a relic of Filestore and thus superfluous? |
Signed-off-by: Anthony D'Atri <anthonyeleven@users.noreply.github.com>
anthonyelevenforce-pushed
the
improve-add-db-to-osd.sh
branch
from
April 15, 2025 20:54
f657006 to
3187d58Comparebaileyallison
commented
Nov 13, 2025
Member
lgtm, merging (sorry for taking so long hahahaha) |
anthonyeleven
commented
Nov 13, 2025
ContributorAuthor
No problem, good sir. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve spelling and caps, add the ability to specify the number of offload slices per device, add an ok-to-stop check.