Uh oh!
There was an error while loading. Please reload this page.
Suggest cTimezone during profile processing from location data - #159
Conversation
When resume timezone is not explicitly stated, infer UTC offset from city/country. Add LLM prompt rule to infer standard timezone from location (e.g., San Francisco → UTC-08:00, India → UTC+05:30). Add static country-to-timezone mapping for heuristic extraction fallback. Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe change adds timezone inference capability to the resume extractor by introducing a static country-to-UTC offset mapping and a helper function that infers timezone from extracted location data (country and optionally city). This is integrated into both heuristic and snippet-based extraction flows. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@packages/shared/src/five08/resume_extractor.py`:
- Around line 425-533: _infer_timezone_from_location currently ignores the city
parameter and returns a country-based mapping from _COUNTRY_TIMEZONE even for
multi-timezone countries; update the function to first try a city-based lookup
when city is provided (use a new city-to-tz lookup or normalized city key
lookup), and if city lookup fails fall back to country only when the country is
unambiguous; introduce a small AMBIGUOUS_COUNTRIES set (e.g.,
{"mexico","brazil","russia","australia","usa","canada"}) and if the country is
in that set return None instead of a coarse offset, ensuring you reference the
existing _COUNTRY_TIMEZONE and the function _infer_timezone_from_location when
making changes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 28b7a852-661e-47b7-a1c0-39466720470a
📒 Files selected for processing (1)
packages/shared/src/five08/resume_extractor.py
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Pull request overview
This PR adds automatic timezone inference during candidate profile processing. When a resume doesn't explicitly state a timezone, the system infers the UTC offset from the candidate's city/country data. The change affects both the LLM-based extraction path (via an added prompt rule) and the heuristic extraction fallback (via a new static country-to-timezone mapping and inference function).
Changes:
- Add a
_COUNTRY_TIMEZONEstatic dictionary mapping ~70 countries to their standard UTC offsets, and a_infer_timezone_from_locationfallback function that looks up timezone by country name - Apply the fallback inference in the heuristic extraction path when explicit timezone is not found in the resume text
- Add an LLM prompt rule instructing the model to infer timezone from city/country when not explicitly stated
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| def _infer_timezone_from_location( | ||
| *, country: str | None, city: str | None = None | ||
| ) -> str | None: | ||
| """Best-effort UTC offset from country name (heuristic fallback only).""" | ||
| if country: | ||
| tz = _COUNTRY_TIMEZONE.get(country.strip().lower()) | ||
| if tz: | ||
| return tz |
There was a problem hiding this comment.
The city parameter is accepted but never used in the function body. This creates a misleading API where callers might expect city-based timezone inference (e.g., for multi-timezone countries like the US or Canada), but it silently does nothing. Either remove the city parameter since it's unused, or implement city-based lookup to provide more granular timezone inference for multi-timezone countries.
| def_infer_timezone_from_location( | |
| *, country: str|None, city: str|None=None | |
| ) ->str|None: | |
| """Best-effort UTC offset from country name (heuristic fallback only).""" | |
| ifcountry: | |
| tz=_COUNTRY_TIMEZONE.get(country.strip().lower()) | |
| iftz: | |
| returntz | |
| _CITY_TIMEZONE: dict[str, str] = { | |
| # Common US cities | |
| "new york": "UTC-05:00", | |
| "san francisco": "UTC-08:00", | |
| "los angeles": "UTC-08:00", | |
| "seattle": "UTC-08:00", | |
| "chicago": "UTC-06:00", | |
| "boston": "UTC-05:00", | |
| "washington, dc": "UTC-05:00", | |
| "washington dc": "UTC-05:00", | |
| "atlanta": "UTC-05:00", | |
| "denver": "UTC-07:00", | |
| # Common Canadian cities | |
| "toronto": "UTC-05:00", | |
| "vancouver": "UTC-08:00", | |
| "montreal": "UTC-05:00", | |
| "calgary": "UTC-07:00", | |
| # Common Australian cities | |
| "sydney": "UTC+10:00", | |
| "melbourne": "UTC+10:00", | |
| "brisbane": "UTC+10:00", | |
| "perth": "UTC+08:00", | |
| # Common European cities | |
| "london": "UTC+00:00", | |
| "paris": "UTC+01:00", | |
| "berlin": "UTC+01:00", | |
| "madrid": "UTC+01:00", | |
| "rome": "UTC+01:00", | |
| "amsterdam": "UTC+01:00", | |
| } | |
| def_infer_timezone_from_location( | |
| *, country: str|None, city: str|None=None | |
| ) ->str|None: | |
| """Best-effort UTC offset from country name, with city fallback (heuristic only).""" | |
| ifcountry: | |
| tz=_COUNTRY_TIMEZONE.get(country.strip().lower()) | |
| iftz: | |
| returntz | |
| ifcity: | |
| tz=_CITY_TIMEZONE.get(city.strip().lower()) | |
| iftz: | |
| returntz |
| "- infer linkedin_url and website_links from bare domains when scheme is missing\n" | ||
| "- for phone return digits with country code and leading + (e.g. +15551234567); if no country code in the source, infer it from address_country or address_city (e.g. United States → +1, India → +91, UK → +44)\n" | ||
| "- if timezone is provided, normalize it to UTC offset form like UTC±HH:MM before output\n" | ||
| "- if timezone is null but address_city or address_country is known, infer the standard UTC offset (e.g., San Francisco/Los Angeles/Seattle → UTC-08:00, Denver → UTC-07:00, Chicago/Dallas/Houston → UTC-06:00, New York/Boston/Atlanta → UTC-05:00, London/Dublin/Lisbon → UTC+00:00, Paris/Berlin/Amsterdam/Rome/Madrid → UTC+01:00, Nairobi/Istanbul/Kyiv → UTC+03:00, UAE/Dubai → UTC+04:00, India/Mumbai/Bangalore → UTC+05:30, Singapore/Shanghai/Beijing → UTC+08:00, Tokyo/Seoul → UTC+09:00, Sydney/Melbourne → UTC+10:00); omit if location is ambiguous\n" |
There was a problem hiding this comment.
The LLM prompt groups Kyiv with Nairobi and Istanbul at UTC+03:00, but Ukraine's standard UTC offset is UTC+02:00 (EET). This is inconsistent with the _COUNTRY_TIMEZONE static mapping on line 470, which correctly lists "ukraine": "UTC+02:00". Kyiv should be moved to a UTC+02:00 grouping (e.g., alongside Bucharest or Athens) to avoid contradictory timezone inference between the LLM path and the heuristic fallback path.
| "- if timezone is null but address_city or address_country is known, infer the standard UTC offset (e.g., San Francisco/Los Angeles/Seattle → UTC-08:00, Denver → UTC-07:00, Chicago/Dallas/Houston → UTC-06:00, New York/Boston/Atlanta → UTC-05:00, London/Dublin/Lisbon → UTC+00:00, Paris/Berlin/Amsterdam/Rome/Madrid → UTC+01:00, Nairobi/Istanbul/Kyiv → UTC+03:00, UAE/Dubai → UTC+04:00, India/Mumbai/Bangalore → UTC+05:30, Singapore/Shanghai/Beijing → UTC+08:00, Tokyo/Seoul → UTC+09:00, Sydney/Melbourne → UTC+10:00); omit if location is ambiguous\n" | |
| "- if timezone is null but address_city or address_country is known, infer the standard UTC offset (e.g., San Francisco/Los Angeles/Seattle → UTC-08:00, Denver → UTC-07:00, Chicago/Dallas/Houston → UTC-06:00, New York/Boston/Atlanta → UTC-05:00, London/Dublin/Lisbon → UTC+00:00, Paris/Berlin/Amsterdam/Rome/Madrid → UTC+01:00, Bucharest/Athens/Kyiv → UTC+02:00, Nairobi/Istanbul → UTC+03:00, UAE/Dubai → UTC+04:00, India/Mumbai/Bangalore → UTC+05:30, Singapore/Shanghai/Beijing → UTC+08:00, Tokyo/Seoul → UTC+09:00, Sydney/Melbourne → UTC+10:00); omit if location is ambiguous\n" |
| def _infer_timezone_from_location( | ||
| *, country: str | None, city: str | None = None | ||
| ) -> str | None: | ||
| """Best-effort UTC offset from country name (heuristic fallback only).""" | ||
| if country: | ||
| tz = _COUNTRY_TIMEZONE.get(country.strip().lower()) | ||
| if tz: | ||
| return tz | ||
| return None |
There was a problem hiding this comment.
The test file covers other internal helpers like _infer_seniority_from_resume (lines 458-491 in test_resume_extractor.py), _normalize_name_part, and _coerce_email_list, but no tests are added for _infer_timezone_from_location. At minimum, tests should cover: (1) a known country returning the correct offset, (2) an unknown country returning None, (3) a None country returning None, and (4) case-insensitive matching (e.g., "India" vs "india").
- Add _CITY_TIMEZONE map and use city first in _infer_timezone_from_location - Add _AMBIGUOUS_COUNTRY_TIMEZONE set; return None for multi-zone countries (US, Canada, Mexico, Brazil, Australia, Russia, Indonesia) - Fix Kyiv in LLM prompt to UTC+02:00 (was incorrectly grouped at UTC+03:00) - Remove ambiguous countries from _COUNTRY_TIMEZONE - Add 8 unit tests for _infer_timezone_from_location Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
Description
Add automatic timezone suggestion during candidate profile processing. When a resume doesn't explicitly state timezone, infer the standard UTC offset from city/country data that's already extracted.
Changes:
This enables suggesting cTimezone during resume profile processing even when candidates don't explicitly list their timezone.
How Has This Been Tested?
Existing resume_extractor tests pass (30 tests). No new test coverage needed as the timezone inference is a fallback optimization that doesn't change existing behavior when timezone is explicitly provided.
Summary by CodeRabbit