Document agent memory lessons - #286

Merged
michaelmwu merged 1 commit into
mainfrom
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged

Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom
michaelmwu/document-agent-memory-lessons

Conversation

@michaelmwu

@michaelmwumichaelmwu commented May 16, 2026•
edited by coderabbitai Bot
Loading

Copy link
Copy Markdown
Member

Summary

  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families

Validation

  • git diff --check

Summary by CodeRabbit

  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.

Review Change Stack

CopilotAI review requested due to automatic review settings May 16, 2026 02:49
@coderabbitai

coderabbitaiBot commented May 16, 2026•
edited
Loading

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa

📥 Commits

Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.

📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough

Walkthrough

This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.

Changes

Documentation Clarifications

Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🐰 Two small docs so bright,
Clarifying bots' delight—
Discord threads and tests aligned,
Guild-keeper wisdom, neatly signed!
whisker twitch ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch michaelmwu/document-agent-memory-lessons

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

CopilotAI reviewed May 16, 2026
View reviewed changes

CopilotAI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.

Changes:

  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@michaelmwu
michaelmwu merged commit 7c92aa8 into mainMay 16, 2026
11 checks passed
@michaelmwu
michaelmwu deleted the michaelmwu/document-agent-memory-lessons branch May 16, 2026 02:51
@coderabbitaicoderabbitaiBot mentioned this pull request Aug 6, 2026
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Document agent memory lessons - #286
Merged
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged
Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
Conversation
@michaelmwu
@michaelmwumichaelmwu
commented
May 16, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families
Validation
  • git diff --check
Summary by CodeRabbit
  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.
Review Change Stack
CopilotAI
review requested due to automatic review settings
May 16, 2026 02:49
@coderabbitai
coderabbitaiBot
commented
May 16, 2026•

edited

Loading

Copy link


Copy Markdown

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa
📥 Commits
Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.
📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough
Walkthrough
This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.
Changes
Documentation Clarifications
Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🐰 Two small docs so bright,

Clarifying bots' delight—

Discord threads and tests aligned,

Guild-keeper wisdom, neatly signed!
whisker twitch ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch michaelmwu/document-agent-memory-lessons
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.
Changes:
  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@michaelmwu
michaelmwu
merged commit 7c92aa8
into
mainMay 16, 2026

11 checks passed

@michaelmwu
michaelmwu
deleted the

michaelmwu/document-agent-memory-lessons

branch
May 16, 2026 02:51
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Document agent memory lessons - #286
Merged
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged
Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
Conversation
@michaelmwu
@michaelmwumichaelmwu
commented
May 16, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families
Validation
  • git diff --check
Summary by CodeRabbit
  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.
Review Change Stack
CopilotAI
review requested due to automatic review settings
May 16, 2026 02:49
@coderabbitai
coderabbitaiBot
commented
May 16, 2026•

edited

Loading

Copy link


Copy Markdown

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa
📥 Commits
Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.
📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough
Walkthrough
This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.
Changes
Documentation Clarifications
Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🐰 Two small docs so bright,

Clarifying bots' delight—

Discord threads and tests aligned,

Guild-keeper wisdom, neatly signed!
whisker twitch ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch michaelmwu/document-agent-memory-lessons
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.
Changes:
  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@michaelmwu
michaelmwu
merged commit 7c92aa8
into
mainMay 16, 2026

11 checks passed

@michaelmwu
michaelmwu
deleted the

michaelmwu/document-agent-memory-lessons

branch
May 16, 2026 02:51
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Document agent memory lessons - #286
Merged
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged
Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
Conversation
@michaelmwu
@michaelmwumichaelmwu
commented
May 16, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families
Validation
  • git diff --check
Summary by CodeRabbit
  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.
Review Change Stack
CopilotAI
review requested due to automatic review settings
May 16, 2026 02:49
@coderabbitai
coderabbitaiBot
commented
May 16, 2026•

edited

Loading

Copy link


Copy Markdown

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa
📥 Commits
Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.
📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough
Walkthrough
This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.
Changes
Documentation Clarifications
Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🐰 Two small docs so bright,

Clarifying bots' delight—

Discord threads and tests aligned,

Guild-keeper wisdom, neatly signed!
whisker twitch ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch michaelmwu/document-agent-memory-lessons
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.
Changes:
  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@michaelmwu
michaelmwu
merged commit 7c92aa8
into
mainMay 16, 2026

11 checks passed

@michaelmwu
michaelmwu
deleted the

michaelmwu/document-agent-memory-lessons

branch
May 16, 2026 02:51
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Document agent memory lessons - #286
Merged
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged
Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
Conversation
@michaelmwu
@michaelmwumichaelmwu
commented
May 16, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families
Validation
  • git diff --check
Summary by CodeRabbit
  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.
Review Change Stack
CopilotAI
review requested due to automatic review settings
May 16, 2026 02:49
@coderabbitai
coderabbitaiBot
commented
May 16, 2026•

edited

Loading

Copy link


Copy Markdown

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa
📥 Commits
Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.
📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough
Walkthrough
This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.
Changes
Documentation Clarifications
Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🐰 Two small docs so bright,

Clarifying bots' delight—

Discord threads and tests aligned,

Guild-keeper wisdom, neatly signed!
whisker twitch ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch michaelmwu/document-agent-memory-lessons
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.
Changes:
  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@michaelmwu
michaelmwu
merged commit 7c92aa8
into
mainMay 16, 2026

11 checks passed

@michaelmwu
michaelmwu
deleted the

michaelmwu/document-agent-memory-lessons

branch
May 16, 2026 02:51
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Document agent memory lessons - #286
Merged
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged
Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
Conversation
@michaelmwu
@michaelmwumichaelmwu
commented
May 16, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families
Validation
  • git diff --check
Summary by CodeRabbit
  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.
Review Change Stack
CopilotAI
review requested due to automatic review settings
May 16, 2026 02:49
@coderabbitai
coderabbitaiBot
commented
May 16, 2026•

edited

Loading

Copy link


Copy Markdown

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa
📥 Commits
Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.
📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough
Walkthrough
This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.
Changes
Documentation Clarifications
Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🐰 Two small docs so bright,

Clarifying bots' delight—

Discord threads and tests aligned,

Guild-keeper wisdom, neatly signed!
whisker twitch ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch michaelmwu/document-agent-memory-lessons
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.
Changes:
  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@michaelmwu
michaelmwu
merged commit 7c92aa8
into
mainMay 16, 2026

11 checks passed

@michaelmwu
michaelmwu
deleted the

michaelmwu/document-agent-memory-lessons

branch
May 16, 2026 02:51
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Document agent memory lessons - #286
Merged
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged
Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
Conversation
@michaelmwu
@michaelmwumichaelmwu
commented
May 16, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families
Validation
  • git diff --check
Summary by CodeRabbit
  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.
Review Change Stack
CopilotAI
review requested due to automatic review settings
May 16, 2026 02:49
@coderabbitai
coderabbitaiBot
commented
May 16, 2026•

edited

Loading

Copy link


Copy Markdown

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa
📥 Commits
Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.
📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough
Walkthrough
This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.
Changes
Documentation Clarifications
Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🐰 Two small docs so bright,

Clarifying bots' delight—

Discord threads and tests aligned,

Guild-keeper wisdom, neatly signed!
whisker twitch ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch michaelmwu/document-agent-memory-lessons
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.
Changes:
  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@michaelmwu
michaelmwu
merged commit 7c92aa8
into
mainMay 16, 2026

11 checks passed

@michaelmwu
michaelmwu
deleted the

michaelmwu/document-agent-memory-lessons

branch
May 16, 2026 02:51
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Document agent memory lessons - #286
Merged
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
May 16, 2026
Merged
Document agent memory lessons#286
michaelmwu merged 1 commit into
mainfrom 
michaelmwu/document-agent-memory-lessons
Conversation
@michaelmwu
@michaelmwumichaelmwu
commented
May 16, 2026•

edited by coderabbitai
Bot
Loading

Copy link


Copy Markdown

Member
Summary
  • clarify Discord agent mention response privacy in README
  • document canonical vs weekly eval guidance for new agent tool families
Validation
  • git diff --check
Summary by CodeRabbit
  • Documentation
    • Clarified Discord bot response handling for agent requests: lightweight clarifications remain in response threads, sensitive reports use ephemeral slash commands, and executed mention results are sent via direct message to ensure privacy.
    • Updated fixture guidance for the agent evaluation harness to constrain the canonical suite and define requirements for promoting new tool families based on prior testing.
Review Change Stack
CopilotAI
review requested due to automatic review settings
May 16, 2026 02:49
@coderabbitai
coderabbitaiBot
commented
May 16, 2026•

edited

Loading

Copy link


Copy Markdown

No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 218adbce-74bf-470c-9993-af848bdf8dfa
📥 Commits
Reviewing files that changed from the base of the PR and between 4a9be4e and 621336e.
📒 Files selected for processing (2)
  • README.md
  • docs/discord-agent-eval-harness.md
📝 Walkthrough
Walkthrough
This pull request clarifies Discord agent response routing behavior in the README and establishes escalation criteria for test fixture promotion in the eval harness documentation.
Changes
Documentation Clarifications
Layer / File(s)Summary
Discord agent response handling
README.md		README clarifies how agent request responses are routed: lightweight clarifications in response threads, sensitive reports via ephemeral slash commands, executed mention results and write confirmations via DM, and bot-thread replies continue the flow without repeating the mention.
Canonical test suite criteria
docs/discord-agent-eval-harness.md		Eval harness adds rules constraining the canonical suite to cases that gate both deterministic and live-planner PR runs, with an escalation path: new tool families start in weekly (after unit tests) and promote to canonical once live-planner routing is reliable.
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~3 minutes
🐰 Two small docs so bright,

Clarifying bots' delight—

Discord threads and tests aligned,

Guild-keeper wisdom, neatly signed!
whisker twitch ✨
🚥 Pre-merge checks | ✅ 4 | ❌ 1
❌ Failed checks (1 inconclusive)
Check nameStatusExplanationResolution
Title check❓ InconclusiveThe PR title 'Document agent memory lessons' is vague and does not clearly reflect the actual changes made, which involve Discord agent privacy clarifications and evaluation fixture guidance.Consider a more specific title such as 'Document Discord agent privacy and evaluation guidance' to better reflect the actual scope of changes in the PR.
✅ Passed checks (4 passed)
Check nameStatusExplanation
Description Check✅ PassedCheck skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage✅ PassedNo functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check✅ PassedCheck skipped because no linked issues were found for this pull request.
Out of Scope Changes check✅ PassedCheck skipped because no linked issues were found for this pull request.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  •  Create PR with unit tests
  •  Commit unit tests in branch michaelmwu/document-agent-memory-lessons
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
❤️ Share
Comment @coderabbitai help to get the list of available commands and usage tips.
CopilotAI
reviewed
May 16, 2026
View reviewed changes
CopilotAI
left a comment


Copy link


Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview
Documentation-only PR clarifying two operational details: Discord agent mention response privacy behavior, and guidance for promoting new agent tool families from weekly to canonical eval suites.
Changes:
  • Update README note to clarify that executed mention results and write confirmations are sent by DM (not public threads) to protect private memory/sensitive output.
  • Add guidance in the eval harness doc on staging new tool family fixtures in weekly before promoting to canonical.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
FileDescription
README.mdReworded Discord agent mention behavior note to document DM-based delivery of sensitive results.
docs/discord-agent-eval-harness.mdAdded paragraph describing the canonical-vs-weekly promotion workflow for new tool families.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
@michaelmwu
michaelmwu
merged commit 7c92aa8
into
mainMay 16, 2026

11 checks passed

@michaelmwu
michaelmwu
deleted the

michaelmwu/document-agent-memory-lessons

branch
May 16, 2026 02:51
@coderabbitaicoderabbitaiBot
mentioned this pull request
Aug 6, 2026
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments

Assignees


No one assigned


Labels


None yet


Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

2 participants

@michaelmwu