Skip to content

[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michaelmwu merged 12 commits into from
Jun 3, 2026
Merged

[codex] Apply devkit quality gate conventions #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
67d6f74
Apply devkit quality gate conventions
michaelmwu Jun 2, 2026
bc6e797
Fail check-all on stale dashboard assets
michaelmwu Jun 2, 2026
764fcf3
Narrow Python quality check paths
michaelmwu Jun 2, 2026
4166019
Stabilize dashboard Playwright status update
michaelmwu Jun 2, 2026
8b6cde3
Clarify dashboard build remediation
michaelmwu Jun 2, 2026
fc63098
Build dashboard check output in temp dir
michaelmwu Jun 2, 2026
8dd2056
Tighten dashboard review fixes
michaelmwu Jun 2, 2026
6face50
Compare dashboard build output in check-all
michaelmwu Jun 2, 2026
6812dc3
Assert dashboard application fixture exists
michaelmwu Jun 3, 2026
f453c5a
Upgrade service uv image to 0.11.18
michaelmwu Jun 3, 2026
6d347d1
Use manager uv for dev service restarts
michaelmwu Jun 3, 2026
e22add9
Use dashboard build script in check-all
michaelmwu Jun 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions DEVELOPMENT.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down
4 changes: 3 additions & 1 deletion README.md
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
Comment on lines 66 to +71
```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down
8 changes: 7 additions & 1 deletion apps/admin_dashboard/bunfig.toml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"
6 changes: 4 additions & 2 deletions apps/api/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down
6 changes: 4 additions & 2 deletions apps/discord_bot/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down
6 changes: 4 additions & 2 deletions apps/worker/Dockerfile
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down
39 changes: 34 additions & 5 deletions scripts/check-all.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo
Comment on lines +10 to +12

./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
rm -rf "$dashboard_build_dir"
}
Comment on lines +20 to +25
trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
cd apps/admin_dashboard
bun run build -- --outDir "$dashboard_build_dir"
)
Comment on lines +27 to +30
if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
echo
echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
echo "$diff_output"
exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
echo
echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
git status --short -- "$dashboard_static_dir"
exit 1
fi
echo

echo "All checks passed."
12 changes: 8 additions & 4 deletions scripts/dev.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN

Comment on lines +8 to +10
# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
web|api)
reclaim_service_port web
run_migrations
exec uv run --package api uvicorn five08.backend.api:create_app \
exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
--factory \
--host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
--port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
;;
worker)
run_migrations
exec uv run watchfiles \
worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
exec "$UV_BIN" run watchfiles \
--filter python \
--sigint-timeout 5 \
--sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
apps/worker/src \
packages/shared/src
;;
Expand Down
14 changes: 9 additions & 5 deletions scripts/dev_mux.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
selected_services = selected_services or set(ALL_SERVICES)
uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
uv_command = shlex.quote(uv_bin)
commands = [
(
"web",
[
"uv",
uv_bin,
"run",
"--package",
"api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
(
"worker",
[
"uv",
uv_bin,
"run",
"watchfiles",
"--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
"5",
"--sigkill-timeout",
"10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
"apps/worker/src",
"packages/shared/src",
],
),
(
"discord-bot",
[
"uv",
uv_bin,
"run",
"watchfiles",
"--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
"5",
"--sigkill-timeout",
"10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
"apps/discord_bot/src",
"packages/shared/src",
],
Expand Down
13 changes: 10 additions & 3 deletions scripts/format.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
cd apps/admin_dashboard
bun run format
)
13 changes: 10 additions & 3 deletions scripts/lint.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
cd apps/admin_dashboard
bun run lint
)
4 changes: 2 additions & 2 deletions scripts/mypy.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases
13 changes: 10 additions & 3 deletions scripts/test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
cd apps/admin_dashboard
bun run test
)
11 changes: 11 additions & 0 deletions scripts/typecheck.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
cd apps/admin_dashboard
bun run typecheck
)
30 changes: 26 additions & 4 deletions tests/integration/test_dashboard_playwright.py
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
gig_application_requested.set()
body = route.request.post_data_json
assert body["status"] == "unavailable"
casey_application_id = "22222222-2222-4222-8222-222222222222"
for application in gigs_list_payload[0]["applications"]:
if application["id"] == casey_application_id:
application["status"] = "unavailable"
break
Comment on lines +431 to +434
else:
raise AssertionError(
f"Expected Casey Candidate application fixture {casey_application_id}"
)
route.fulfill(
status=200,
content_type="application/json",
body=json.dumps(
{
"id": "22222222-2222-4222-8222-222222222222",
"id": casey_application_id,
"status": "unavailable",
}
),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
page.get_by_role("button", name="Add candidate").click()
assert gig_application_add_requested.wait(timeout=5)
page.get_by_text("Devon Candidate").wait_for()
page.get_by_label("Candidate status for Casey Candidate").select_option(
"unavailable"
)
casey_status = page.get_by_label("Candidate status for Casey Candidate")
expect(casey_status).to_be_enabled()
expect(casey_status).to_have_value("suggested")
with page.expect_request(
lambda request: (
request.method == "POST"
and request.url.endswith(
"/dashboard/api/gigs/"
"11111111-1111-4111-8111-111111111111"
"/applications/"
"22222222-2222-4222-8222-222222222222/status"
)
)
):
casey_status.select_option("unavailable")
assert gig_application_requested.wait(timeout=5)
expect(casey_status).to_have_value("unavailable")
assert gig_detail_requests

gigs_list_payload = []
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
[codex] Apply devkit quality gate conventions by michaelmwu · Pull Request #323 · 508-dev/508-workflows · GitHub
Skip to content
[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

michaelmwu
merged 12 commits into

from

Jun 3, 2026
 Merged


[codex] Apply devkit quality gate conventions
#323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
67d6f74

Apply devkit quality gate conventions


michaelmwu Jun 2, 2026
bc6e797

Fail check-all on stale dashboard assets


michaelmwu Jun 2, 2026
764fcf3

Narrow Python quality check paths


michaelmwu Jun 2, 2026
4166019

Stabilize dashboard Playwright status update


michaelmwu Jun 2, 2026
8b6cde3

Clarify dashboard build remediation


michaelmwu Jun 2, 2026
fc63098

Build dashboard check output in temp dir


michaelmwu Jun 2, 2026
8dd2056

Tighten dashboard review fixes


michaelmwu Jun 2, 2026
6face50

Compare dashboard build output in check-all


michaelmwu Jun 2, 2026
6812dc3

Assert dashboard application fixture exists


michaelmwu Jun 3, 2026
f453c5a

Upgrade service uv image to 0.11.18


michaelmwu Jun 3, 2026
6d347d1

Use manager uv for dev service restarts


michaelmwu Jun 3, 2026
e22add9

Use dashboard build script in check-all


michaelmwu Jun 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
DEVELOPMENT.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down

4 changes: 3 additions & 1 deletion
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh

Comment on lines

66
 to 
+71

```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down

8 changes: 7 additions & 1 deletion
apps/admin_dashboard/bunfig.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"

6 changes: 4 additions & 2 deletions
apps/api/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/discord_bot/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/worker/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

39 changes: 34 additions & 5 deletions
scripts/check-all.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo

Comment on lines

+10
 to 
+12


./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
 rm -rf "$dashboard_build_dir"
}

Comment on lines

+20
 to 
+25

trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
 cd apps/admin_dashboard
 bun run build -- --outDir "$dashboard_build_dir"
)

Comment on lines

+27
 to 
+30

if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 echo "$diff_output"
 exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 git status --short -- "$dashboard_static_dir"
 exit 1
fi
echo

echo "All checks passed."

12 changes: 8 additions & 4 deletions
scripts/dev.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN


Comment on lines

+8
 to 
+10

# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
 web|api)
 reclaim_service_port web
 run_migrations
 exec uv run --package api uvicorn five08.backend.api:create_app \
 exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
 --factory \
 --host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
 --port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
 ;;
 worker)
 run_migrations
 exec uv run watchfiles \
 worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
 exec "$UV_BIN" run watchfiles \
 --filter python \
 --sigint-timeout 5 \
 --sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
 apps/worker/src \
 packages/shared/src
 ;;
Expand Down

14 changes: 9 additions & 5 deletions
scripts/dev_mux.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
 env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
 selected_services = selected_services or set(ALL_SERVICES)
 uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
 uv_command = shlex.quote(uv_bin)
 commands = [
 (
 "web",
 [
"uv",
uv_bin,
 "run",
 "--package",
 "api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
 (
 "worker",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
 "apps/worker/src",
 "packages/shared/src",
 ],
 ),
 (
 "discord-bot",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
 "apps/discord_bot/src",
 "packages/shared/src",
 ],
Expand Down

13 changes: 10 additions & 3 deletions
scripts/format.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
 cd apps/admin_dashboard
 bun run format
)

13 changes: 10 additions & 3 deletions
scripts/lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
 cd apps/admin_dashboard
 bun run lint
)

4 changes: 2 additions & 2 deletions
scripts/mypy.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases

13 changes: 10 additions & 3 deletions
scripts/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
 cd apps/admin_dashboard
 bun run test
)

11 changes: 11 additions & 0 deletions
scripts/typecheck.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
 cd apps/admin_dashboard
 bun run typecheck
)

30 changes: 26 additions & 4 deletions
tests/integration/test_dashboard_playwright.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
 gig_application_requested.set()
 body = route.request.post_data_json
 assert body["status"] == "unavailable"
 casey_application_id = "22222222-2222-4222-8222-222222222222"
 for application in gigs_list_payload[0]["applications"]:
 if application["id"] == casey_application_id:
 application["status"] = "unavailable"
 break

Comment on lines

+431
 to 
+434

 else:
 raise AssertionError(
 f"Expected Casey Candidate application fixture {casey_application_id}"
 )
 route.fulfill(
 status=200,
 content_type="application/json",
 body=json.dumps(
 {
 "id": "22222222-2222-4222-8222-222222222222",
 "id": casey_application_id,
 "status": "unavailable",
 }
 ),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
 page.get_by_role("button", name="Add candidate").click()
 assert gig_application_add_requested.wait(timeout=5)
 page.get_by_text("Devon Candidate").wait_for()
 page.get_by_label("Candidate status for Casey Candidate").select_option(
 "unavailable"
 )
 casey_status = page.get_by_label("Candidate status for Casey Candidate")
 expect(casey_status).to_be_enabled()
 expect(casey_status).to_have_value("suggested")
 with page.expect_request(
 lambda request: (
 request.method == "POST"
 and request.url.endswith(
 "/dashboard/api/gigs/"
 "11111111-1111-4111-8111-111111111111"
 "/applications/"
 "22222222-2222-4222-8222-222222222222/status"
 )
 )
 ):
 casey_status.select_option("unavailable")
 assert gig_application_requested.wait(timeout=5)
 expect(casey_status).to_have_value("unavailable")
 assert gig_detail_requests

 gigs_list_payload = []
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[codex] Apply devkit quality gate conventions by michaelmwu · Pull Request #323 · 508-dev/508-workflows · GitHub
Skip to content
[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

michaelmwu
merged 12 commits into

from

Jun 3, 2026
 Merged


[codex] Apply devkit quality gate conventions
#323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
67d6f74

Apply devkit quality gate conventions


michaelmwu Jun 2, 2026
bc6e797

Fail check-all on stale dashboard assets


michaelmwu Jun 2, 2026
764fcf3

Narrow Python quality check paths


michaelmwu Jun 2, 2026
4166019

Stabilize dashboard Playwright status update


michaelmwu Jun 2, 2026
8b6cde3

Clarify dashboard build remediation


michaelmwu Jun 2, 2026
fc63098

Build dashboard check output in temp dir


michaelmwu Jun 2, 2026
8dd2056

Tighten dashboard review fixes


michaelmwu Jun 2, 2026
6face50

Compare dashboard build output in check-all


michaelmwu Jun 2, 2026
6812dc3

Assert dashboard application fixture exists


michaelmwu Jun 3, 2026
f453c5a

Upgrade service uv image to 0.11.18


michaelmwu Jun 3, 2026
6d347d1

Use manager uv for dev service restarts


michaelmwu Jun 3, 2026
e22add9

Use dashboard build script in check-all


michaelmwu Jun 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
DEVELOPMENT.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down

4 changes: 3 additions & 1 deletion
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh

Comment on lines

66
 to 
+71

```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down

8 changes: 7 additions & 1 deletion
apps/admin_dashboard/bunfig.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"

6 changes: 4 additions & 2 deletions
apps/api/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/discord_bot/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/worker/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

39 changes: 34 additions & 5 deletions
scripts/check-all.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo

Comment on lines

+10
 to 
+12


./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
 rm -rf "$dashboard_build_dir"
}

Comment on lines

+20
 to 
+25

trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
 cd apps/admin_dashboard
 bun run build -- --outDir "$dashboard_build_dir"
)

Comment on lines

+27
 to 
+30

if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 echo "$diff_output"
 exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 git status --short -- "$dashboard_static_dir"
 exit 1
fi
echo

echo "All checks passed."

12 changes: 8 additions & 4 deletions
scripts/dev.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN


Comment on lines

+8
 to 
+10

# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
 web|api)
 reclaim_service_port web
 run_migrations
 exec uv run --package api uvicorn five08.backend.api:create_app \
 exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
 --factory \
 --host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
 --port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
 ;;
 worker)
 run_migrations
 exec uv run watchfiles \
 worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
 exec "$UV_BIN" run watchfiles \
 --filter python \
 --sigint-timeout 5 \
 --sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
 apps/worker/src \
 packages/shared/src
 ;;
Expand Down

14 changes: 9 additions & 5 deletions
scripts/dev_mux.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
 env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
 selected_services = selected_services or set(ALL_SERVICES)
 uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
 uv_command = shlex.quote(uv_bin)
 commands = [
 (
 "web",
 [
"uv",
uv_bin,
 "run",
 "--package",
 "api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
 (
 "worker",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
 "apps/worker/src",
 "packages/shared/src",
 ],
 ),
 (
 "discord-bot",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
 "apps/discord_bot/src",
 "packages/shared/src",
 ],
Expand Down

13 changes: 10 additions & 3 deletions
scripts/format.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
 cd apps/admin_dashboard
 bun run format
)

13 changes: 10 additions & 3 deletions
scripts/lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
 cd apps/admin_dashboard
 bun run lint
)

4 changes: 2 additions & 2 deletions
scripts/mypy.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases

13 changes: 10 additions & 3 deletions
scripts/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
 cd apps/admin_dashboard
 bun run test
)

11 changes: 11 additions & 0 deletions
scripts/typecheck.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
 cd apps/admin_dashboard
 bun run typecheck
)

30 changes: 26 additions & 4 deletions
tests/integration/test_dashboard_playwright.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
 gig_application_requested.set()
 body = route.request.post_data_json
 assert body["status"] == "unavailable"
 casey_application_id = "22222222-2222-4222-8222-222222222222"
 for application in gigs_list_payload[0]["applications"]:
 if application["id"] == casey_application_id:
 application["status"] = "unavailable"
 break

Comment on lines

+431
 to 
+434

 else:
 raise AssertionError(
 f"Expected Casey Candidate application fixture {casey_application_id}"
 )
 route.fulfill(
 status=200,
 content_type="application/json",
 body=json.dumps(
 {
 "id": "22222222-2222-4222-8222-222222222222",
 "id": casey_application_id,
 "status": "unavailable",
 }
 ),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
 page.get_by_role("button", name="Add candidate").click()
 assert gig_application_add_requested.wait(timeout=5)
 page.get_by_text("Devon Candidate").wait_for()
 page.get_by_label("Candidate status for Casey Candidate").select_option(
 "unavailable"
 )
 casey_status = page.get_by_label("Candidate status for Casey Candidate")
 expect(casey_status).to_be_enabled()
 expect(casey_status).to_have_value("suggested")
 with page.expect_request(
 lambda request: (
 request.method == "POST"
 and request.url.endswith(
 "/dashboard/api/gigs/"
 "11111111-1111-4111-8111-111111111111"
 "/applications/"
 "22222222-2222-4222-8222-222222222222/status"
 )
 )
 ):
 casey_status.select_option("unavailable")
 assert gig_application_requested.wait(timeout=5)
 expect(casey_status).to_have_value("unavailable")
 assert gig_detail_requests

 gigs_list_payload = []
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[codex] Apply devkit quality gate conventions by michaelmwu · Pull Request #323 · 508-dev/508-workflows · GitHub
Skip to content
[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

michaelmwu
merged 12 commits into

from

Jun 3, 2026
 Merged


[codex] Apply devkit quality gate conventions
#323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
67d6f74

Apply devkit quality gate conventions


michaelmwu Jun 2, 2026
bc6e797

Fail check-all on stale dashboard assets


michaelmwu Jun 2, 2026
764fcf3

Narrow Python quality check paths


michaelmwu Jun 2, 2026
4166019

Stabilize dashboard Playwright status update


michaelmwu Jun 2, 2026
8b6cde3

Clarify dashboard build remediation


michaelmwu Jun 2, 2026
fc63098

Build dashboard check output in temp dir


michaelmwu Jun 2, 2026
8dd2056

Tighten dashboard review fixes


michaelmwu Jun 2, 2026
6face50

Compare dashboard build output in check-all


michaelmwu Jun 2, 2026
6812dc3

Assert dashboard application fixture exists


michaelmwu Jun 3, 2026
f453c5a

Upgrade service uv image to 0.11.18


michaelmwu Jun 3, 2026
6d347d1

Use manager uv for dev service restarts


michaelmwu Jun 3, 2026
e22add9

Use dashboard build script in check-all


michaelmwu Jun 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
DEVELOPMENT.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down

4 changes: 3 additions & 1 deletion
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh

Comment on lines

66
 to 
+71

```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down

8 changes: 7 additions & 1 deletion
apps/admin_dashboard/bunfig.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"

6 changes: 4 additions & 2 deletions
apps/api/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/discord_bot/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/worker/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

39 changes: 34 additions & 5 deletions
scripts/check-all.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo

Comment on lines

+10
 to 
+12


./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
 rm -rf "$dashboard_build_dir"
}

Comment on lines

+20
 to 
+25

trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
 cd apps/admin_dashboard
 bun run build -- --outDir "$dashboard_build_dir"
)

Comment on lines

+27
 to 
+30

if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 echo "$diff_output"
 exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 git status --short -- "$dashboard_static_dir"
 exit 1
fi
echo

echo "All checks passed."

12 changes: 8 additions & 4 deletions
scripts/dev.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN


Comment on lines

+8
 to 
+10

# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
 web|api)
 reclaim_service_port web
 run_migrations
 exec uv run --package api uvicorn five08.backend.api:create_app \
 exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
 --factory \
 --host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
 --port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
 ;;
 worker)
 run_migrations
 exec uv run watchfiles \
 worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
 exec "$UV_BIN" run watchfiles \
 --filter python \
 --sigint-timeout 5 \
 --sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
 apps/worker/src \
 packages/shared/src
 ;;
Expand Down

14 changes: 9 additions & 5 deletions
scripts/dev_mux.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
 env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
 selected_services = selected_services or set(ALL_SERVICES)
 uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
 uv_command = shlex.quote(uv_bin)
 commands = [
 (
 "web",
 [
"uv",
uv_bin,
 "run",
 "--package",
 "api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
 (
 "worker",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
 "apps/worker/src",
 "packages/shared/src",
 ],
 ),
 (
 "discord-bot",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
 "apps/discord_bot/src",
 "packages/shared/src",
 ],
Expand Down

13 changes: 10 additions & 3 deletions
scripts/format.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
 cd apps/admin_dashboard
 bun run format
)

13 changes: 10 additions & 3 deletions
scripts/lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
 cd apps/admin_dashboard
 bun run lint
)

4 changes: 2 additions & 2 deletions
scripts/mypy.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases

13 changes: 10 additions & 3 deletions
scripts/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
 cd apps/admin_dashboard
 bun run test
)

11 changes: 11 additions & 0 deletions
scripts/typecheck.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
 cd apps/admin_dashboard
 bun run typecheck
)

30 changes: 26 additions & 4 deletions
tests/integration/test_dashboard_playwright.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
 gig_application_requested.set()
 body = route.request.post_data_json
 assert body["status"] == "unavailable"
 casey_application_id = "22222222-2222-4222-8222-222222222222"
 for application in gigs_list_payload[0]["applications"]:
 if application["id"] == casey_application_id:
 application["status"] = "unavailable"
 break

Comment on lines

+431
 to 
+434

 else:
 raise AssertionError(
 f"Expected Casey Candidate application fixture {casey_application_id}"
 )
 route.fulfill(
 status=200,
 content_type="application/json",
 body=json.dumps(
 {
 "id": "22222222-2222-4222-8222-222222222222",
 "id": casey_application_id,
 "status": "unavailable",
 }
 ),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
 page.get_by_role("button", name="Add candidate").click()
 assert gig_application_add_requested.wait(timeout=5)
 page.get_by_text("Devon Candidate").wait_for()
 page.get_by_label("Candidate status for Casey Candidate").select_option(
 "unavailable"
 )
 casey_status = page.get_by_label("Candidate status for Casey Candidate")
 expect(casey_status).to_be_enabled()
 expect(casey_status).to_have_value("suggested")
 with page.expect_request(
 lambda request: (
 request.method == "POST"
 and request.url.endswith(
 "/dashboard/api/gigs/"
 "11111111-1111-4111-8111-111111111111"
 "/applications/"
 "22222222-2222-4222-8222-222222222222/status"
 )
 )
 ):
 casey_status.select_option("unavailable")
 assert gig_application_requested.wait(timeout=5)
 expect(casey_status).to_have_value("unavailable")
 assert gig_detail_requests

 gigs_list_payload = []
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
[codex] Apply devkit quality gate conventions by michaelmwu · Pull Request #323 · 508-dev/508-workflows · GitHub
Skip to content
[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

michaelmwu
merged 12 commits into

from

Jun 3, 2026
 Merged


[codex] Apply devkit quality gate conventions
#323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
67d6f74

Apply devkit quality gate conventions


michaelmwu Jun 2, 2026
bc6e797

Fail check-all on stale dashboard assets


michaelmwu Jun 2, 2026
764fcf3

Narrow Python quality check paths


michaelmwu Jun 2, 2026
4166019

Stabilize dashboard Playwright status update


michaelmwu Jun 2, 2026
8b6cde3

Clarify dashboard build remediation


michaelmwu Jun 2, 2026
fc63098

Build dashboard check output in temp dir


michaelmwu Jun 2, 2026
8dd2056

Tighten dashboard review fixes


michaelmwu Jun 2, 2026
6face50

Compare dashboard build output in check-all


michaelmwu Jun 2, 2026
6812dc3

Assert dashboard application fixture exists


michaelmwu Jun 3, 2026
f453c5a

Upgrade service uv image to 0.11.18


michaelmwu Jun 3, 2026
6d347d1

Use manager uv for dev service restarts


michaelmwu Jun 3, 2026
e22add9

Use dashboard build script in check-all


michaelmwu Jun 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
DEVELOPMENT.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down

4 changes: 3 additions & 1 deletion
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh

Comment on lines

66
 to 
+71

```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down

8 changes: 7 additions & 1 deletion
apps/admin_dashboard/bunfig.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"

6 changes: 4 additions & 2 deletions
apps/api/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/discord_bot/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/worker/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

39 changes: 34 additions & 5 deletions
scripts/check-all.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo

Comment on lines

+10
 to 
+12


./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
 rm -rf "$dashboard_build_dir"
}

Comment on lines

+20
 to 
+25

trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
 cd apps/admin_dashboard
 bun run build -- --outDir "$dashboard_build_dir"
)

Comment on lines

+27
 to 
+30

if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 echo "$diff_output"
 exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 git status --short -- "$dashboard_static_dir"
 exit 1
fi
echo

echo "All checks passed."

12 changes: 8 additions & 4 deletions
scripts/dev.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN


Comment on lines

+8
 to 
+10

# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
 web|api)
 reclaim_service_port web
 run_migrations
 exec uv run --package api uvicorn five08.backend.api:create_app \
 exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
 --factory \
 --host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
 --port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
 ;;
 worker)
 run_migrations
 exec uv run watchfiles \
 worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
 exec "$UV_BIN" run watchfiles \
 --filter python \
 --sigint-timeout 5 \
 --sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
 apps/worker/src \
 packages/shared/src
 ;;
Expand Down

14 changes: 9 additions & 5 deletions
scripts/dev_mux.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
 env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
 selected_services = selected_services or set(ALL_SERVICES)
 uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
 uv_command = shlex.quote(uv_bin)
 commands = [
 (
 "web",
 [
"uv",
uv_bin,
 "run",
 "--package",
 "api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
 (
 "worker",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
 "apps/worker/src",
 "packages/shared/src",
 ],
 ),
 (
 "discord-bot",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
 "apps/discord_bot/src",
 "packages/shared/src",
 ],
Expand Down

13 changes: 10 additions & 3 deletions
scripts/format.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
 cd apps/admin_dashboard
 bun run format
)

13 changes: 10 additions & 3 deletions
scripts/lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
 cd apps/admin_dashboard
 bun run lint
)

4 changes: 2 additions & 2 deletions
scripts/mypy.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases

13 changes: 10 additions & 3 deletions
scripts/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
 cd apps/admin_dashboard
 bun run test
)

11 changes: 11 additions & 0 deletions
scripts/typecheck.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
 cd apps/admin_dashboard
 bun run typecheck
)

30 changes: 26 additions & 4 deletions
tests/integration/test_dashboard_playwright.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
 gig_application_requested.set()
 body = route.request.post_data_json
 assert body["status"] == "unavailable"
 casey_application_id = "22222222-2222-4222-8222-222222222222"
 for application in gigs_list_payload[0]["applications"]:
 if application["id"] == casey_application_id:
 application["status"] = "unavailable"
 break

Comment on lines

+431
 to 
+434

 else:
 raise AssertionError(
 f"Expected Casey Candidate application fixture {casey_application_id}"
 )
 route.fulfill(
 status=200,
 content_type="application/json",
 body=json.dumps(
 {
 "id": "22222222-2222-4222-8222-222222222222",
 "id": casey_application_id,
 "status": "unavailable",
 }
 ),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
 page.get_by_role("button", name="Add candidate").click()
 assert gig_application_add_requested.wait(timeout=5)
 page.get_by_text("Devon Candidate").wait_for()
 page.get_by_label("Candidate status for Casey Candidate").select_option(
 "unavailable"
 )
 casey_status = page.get_by_label("Candidate status for Casey Candidate")
 expect(casey_status).to_be_enabled()
 expect(casey_status).to_have_value("suggested")
 with page.expect_request(
 lambda request: (
 request.method == "POST"
 and request.url.endswith(
 "/dashboard/api/gigs/"
 "11111111-1111-4111-8111-111111111111"
 "/applications/"
 "22222222-2222-4222-8222-222222222222/status"
 )
 )
 ):
 casey_status.select_option("unavailable")
 assert gig_application_requested.wait(timeout=5)
 expect(casey_status).to_have_value("unavailable")
 assert gig_detail_requests

 gigs_list_payload = []
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[codex] Apply devkit quality gate conventions by michaelmwu · Pull Request #323 · 508-dev/508-workflows · GitHub
Skip to content
[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

michaelmwu
merged 12 commits into

from

Jun 3, 2026
 Merged


[codex] Apply devkit quality gate conventions
#323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
67d6f74

Apply devkit quality gate conventions


michaelmwu Jun 2, 2026
bc6e797

Fail check-all on stale dashboard assets


michaelmwu Jun 2, 2026
764fcf3

Narrow Python quality check paths


michaelmwu Jun 2, 2026
4166019

Stabilize dashboard Playwright status update


michaelmwu Jun 2, 2026
8b6cde3

Clarify dashboard build remediation


michaelmwu Jun 2, 2026
fc63098

Build dashboard check output in temp dir


michaelmwu Jun 2, 2026
8dd2056

Tighten dashboard review fixes


michaelmwu Jun 2, 2026
6face50

Compare dashboard build output in check-all


michaelmwu Jun 2, 2026
6812dc3

Assert dashboard application fixture exists


michaelmwu Jun 3, 2026
f453c5a

Upgrade service uv image to 0.11.18


michaelmwu Jun 3, 2026
6d347d1

Use manager uv for dev service restarts


michaelmwu Jun 3, 2026
e22add9

Use dashboard build script in check-all


michaelmwu Jun 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
DEVELOPMENT.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down

4 changes: 3 additions & 1 deletion
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh

Comment on lines

66
 to 
+71

```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down

8 changes: 7 additions & 1 deletion
apps/admin_dashboard/bunfig.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"

6 changes: 4 additions & 2 deletions
apps/api/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/discord_bot/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/worker/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

39 changes: 34 additions & 5 deletions
scripts/check-all.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo

Comment on lines

+10
 to 
+12


./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
 rm -rf "$dashboard_build_dir"
}

Comment on lines

+20
 to 
+25

trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
 cd apps/admin_dashboard
 bun run build -- --outDir "$dashboard_build_dir"
)

Comment on lines

+27
 to 
+30

if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 echo "$diff_output"
 exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 git status --short -- "$dashboard_static_dir"
 exit 1
fi
echo

echo "All checks passed."

12 changes: 8 additions & 4 deletions
scripts/dev.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN


Comment on lines

+8
 to 
+10

# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
 web|api)
 reclaim_service_port web
 run_migrations
 exec uv run --package api uvicorn five08.backend.api:create_app \
 exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
 --factory \
 --host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
 --port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
 ;;
 worker)
 run_migrations
 exec uv run watchfiles \
 worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
 exec "$UV_BIN" run watchfiles \
 --filter python \
 --sigint-timeout 5 \
 --sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
 apps/worker/src \
 packages/shared/src
 ;;
Expand Down

14 changes: 9 additions & 5 deletions
scripts/dev_mux.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
 env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
 selected_services = selected_services or set(ALL_SERVICES)
 uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
 uv_command = shlex.quote(uv_bin)
 commands = [
 (
 "web",
 [
"uv",
uv_bin,
 "run",
 "--package",
 "api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
 (
 "worker",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
 "apps/worker/src",
 "packages/shared/src",
 ],
 ),
 (
 "discord-bot",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
 "apps/discord_bot/src",
 "packages/shared/src",
 ],
Expand Down

13 changes: 10 additions & 3 deletions
scripts/format.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
 cd apps/admin_dashboard
 bun run format
)

13 changes: 10 additions & 3 deletions
scripts/lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
 cd apps/admin_dashboard
 bun run lint
)

4 changes: 2 additions & 2 deletions
scripts/mypy.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases

13 changes: 10 additions & 3 deletions
scripts/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
 cd apps/admin_dashboard
 bun run test
)

11 changes: 11 additions & 0 deletions
scripts/typecheck.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
 cd apps/admin_dashboard
 bun run typecheck
)

30 changes: 26 additions & 4 deletions
tests/integration/test_dashboard_playwright.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
 gig_application_requested.set()
 body = route.request.post_data_json
 assert body["status"] == "unavailable"
 casey_application_id = "22222222-2222-4222-8222-222222222222"
 for application in gigs_list_payload[0]["applications"]:
 if application["id"] == casey_application_id:
 application["status"] = "unavailable"
 break

Comment on lines

+431
 to 
+434

 else:
 raise AssertionError(
 f"Expected Casey Candidate application fixture {casey_application_id}"
 )
 route.fulfill(
 status=200,
 content_type="application/json",
 body=json.dumps(
 {
 "id": "22222222-2222-4222-8222-222222222222",
 "id": casey_application_id,
 "status": "unavailable",
 }
 ),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
 page.get_by_role("button", name="Add candidate").click()
 assert gig_application_add_requested.wait(timeout=5)
 page.get_by_text("Devon Candidate").wait_for()
 page.get_by_label("Candidate status for Casey Candidate").select_option(
 "unavailable"
 )
 casey_status = page.get_by_label("Candidate status for Casey Candidate")
 expect(casey_status).to_be_enabled()
 expect(casey_status).to_have_value("suggested")
 with page.expect_request(
 lambda request: (
 request.method == "POST"
 and request.url.endswith(
 "/dashboard/api/gigs/"
 "11111111-1111-4111-8111-111111111111"
 "/applications/"
 "22222222-2222-4222-8222-222222222222/status"
 )
 )
 ):
 casey_status.select_option("unavailable")
 assert gig_application_requested.wait(timeout=5)
 expect(casey_status).to_have_value("unavailable")
 assert gig_detail_requests

 gigs_list_payload = []
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
[codex] Apply devkit quality gate conventions by michaelmwu · Pull Request #323 · 508-dev/508-workflows · GitHub
Skip to content
[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

michaelmwu
merged 12 commits into

from

Jun 3, 2026
 Merged


[codex] Apply devkit quality gate conventions
#323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
67d6f74

Apply devkit quality gate conventions


michaelmwu Jun 2, 2026
bc6e797

Fail check-all on stale dashboard assets


michaelmwu Jun 2, 2026
764fcf3

Narrow Python quality check paths


michaelmwu Jun 2, 2026
4166019

Stabilize dashboard Playwright status update


michaelmwu Jun 2, 2026
8b6cde3

Clarify dashboard build remediation


michaelmwu Jun 2, 2026
fc63098

Build dashboard check output in temp dir


michaelmwu Jun 2, 2026
8dd2056

Tighten dashboard review fixes


michaelmwu Jun 2, 2026
6face50

Compare dashboard build output in check-all


michaelmwu Jun 2, 2026
6812dc3

Assert dashboard application fixture exists


michaelmwu Jun 3, 2026
f453c5a

Upgrade service uv image to 0.11.18


michaelmwu Jun 3, 2026
6d347d1

Use manager uv for dev service restarts


michaelmwu Jun 3, 2026
e22add9

Use dashboard build script in check-all


michaelmwu Jun 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
DEVELOPMENT.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down

4 changes: 3 additions & 1 deletion
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh

Comment on lines

66
 to 
+71

```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down

8 changes: 7 additions & 1 deletion
apps/admin_dashboard/bunfig.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"

6 changes: 4 additions & 2 deletions
apps/api/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/discord_bot/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/worker/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

39 changes: 34 additions & 5 deletions
scripts/check-all.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo

Comment on lines

+10
 to 
+12


./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
 rm -rf "$dashboard_build_dir"
}

Comment on lines

+20
 to 
+25

trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
 cd apps/admin_dashboard
 bun run build -- --outDir "$dashboard_build_dir"
)

Comment on lines

+27
 to 
+30

if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 echo "$diff_output"
 exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 git status --short -- "$dashboard_static_dir"
 exit 1
fi
echo

echo "All checks passed."

12 changes: 8 additions & 4 deletions
scripts/dev.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN


Comment on lines

+8
 to 
+10

# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
 web|api)
 reclaim_service_port web
 run_migrations
 exec uv run --package api uvicorn five08.backend.api:create_app \
 exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
 --factory \
 --host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
 --port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
 ;;
 worker)
 run_migrations
 exec uv run watchfiles \
 worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
 exec "$UV_BIN" run watchfiles \
 --filter python \
 --sigint-timeout 5 \
 --sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
 apps/worker/src \
 packages/shared/src
 ;;
Expand Down

14 changes: 9 additions & 5 deletions
scripts/dev_mux.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
 env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
 selected_services = selected_services or set(ALL_SERVICES)
 uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
 uv_command = shlex.quote(uv_bin)
 commands = [
 (
 "web",
 [
"uv",
uv_bin,
 "run",
 "--package",
 "api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
 (
 "worker",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
 "apps/worker/src",
 "packages/shared/src",
 ],
 ),
 (
 "discord-bot",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
 "apps/discord_bot/src",
 "packages/shared/src",
 ],
Expand Down

13 changes: 10 additions & 3 deletions
scripts/format.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
 cd apps/admin_dashboard
 bun run format
)

13 changes: 10 additions & 3 deletions
scripts/lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
 cd apps/admin_dashboard
 bun run lint
)

4 changes: 2 additions & 2 deletions
scripts/mypy.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases

13 changes: 10 additions & 3 deletions
scripts/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
 cd apps/admin_dashboard
 bun run test
)

11 changes: 11 additions & 0 deletions
scripts/typecheck.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
 cd apps/admin_dashboard
 bun run typecheck
)

30 changes: 26 additions & 4 deletions
tests/integration/test_dashboard_playwright.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
 gig_application_requested.set()
 body = route.request.post_data_json
 assert body["status"] == "unavailable"
 casey_application_id = "22222222-2222-4222-8222-222222222222"
 for application in gigs_list_payload[0]["applications"]:
 if application["id"] == casey_application_id:
 application["status"] = "unavailable"
 break

Comment on lines

+431
 to 
+434

 else:
 raise AssertionError(
 f"Expected Casey Candidate application fixture {casey_application_id}"
 )
 route.fulfill(
 status=200,
 content_type="application/json",
 body=json.dumps(
 {
 "id": "22222222-2222-4222-8222-222222222222",
 "id": casey_application_id,
 "status": "unavailable",
 }
 ),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
 page.get_by_role("button", name="Add candidate").click()
 assert gig_application_add_requested.wait(timeout=5)
 page.get_by_text("Devon Candidate").wait_for()
 page.get_by_label("Candidate status for Casey Candidate").select_option(
 "unavailable"
 )
 casey_status = page.get_by_label("Candidate status for Casey Candidate")
 expect(casey_status).to_be_enabled()
 expect(casey_status).to_have_value("suggested")
 with page.expect_request(
 lambda request: (
 request.method == "POST"
 and request.url.endswith(
 "/dashboard/api/gigs/"
 "11111111-1111-4111-8111-111111111111"
 "/applications/"
 "22222222-2222-4222-8222-222222222222/status"
 )
 )
 ):
 casey_status.select_option("unavailable")
 assert gig_application_requested.wait(timeout=5)
 expect(casey_status).to_have_value("unavailable")
 assert gig_detail_requests

 gigs_list_payload = []
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();
[codex] Apply devkit quality gate conventions by michaelmwu · Pull Request #323 · 508-dev/508-workflows · GitHub
Skip to content
[codex] Apply devkit quality gate conventions#323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

michaelmwu
merged 12 commits into

from

Jun 3, 2026
 Merged


[codex] Apply devkit quality gate conventions
#323
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


12 commits


Select commit
Hold shift + click to select a range
67d6f74

Apply devkit quality gate conventions


michaelmwu Jun 2, 2026
bc6e797

Fail check-all on stale dashboard assets


michaelmwu Jun 2, 2026
764fcf3

Narrow Python quality check paths


michaelmwu Jun 2, 2026
4166019

Stabilize dashboard Playwright status update


michaelmwu Jun 2, 2026
8b6cde3

Clarify dashboard build remediation


michaelmwu Jun 2, 2026
fc63098

Build dashboard check output in temp dir


michaelmwu Jun 2, 2026
8dd2056

Tighten dashboard review fixes


michaelmwu Jun 2, 2026
6face50

Compare dashboard build output in check-all


michaelmwu Jun 2, 2026
6812dc3

Assert dashboard application fixture exists


michaelmwu Jun 3, 2026
f453c5a

Upgrade service uv image to 0.11.18


michaelmwu Jun 3, 2026
6d347d1

Use manager uv for dev service restarts


michaelmwu Jun 3, 2026
e22add9

Use dashboard build script in check-all


michaelmwu Jun 3, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


7 changes: 5 additions & 2 deletions
DEVELOPMENT.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -169,10 +169,13 @@ service Dockerfiles use BuildKit cache mounts.
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh
```

For dashboard-only checks:
These top-level scripts include the admin dashboard where applicable. For
dashboard-only checks:

```bash
cd apps/admin_dashboard
Expand Down

4 changes: 3 additions & 1 deletion
README.md

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -66,7 +66,9 @@ To run the Discord bot too:
./scripts/test.sh
./scripts/lint.sh
./scripts/format.sh
./scripts/mypy.sh
./scripts/typecheck.sh # Python mypy + dashboard TypeScript
./scripts/mypy.sh # Python-only typecheck
./scripts/check-all.sh

Comment on lines

66
 to 
+71

```

For workspace archival, stop host-run dev processes and Docker Compose together:
Expand Down

8 changes: 7 additions & 1 deletion
apps/admin_dashboard/bunfig.toml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,2 +1,8 @@
[install]
minimumReleaseAge = 604800 # 7 days
# Seven days, in seconds. Bun filters newly published direct and transitive
# package versions during resolution.
minimumReleaseAge = 604800
minimumReleaseAgeExcludes = ["@types/bun", "typescript"]

# Isolated installs reduce accidental reliance on undeclared dependencies.
linker = "isolated"

6 changes: 4 additions & 2 deletions
apps/api/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/discord_bot/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

6 changes: 4 additions & 2 deletions
apps/worker/Dockerfile

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
# syntax=docker/dockerfile:1.7
# Pinned from ghcr.io/astral-sh/uv:python3.12-bookworm-slim (verified 2026-02-21).
FROM ghcr.io/astral-sh/uv@sha256:e5b65587bce7de595f299855d7385fe7fca39b8a74baa261ba1b7147afa78e58
# Python pinned from python:3.12-slim-bookworm and uv pinned from ghcr.io/astral-sh/uv:0.11.18 (verified 2026-06-03).
FROM ghcr.io/astral-sh/uv@sha256:78bc42400d77b0678ba95765305c826652ed5431f399257271dda681d0318f03 AS uv
FROM python@sha256:93ab4b7fa528b25124c97bcc755415e60eb671a86b4dbe0328df2fe2d1c1193d
COPY --from=uv /uv /uvx /usr/local/bin/

WORKDIR /app
ENV UV_LINK_MODE=copy
Expand Down

39 changes: 34 additions & 5 deletions
scripts/check-all.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,16 +1,45 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running all checks..."
echo

./scripts/format.sh
./scripts/lint.sh
echo

./scripts/lint.sh
echo "Checking Python formatting..."
uv run ruff format --check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests
echo

Comment on lines

+10
 to 
+12


./scripts/mypy.sh
echo

echo "✅ All checks passed!"
./scripts/test.sh
echo

echo "Building admin dashboard..."
dashboard_static_dir="apps/api/src/five08/backend/static/dashboard"
dashboard_build_dir=$(mktemp -d "${TMPDIR:-/tmp}/five08-dashboard-build.XXXXXX")
cleanup_dashboard_build_dir() {
 rm -rf "$dashboard_build_dir"
}

Comment on lines

+20
 to 
+25

trap cleanup_dashboard_build_dir EXIT HUP INT TERM
(
 cd apps/admin_dashboard
 bun run build -- --outDir "$dashboard_build_dir"
)

Comment on lines

+27
 to 
+30

if ! diff_output=$(diff -qr "$dashboard_static_dir" "$dashboard_build_dir"); then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 echo "$diff_output"
 exit 1
fi
if [ -n "$(git status --porcelain -- "$dashboard_static_dir")" ]; then
 echo
 echo "Dashboard build output is stale. Run 'cd apps/admin_dashboard && bun run build' and commit the generated static assets."
 git status --short -- "$dashboard_static_dir"
 exit 1
fi
echo

echo "All checks passed."

12 changes: 8 additions & 4 deletions
scripts/dev.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -5,6 +5,9 @@ script_dir=$(CDPATH= cd "$(dirname "$0")" && pwd)
. "$script_dir/worktree-env.sh"
worktree_env_load "$script_dir"

UV_BIN=${UV_BIN:-$(command -v uv)}
export UV_BIN


Comment on lines

+8
 to 
+10

# dev.sh owns host-run service URLs so every launched process shares the same
# worktree-local infra and app ports.
export REDIS_URL="redis://127.0.0.1:${REDIS_HOST_PORT}/0"
Expand DownExpand Up@@ -41,7 +44,7 @@ start_infra() {
}

run_migrations() {
uv run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
"$UV_BIN" run --package worker python3 -c 'from five08.worker.db_migrations import run_job_migrations; run_job_migrations()'
}

reclaim_service_port() {
Expand DownExpand Up@@ -220,7 +223,7 @@ EOF
 web|api)
 reclaim_service_port web
 run_migrations
 exec uv run --package api uvicorn five08.backend.api:create_app \
 exec "$UV_BIN" run --package api uvicorn five08.backend.api:create_app \
 --factory \
 --host "${WEB_HOST:-${WEBHOOK_INGEST_HOST:-0.0.0.0}}" \
 --port "$WEB_PORT" \
Expand All@@ -231,11 +234,12 @@ EOF
 ;;
 worker)
 run_migrations
 exec uv run watchfiles \
 worker_command="$(shell_quote "$UV_BIN") run --package worker worker-consumer"
 exec "$UV_BIN" run watchfiles \
 --filter python \
 --sigint-timeout 5 \
 --sigkill-timeout 10 \
'uv run --package worker worker-consumer' \
"$worker_command" \
 apps/worker/src \
 packages/shared/src
 ;;
Expand Down

14 changes: 9 additions & 5 deletions
scripts/dev_mux.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -4,6 +4,8 @@
from __future__ import annotations

import os
import shlex
import shutil
import signal
import socket
import subprocess
Expand DownExpand Up@@ -33,11 +35,13 @@ def _service_commands(
 env: dict[str, str], selected_services: set[str] | None = None
) -> list[tuple[str, list[str]]]:
 selected_services = selected_services or set(ALL_SERVICES)
 uv_bin = env.get("UV_BIN") or shutil.which("uv") or "uv"
 uv_command = shlex.quote(uv_bin)
 commands = [
 (
 "web",
 [
"uv",
uv_bin,
 "run",
 "--package",
 "api",
Expand All@@ -60,7 +64,7 @@ def _service_commands(
 (
 "worker",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -69,15 +73,15 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package worker worker-consumer",
f"{uv_command} run --package worker worker-consumer",
 "apps/worker/src",
 "packages/shared/src",
 ],
 ),
 (
 "discord-bot",
 [
"uv",
uv_bin,
 "run",
 "watchfiles",
 "--filter",
Expand All@@ -86,7 +90,7 @@ def _service_commands(
 "5",
 "--sigkill-timeout",
 "10",
"uv run --package discord_bot discord-bot",
f"{uv_command} run --package discord_bot discord-bot",
 "apps/discord_bot/src",
 "packages/shared/src",
 ],
Expand Down

13 changes: 10 additions & 3 deletions
scripts/format.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff format..."
uv run ruff format apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff format apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard format..."
(
 cd apps/admin_dashboard
 bun run format
)

13 changes: 10 additions & 3 deletions
scripts/lint.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running ruff check..."
uv run ruff check apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ tests/
uv run ruff check apps/api/src/five08 apps/discord_bot/src/five08 apps/worker/src/five08 packages/shared/src/five08 tests

echo
echo "Running admin dashboard lint..."
(
 cd apps/admin_dashboard
 bun run lint
)

4 changes: 2 additions & 2 deletions
scripts/mypy.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running mypy..."
uv run mypy apps/api/src/five08/ apps/discord_bot/src/five08/ apps/worker/src/five08/ packages/shared/src/five08/ --ignore-missing-imports --explicit-package-bases

13 changes: 10 additions & 3 deletions
scripts/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -1,5 +1,12 @@
#!/bin/bash
set -e
#!/usr/bin/env sh
set -eu

echo "Running tests..."
uv run pytest tests/ -v --tb=short
uv run pytest tests/ -v --tb=short

echo
echo "Running admin dashboard tests..."
(
 cd apps/admin_dashboard
 bun run test
)

11 changes: 11 additions & 0 deletions
scripts/typecheck.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,11 @@
#!/usr/bin/env sh
set -eu

./scripts/mypy.sh

echo
echo "Running admin dashboard typecheck..."
(
 cd apps/admin_dashboard
 bun run typecheck
)

30 changes: 26 additions & 4 deletions
tests/integration/test_dashboard_playwright.py

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -427,12 +427,21 @@ def gig_application_status_route(route: Any) -> None:
 gig_application_requested.set()
 body = route.request.post_data_json
 assert body["status"] == "unavailable"
 casey_application_id = "22222222-2222-4222-8222-222222222222"
 for application in gigs_list_payload[0]["applications"]:
 if application["id"] == casey_application_id:
 application["status"] = "unavailable"
 break

Comment on lines

+431
 to 
+434

 else:
 raise AssertionError(
 f"Expected Casey Candidate application fixture {casey_application_id}"
 )
 route.fulfill(
 status=200,
 content_type="application/json",
 body=json.dumps(
 {
 "id": "22222222-2222-4222-8222-222222222222",
 "id": casey_application_id,
 "status": "unavailable",
 }
 ),
Expand DownExpand Up@@ -627,10 +636,23 @@ def sync_route(route: Any) -> None:
 page.get_by_role("button", name="Add candidate").click()
 assert gig_application_add_requested.wait(timeout=5)
 page.get_by_text("Devon Candidate").wait_for()
 page.get_by_label("Candidate status for Casey Candidate").select_option(
 "unavailable"
 )
 casey_status = page.get_by_label("Candidate status for Casey Candidate")
 expect(casey_status).to_be_enabled()
 expect(casey_status).to_have_value("suggested")
 with page.expect_request(
 lambda request: (
 request.method == "POST"
 and request.url.endswith(
 "/dashboard/api/gigs/"
 "11111111-1111-4111-8111-111111111111"
 "/applications/"
 "22222222-2222-4222-8222-222222222222/status"
 )
 )
 ):
 casey_status.select_option("unavailable")
 assert gig_application_requested.wait(timeout=5)
 expect(casey_status).to_have_value("unavailable")
 assert gig_detail_requests

 gigs_list_payload = []
Expand Down