Uh oh!
There was an error while loading. Please reload this page.
[codex] Add 508 members newsletter sync - #332
Merged
Merged
Conversation
Loading
Uh oh!
There was an error while loading. Please reload this page.
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/create-mailbox,/create-user-accounts, and agent account provisioning on direct best-effort newsletter sync for mailbox plus backup emailBREVO_508_MEMBERS_NEWSLETTER_LIST_NAMEwith production overrideBREVO_508_MEMBERS_NEWSLETTER_LIST_ID=4audiences: ["508_members"]for segmentingValidation
uv run pytest tests/ -quv run pytest tests/unit/test_brevo_client.py tests/unit/test_keila_client.py tests/unit/test_newsletter_sync.py tests/unit/test_migadu_create_mailbox.py tests/unit/test_crm_create_sso_user.py tests/unit/test_shared_settings.py tests/unit/test_agent_gateway.py tests/unit/test_backend_api.py./scripts/lint.sh./scripts/mypy.shFrontend verification note
bun run lintpasses through./scripts/lint.shbun run typecheckis blocked in this workspace becauseapps/admin_dashboard/node_moduleshas TypeScript 5.9.3 and is missing localtypescript/@types/bun, while the lockfile expects TypeScript 6.0.3 and@types/bunbun run testis blocked because localvitestis missing fromnode_modulesNotes
BREVO_508_MEMBERS_NEWSLETTER_LIST_ID=4; non-prod can omit it and rely on list-name lookup or leave Brevo disabled.508_membersaudience so Keila segments can target it.Summary by CodeRabbit