Uh oh!
There was an error while loading. Please reload this page.
Require id_type for mark-id-verified - #76
Conversation
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis pull request introduces comprehensive Discord bot documentation and extends the CRM cog's ID verification workflow to support an ID type field. The changes add documentation files for bot commands and permissions, while implementing a new Changes
Sequence Diagram(s)sequenceDiagram
participant User as Discord User
participant Cmd as mark_id_verified Command
participant Show as _show_mark_id_verified_contact_choices
participant View as Selection View
participant Verify as _mark_id_verified_for_contact
participant CRM as CRM Backend
User->>Cmd: /mark-id-verified search_term verified_by id_type
Cmd->>Show: Search for contact, pass id_type
Show->>View: Create selection UI with id_type
View-->>User: Display contact options
User->>View: Select contact
View->>Verify: Call with contact, verified_by, id_type, verified_at
Verify->>Verify: Build payload with id_type
Verify->>CRM: Update contact record with cVerifiedIdType
CRM-->>Verify: Confirmation
Verify->>View: Create embed with ID type display
View-->>User: Show verification result
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
apps/discord_bot/src/five08/discord_bot/cogs/crm.py (1)
2366-2377: Includeid_typein audit metadata for completeness.The success audit event is missing
id_typein its metadata, while the command-level audit events include it. For consistency and traceability, consider adding it here as well.♻️ Suggested improvement
self._audit_command( interaction=interaction, action="crm.mark_id_verified", result="success", metadata={ "contact_id": str(contact_id), "verified_by": verified_by, "verified_at": verified_at, + "id_type": id_type, }, resource_type="crm_contact", resource_id=str(contact_id), )🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@apps/discord_bot/src/five08/discord_bot/cogs/crm.py` around lines 2366 - 2377, The audit call for success in crm.mark_id_verified is missing the id_type field; update the metadata passed to self._audit_command (the block that currently contains "contact_id", "verified_by", "verified_at") to also include "id_type": id_type so the success event matches the command-level audit entries and uses the existing id_type variable in scope.DISCORD_BOT.md (1)
16-21: Clarify Admin-only command placement in permissions list.Line 19 mentions that
mark-id-verifiedrequiresAdmin, but it's listed under theSteering Committeebullet point, which could be confusing. Consider either moving it to theAdminsection or restructuring for clarity.📝 Suggested restructure
- `Admin`: - `/mark-id-verified` - `Steering Committee`: - - `/kimai-status`, `/link-discord-user`, `/unlinked-discord-users`, `/set-github-username` (for others), `/upload-resume` (for others), `mark-id-verified` requires `Admin`.+ - `/kimai-status`, `/link-discord-user`, `/unlinked-discord-users`, `/set-github-username` (for others), `/upload-resume` (for others) - `Member`: - `/search-members`, `/get-resume`, `/view-skills`🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@DISCORD_BOT.md` around lines 16 - 21, The documentation lists the command "mark-id-verified" under the "Steering Committee" section while stating it requires Admin, which is confusing; update DISCORD_BOT.md to either move "mark-id-verified" into the "Admin" bullet or explicitly annotate it in the "Steering Committee" list as "mark-id-verified (Admin only)" so the required role is unambiguous—search for the headings "Admin" and "Steering Committee" and the command name "mark-id-verified" to locate and correct the placement/annotation.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@apps/discord_bot/src/five08/discord_bot/cogs/crm.py`:
- Around line 2366-2377: The audit call for success in crm.mark_id_verified is
missing the id_type field; update the metadata passed to self._audit_command
(the block that currently contains "contact_id", "verified_by", "verified_at")
to also include "id_type": id_type so the success event matches the
command-level audit entries and uses the existing id_type variable in scope.
In `@DISCORD_BOT.md`:
- Around line 16-21: The documentation lists the command "mark-id-verified"
under the "Steering Committee" section while stating it requires Admin, which is
confusing; update DISCORD_BOT.md to either move "mark-id-verified" into the
"Admin" bullet or explicitly annotate it in the "Steering Committee" list as
"mark-id-verified (Admin only)" so the required role is unambiguous—search for
the headings "Admin" and "Steering Committee" and the command name
"mark-id-verified" to locate and correct the placement/annotation.
ℹ️ Review info
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
DISCORD_BOT.mdDISCORD_SLASH_COMMANDS.mdREADME.mdapps/discord_bot/src/five08/discord_bot/cogs/crm.py
Uh oh!
There was an error while loading. Please reload this page.
* feat: require id_type for mark-id-verified * docs: move slash command docs to linked command reference * docs: add consolidated Discord bot documentation file * docs: remove obsolete kimai slash commands * Handle optional id_type for mark-id-verified compatibility
* Require id_type for mark-id-verified (#76) * feat: require id_type for mark-id-verified * docs: move slash command docs to linked command reference * docs: add consolidated Discord bot documentation file * docs: remove obsolete kimai slash commands * Handle optional id_type for mark-id-verified compatibility * Add job rerun endpoint and CLI tooling (#81) * add rerun endpoint and jobsctl CLI * Fix rerun payload validation and stabilize jobsctl tests * fix: confirm overwrite for ID verified fields (#80) * fix: confirm ID verification overwrite before update * fix: require overwrite confirmation for single field conflicts * feat(worker): add jobsctl recent jobs query --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Description
id_typeto/mark-id-verifiedand wired it through the command handler, contact-selection flow, and CRM update payload.cVerifiedIdType(id_type) in addition to existingcIdVerifiedAtandcIdVerifiedByfields./mark-id-verifiedcommand and field mapping inREADME.md.Related Issue
None.
How Has This Been Tested?
Local hooks ran via commit (ruff and mypy passed) and no additional manual tests were executed.
Summary by CodeRabbit
Documentation
New Features