Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
fix: normalize DocuSeal completed_at queue contract by michaelmwu · Pull Request #78 · 508-dev/508-workflows · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: normalize DocuSeal completed_at queue contract by michaelmwu · Pull Request #78 · 508-dev/508-workflows · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: normalize DocuSeal completed_at queue contract by michaelmwu · Pull Request #78 · 508-dev/508-workflows · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' fix: normalize DocuSeal completed_at queue contract by michaelmwu · Pull Request #78 · 508-dev/508-workflows · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: normalize DocuSeal completed_at queue contract by michaelmwu · Pull Request #78 · 508-dev/508-workflows · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' fix: normalize DocuSeal completed_at queue contract by michaelmwu · Pull Request #78 · 508-dev/508-workflows · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); fix: normalize DocuSeal completed_at queue contract by michaelmwu · Pull Request #78 · 508-dev/508-workflows · GitHub
Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
Original file line numberDiff line numberDiff line change
Expand Up@@ -53,6 +53,8 @@ Migrations:
- `POST /webhooks/{source}`: Generic webhook enqueue endpoint.
- `POST /webhooks/espocrm`: EspoCRM webhook endpoint (expects array payload).
- `POST /webhooks/espocrm/people-sync`: EspoCRM contact-change webhook for people cache sync.
- `POST /webhooks/docuseal`: See worker webhook contract docs in
[`apps/worker/README.md`](apps/worker/README.md#webhooks).
- `POST /process-contact/{contact_id}`: Manually enqueue one contact skills job.
- `POST /sync/people`: Manually enqueue a full CRM->people cache sync.
- `POST /audit/events`: Persist one human audit event (`discord` or `admin_dashboard`).
Expand Down
22 changes: 22 additions & 0 deletions apps/worker/README.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
# Worker Service

## Webhooks

### `POST /webhooks/docuseal`

Enqueues DocuSeal agreement-signing jobs.

- Job input contract for queueing: `completed_at` is a UTC string using `YYYY-MM-DD HH:mm:ss`.
- Example value: `2026-03-02 10:02:30`.

### `POST /webhooks/{source}`

Generic webhook enqueue endpoint.

### `POST /webhooks/espocrm`

EspoCRM webhook endpoint (expects array payload).

### `POST /webhooks/espocrm/people-sync`

EspoCRM contact-change webhook for people cache sync.
17 changes: 15 additions & 2 deletions apps/worker/src/five08/backend/api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -124,6 +124,15 @@ def _resume_extract_model_name() -> str:
return "heuristic"


def _coerce_docuseal_completed_at_to_utc(value: str) -> str:
"""Normalize Docuseal completion timestamps for queue/job payload contract."""
parsed = datetime.fromisoformat(value.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
utc_value = parsed.astimezone(timezone.utc)
return utc_value.strftime("%Y-%m-%d %H:%M:%S")


def _crm_sync_idempotency_key(*, now: datetime) -> str:
interval_seconds = max(1, settings.crm_sync_interval_seconds)
bucket = int(now.timestamp()) // interval_seconds
Expand DownExpand Up@@ -692,7 +701,11 @@ async def espocrm_people_sync_webhook_handler(request: Request) -> JSONResponse:


async def docuseal_webhook_handler(request: Request) -> JSONResponse:
"""Process a Docuseal form.completed webhook and enqueue agreement job."""
"""Process a Docuseal form.completed webhook and enqueue agreement job.

Job payload contract for the queue is:
completed_at = "YYYY-MM-DD HH:mm:ss" in UTC.
"""
if not _is_authorized(request):
return JSONResponse({"error": "unauthorized"}, status_code=401)

Expand DownExpand Up@@ -764,7 +777,7 @@ async def docuseal_webhook_handler(request: Request) -> JSONResponse:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

try:
datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
completed_at = _coerce_docuseal_completed_at_to_utc(completed_at)
except ValueError:
return JSONResponse({"error": "invalid_payload"}, status_code=400)

Expand Down
38 changes: 35 additions & 3 deletions apps/worker/src/five08/worker/crm/docuseal_processor.py
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
"""Docuseal member agreement processing workflow."""

import logging
from datetime import datetime, timezone
from typing import Any

from five08.clients.espo import EspoAPI, EspoAPIError
Expand All@@ -17,13 +18,27 @@ def __init__(self) -> None:
api_url = settings.espo_base_url.rstrip("/") + "/api/v1"
self.api = EspoAPI(api_url, settings.espo_api_key)

@staticmethod
def _normalize_completed_at(completed_at: str) -> str:
"""Normalize timestamp to the CRM-expected UTC format."""
parsed = datetime.fromisoformat(completed_at.replace("Z", "+00:00"))
if parsed.tzinfo is None:
parsed = parsed.replace(tzinfo=timezone.utc)
else:
parsed = parsed.astimezone(timezone.utc)
return parsed.strftime("%Y-%m-%d %H:%M:%S")

def process_agreement(
self,
email: str,
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Search for the signer by email and update cMemberAgreementSignedAt."""
"""Search for the signer by email and update cMemberAgreementSignedAt.

Expected input is the queue contract value:
``YYYY-MM-DD HH:mm:ss`` in UTC.
"""
masked_email = mask_email(email)

try:
Expand DownExpand Up@@ -66,12 +81,29 @@ def process_agreement(
contact = contacts[0]
contact_id = contact["id"]

try:
crm_completed_at = self._normalize_completed_at(completed_at)
except ValueError as exc:
logger.error(
"CRM update failed for contact_id=%s due to invalid datetime=%s: %s",
contact_id,
completed_at,
exc,
)
return {
"success": False,
"masked_email": masked_email,
"submission_id": submission_id,
"contact_id": contact_id,
"error": f"invalid_completed_at: {exc}",
}

try:
self.api.request(
"PUT",
f"Contact/{contact_id}",
{
"cMemberAgreementSignedAt": completed_at,
"cMemberAgreementSignedAt": crm_completed_at,
},
)
except EspoAPIError as exc:
Expand All@@ -94,5 +126,5 @@ def process_agreement(
"masked_email": masked_email,
"contact_id": contact_id,
"submission_id": submission_id,
"completed_at": completed_at,
"completed_at": crm_completed_at,
}
10 changes: 9 additions & 1 deletion apps/worker/src/five08/worker/jobs.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,6 +13,9 @@
logger = logging.getLogger(__name__)


DOCUSEAL_COMPLETED_AT_UTC_FORMAT = "%Y-%m-%d %H:%M:%S"


def process_contact_skills_job(contact_id: str) -> dict[str, Any]:
"""Process one EspoCRM contact and update their skills."""
logger.info("Processing queued contact skills job contact_id=%s", contact_id)
Expand DownExpand Up@@ -75,7 +78,12 @@ def process_docuseal_agreement_job(
completed_at: str,
submission_id: int,
) -> dict[str, Any]:
"""Mark a CRM contact as having signed the member agreement via Docuseal."""
"""Mark a CRM contact as having signed the member agreement via Docuseal.

Job input contract:
- completed_at is a UTC string, formatted as ``YYYY-MM-DD HH:mm:ss``.
- Keep it string-based to match JSON job payload serialization constraints.
"""
logger.info(
"Processing Docuseal agreement job masked_email=%s submission_id=%s",
mask_email(email),
Expand Down
39 changes: 39 additions & 0 deletions tests/unit/test_backend_api.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -631,9 +631,48 @@ def test_docuseal_webhook_enqueues_agreement_job(
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"] == ("member@508.dev", "2026-02-25 12:00:00", 4200)
assert call_kwargs["args"][1] == "2026-02-25 12:00:00"
assert call_kwargs["idempotency_key"] == "docuseal-agreement:4200"


def test_docuseal_webhook_converts_completed_at_to_utc_payload_contract(
client: TestClient,
auth_headers: dict[str, str],
monkeypatch: pytest.MonkeyPatch,
) -> None:
"""Docuseal timestamps should be serialized as UTC string contract payload args."""
monkeypatch.setattr(
api.settings,
"docuseal_member_agreement_template_id",
68,
)
payload = {
**_DOCUSEAL_PAYLOAD,
"data": {
**_DOCUSEAL_PAYLOAD["data"],
"completed_at": "2026-03-02T10:02:30.572+02:00",
},
"timestamp": "2026-03-02T10:02:30.572+02:00",
}
with patch("five08.backend.api.enqueue_job") as mock_enqueue:
mock_enqueue.return_value = Mock(id="job-ds-utc")
response = client.post(
"/webhooks/docuseal",
json=payload,
headers=auth_headers,
)

payload = response.json()
assert response.status_code == 202
assert payload["status"] == "queued"
assert payload["job_id"] == "job-ds-utc"
assert payload["submission_id"] == 4200

call_kwargs = mock_enqueue.call_args.kwargs
assert call_kwargs["args"][1] == "2026-03-02 08:02:30"


def test_docuseal_webhook_ignored_when_template_filter_unset(
client: TestClient,
auth_headers: dict[str, str],
Expand Down
45 changes: 44 additions & 1 deletion tests/unit/test_docuseal_processor.py
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,15 +28,58 @@ def test_docuseal_processor_marks_member_agreement_signed_timestamp() -> None:
assert mock_api.request.call_count == 2
assert mock_api.request.call_args_list[1].args[1] == "Contact/contact-1"
assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-02-25T12:00:00Z",
"cMemberAgreementSignedAt": "2026-02-25 12:00:00",
}
assert result["success"] is True
assert result["masked_email"] == expected_masked
assert result["contact_id"] == "contact-1"
assert result["submission_id"] == 416
assert result["completed_at"] == "2026-02-25 12:00:00"
assert "email" not in result


def test_docuseal_processor_normalizes_completed_at_to_utc_timestamp() -> None:
"""Processor should convert a UTC-offset timestamp before writing CRM."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
{"updated": True},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="2026-03-02T10:02:30.572+02:00",
submission_id=416,
)

assert mock_api.request.call_args_list[1].args[2] == {
"cMemberAgreementSignedAt": "2026-03-02 08:02:30",
}
assert result["completed_at"] == "2026-03-02 08:02:30"


def test_docuseal_processor_returns_error_on_invalid_completed_at() -> None:
"""Processor should return explicit invalid datetime errors instead of crashing."""
mock_api = Mock()
mock_api.request.side_effect = [
{"list": [{"id": "contact-1"}]},
]

with patch("five08.worker.crm.docuseal_processor.EspoAPI", return_value=mock_api):
processor = DocusealAgreementProcessor()
result = processor.process_agreement(
email="member@508.dev",
completed_at="not-a-date",
submission_id=416,
)

assert result["success"] is False
assert "invalid_completed_at" in result["error"]
assert mock_api.request.call_count == 1


def test_docuseal_processor_returns_contact_not_found_when_missing_contact() -> None:
"""Processor should return a contact-not-found error without raw email."""
mock_api = Mock()
Expand Down