feature: branded highlight outro (orchestration)

[Flegma]

Part 2 of 2: api (merge AFTER the game-streamer PR). Renderer: the feature/branded-outro PR in 5stackgg/game-streamer. Full design, both PRs, and merge order: 5stackgg/5stack-panel#514.

What

The orchestration half of the branded highlight outro: the api decides the outro cache hit/miss per render and passes branding env to the game-streamer render pod. The renderer PR consumes that env.

Changes

• src/matches/game-streamer/outro-branding.ts (new): pure helpers. computeOutroVersion = sha1(brandName|accent|logoEtag).slice(0,12), outroCacheKey = branding/outro_<version>_<dims>_<fps>.mp4, buildOutroEnv. outro-branding.spec.ts has 6 unit tests.

• game-streamer.service.ts: injects S3Service; resolveOutroBranding(dims, fps):

  • active only when a custom logo (public.logo_url) is set;
  • accent = public.color_dark_tactical_amber, then public.color_tactical_amber, then default 33 94% 58%;
  • seeds the cache version from the logo's S3 ETag (so a same-path logo re-upload invalidates);
  • presigns a cache GET on hit, or a PUT plus branding props on miss;
  • returns {} (which means baked stock outro) when no logo is set or on any error, so it never breaks a render.

  Wired into the batch-highlights pod env (pod-level) and the dispatchClipRenderToPod payload.

• src/matches/clips/clips.service.ts: passes outro_env in the on-demand dispatch payload.

No DB migration, no web change (reuses the existing branding settings).

Env contract (shared with the renderer PR)

Same six keys: CLIP_OUTRO_URL (hit), orCLIP_OUTRO_RENDER=1 + CLIP_OUTRO_PUT_URL + CLIP_BRAND_LOGO_URL + CLIP_BRAND_NAME + CLIP_BRAND_ACCENT (miss).

Merge order

Merge AFTER the game-streamer PR (which must ship :latest first). Safe either way thanks to the stock fallback, but the renderer must be updated before the api turns the feature on.

Verification

• jest 6/6 on the pure helpers; changed files tsc --noEmit clean (pre-existing project tsc errors, e.g. sharp, are unrelated).
• Whole-branch review on the most capable model verified the S3Service signatures, DI wiring, failure isolation, the exact env-name contract, and dims/fps consistency between the batch and on-demand paths. Ready to merge, no Critical/Important findings.

Non-blocking follow-ups

• Parallelize the independent settings reads (Promise.all) on the cold path.
• Add a resolver-orchestration unit test (no-logo returns {}, hit/miss env, stat-throws degrades). The pure helpers are tested; the orchestration was verified by review.

[Flegma]

Code + security review (multi-agent), addressed

Independent code review (Sonnet) and security review (Opus).

Security review: Ship (no Critical/High)

The trust boundary holds: no path injection (dims is a hardcoded enum, fps validated, the cache version is a sha1 digest, so nothing attacker-controlled reaches the S3 key), no SSRF reflection (the api only ever presigns its own bucket's admin-set logo), no secret leakage in logs, and the presigned PUT is scoped to a single content-addressed key.

Code review, fixed

• Moved resolveOutroBrandinginside the dispatch try in clips.service.ts, so a hypothetical unexpected throw still marks the job error (consistent with the other failure paths).
• Added S3_PUBLIC_ORIGIN to the demo-session pod env (startDemoPlayback) so the renderer can origin-allowlist the outro URLs against the real S3 presign origin, independent of the demo source. This keeps branded outros working for faceit/external demos (whose DEMO_URL origin differs).

Non-blocking follow-ups

• Parallelize the independent settings reads (Promise.all) on the cold path.
• Add a resolver-orchestration unit test (no-logo returns {}, hit/miss env, stat throws degrades). The pure helpers are unit-tested; the orchestration was verified by review.
• Defense-in-depth: authenticate or NetworkPolicy the render-pod spec-server endpoint (tracked in game-streamer#29 and [FEATURE] Branding for Highlights Outro 5stack-panel#514).

[Flegma]

Rebased onto current main (771265f) and re-verified; no functional changes.

Since this branch was cut, main touched the same files five times (highlight settings #325, stream security #327, game-server mono repo #343, demo improvements #346, playback perf #349), so this was worth re-checking rather than trusting a textually clean merge:

• Rebase applied 7/7 commits with no conflicts.
• Integration points re-inspected post-rebase: resolveOutroBranding still runs inside the dispatch try on the on-demand path and lands in outro_env; the batch path now derives dims/fps from the configurable clip settings (resolveClipResolution / resolveClipFps) introduced by feature: highlight settings #325, which is exactly what the outro cache key wants; S3_PUBLIC_ORIGIN is still set on the demo-session pod for the renderer's URL allowlist.
• outro-branding.spec.ts: 6/6 passing.
• tsc --noEmit: no new errors from this branch. Note that main itself currently has 19 pre-existing errors in src/matchmaking/matchmake.service.spec.ts (reproduced on untouched 771265f); unrelated to this PR, will be tracked separately.