Skip to content

Add French and Japanese locales - #136

Merged
Genora51 merged 9 commits into
8values:localizationfrom
doamatto:localization
Mar 29, 2021
Merged

Add French and Japanese locales#136
Genora51 merged 9 commits into
8values:localizationfrom
doamatto:localization

Conversation

@doamatto

Copy link
Copy Markdown
Contributor

Extension of #123.

Resolves#61.
Resolves#39.
Resolves#5.

@doamattodoamatto changed the title Add french localesAdd French localesMar 10, 2021
@doamattodoamatto mentioned this pull request Mar 10, 2021
9 tasks
@doamattodoamatto changed the title Add French localesAdd French and Japanese localesMar 10, 2021
@doamatto
doamatto marked this pull request as ready for review March 12, 2021 16:04

@yazgazanyazgazan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found some typos in the French translations.

Feel free to ignore the ones you disagree with.

Comment threadlocales/fr/instructions.json Outdated
Comment threadlocales/fr/instructions.json Outdated
Comment threadlocales/fr/quiz.json Outdated
Comment threadlocales/fr/translation.json
Comment threadlocales/fr/matches.json
Co-authored-by: Guillaume de Sagazan <guillaume@desagazan.fr>
@Genora51

Copy link
Copy Markdown
Member

Ok, I'm happy to merge this now

@Genora51
Genora51 merged commit 70deb4b into 8values:localizationMar 29, 2021
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@doamatto@Genora51@yazgazan