Sourcery refactored status-nested branch by sourcery-ai[bot] · Pull Request #4 · AABur/python-project-lvl2

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

sourcery-ai · 2021-01-24T18:53:49Z

Branch status-nested refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the status-nested branch, then run:

git fetch origin sourcery/status-nested
git merge --ff-only FETCH_HEAD
git reset HEAD^

sourcery-ai · 2021-01-24T18:53:50Z

- diff = {}
 keys_intersection = first_data_set.keys() & second_data_set.keys()
- for data_key in keys_intersection:
- diff[data_key] = compare_same_keys(
+ diff = {data_key: compare_same_keys(
 first_data_set.get(data_key), second_data_set.get(data_key),
- )
+ ) for data_key in keys_intersection}


Function compile_diff refactored with the following changes:
Convert for loop into dictionary comprehension (dict-comprehension)

sourcery-ai · 2021-01-24T18:54:00Z

Sourcery Code Quality Report

✅ Merging this PR will increase code quality in the affected files by 1.44%.

Quality metrics	Before	After	Change
Complexity	2.08 ⭐	1.58 ⭐	-0.50 👍
Method Length	51.33 ⭐	50.00 ⭐	-1.33 👍
Working memory	6.15 ⭐	6.00 ⭐	-0.15 👍
Quality	81.53% ⭐	82.97% ⭐	1.44% 👍

Other metrics	Before	After	Change
Lines	30	28	-2

Changed files	Quality Before	Quality After	Quality Change
gendiff/comparator.py	81.53% ⭐	82.97% ⭐	1.44% 👍

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

⭐ excellent
🙂 good
😞 poor
⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Let us know what you think of it by mentioning @sourcery-ai in a comment.

'Refactored by Sourcery'
ebd8028