Attributable errors - #2519

Closed
thomash-acinq wants to merge 6 commits into
masterfrom
fat-errors
Closed

Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom
fat-errors

Conversation

@thomash-acinq

@thomash-acinqthomash-acinq commented Dec 6, 2022

Copy link
Copy Markdown
Contributor

This is an implementation of the fat error proposal lightning/bolts#1044

@joostjager

joostjager commented Dec 8, 2022•
edited
Loading

Copy link
Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.

@thomash-acinq
thomash-acinqforce-pushed the fat-errors branch 2 times, most recently from 1e54913 to f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager mentioned this pull request May 15, 2023
Closed
@thomash-acinq
thomash-acinqforce-pushed the fat-errors branch 2 times, most recently from 517301d to 2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq changed the title Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq mentioned this pull request Aug 11, 2023
Merged
@codecov-commenter

codecov-commenter commented Aug 11, 2023•
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 84.29%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more

... and 4 files with indirect coverage changes

@thomash-acinq
thomash-acinqforce-pushed the fat-errors branch 2 times, most recently from 912fda0 to f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq

thomash-acinq commented Apr 24, 2025

Copy link
Copy Markdown
ContributorAuthor

Replaced by #3065

@t-bast
t-bast deleted the fat-errors branch July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees

No one assigned

Labels

Optech Make Me Famous!

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Attributable errors - #2519
Closed
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Closed
Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Conversation
@thomash-acinq
@thomash-acinqthomash-acinq
commented
Dec 6, 2022

Copy link


Copy Markdown

Contributor
This is an implementation of the fat error proposal lightning/bolts#1044
@joostjager
joostjager
commented
Dec 8, 2022•

edited

Loading

Copy link


Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
1e54913 to
f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager
mentioned this pull request
May 15, 2023

Closed

@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
517301d to
2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq
changed the title
Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq
mentioned this pull request
Aug 11, 2023
 Merged

@codecov-commenter
codecov-commenter
commented
Aug 11, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.

Report is 1 commits behind head on master.

The diff coverage is 84.29%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8 
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more
... and 4 files with indirect coverage changes
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
912fda0 to
f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq
thomash-acinq
commented
Apr 24, 2025

Copy link


Copy Markdown

ContributorAuthor
Replaced by #3065
@t-bast
t-bast
deleted the

fat-errors

branch
July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Attributable errors - #2519
Closed
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Closed
Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Conversation
@thomash-acinq
@thomash-acinqthomash-acinq
commented
Dec 6, 2022

Copy link


Copy Markdown

Contributor
This is an implementation of the fat error proposal lightning/bolts#1044
@joostjager
joostjager
commented
Dec 8, 2022•

edited

Loading

Copy link


Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
1e54913 to
f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager
mentioned this pull request
May 15, 2023

Closed

@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
517301d to
2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq
changed the title
Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq
mentioned this pull request
Aug 11, 2023
 Merged

@codecov-commenter
codecov-commenter
commented
Aug 11, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.

Report is 1 commits behind head on master.

The diff coverage is 84.29%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8 
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more
... and 4 files with indirect coverage changes
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
912fda0 to
f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq
thomash-acinq
commented
Apr 24, 2025

Copy link


Copy Markdown

ContributorAuthor
Replaced by #3065
@t-bast
t-bast
deleted the

fat-errors

branch
July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Attributable errors - #2519
Closed
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Closed
Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Conversation
@thomash-acinq
@thomash-acinqthomash-acinq
commented
Dec 6, 2022

Copy link


Copy Markdown

Contributor
This is an implementation of the fat error proposal lightning/bolts#1044
@joostjager
joostjager
commented
Dec 8, 2022•

edited

Loading

Copy link


Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
1e54913 to
f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager
mentioned this pull request
May 15, 2023

Closed

@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
517301d to
2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq
changed the title
Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq
mentioned this pull request
Aug 11, 2023
 Merged

@codecov-commenter
codecov-commenter
commented
Aug 11, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.

Report is 1 commits behind head on master.

The diff coverage is 84.29%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8 
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more
... and 4 files with indirect coverage changes
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
912fda0 to
f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq
thomash-acinq
commented
Apr 24, 2025

Copy link


Copy Markdown

ContributorAuthor
Replaced by #3065
@t-bast
t-bast
deleted the

fat-errors

branch
July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Attributable errors - #2519
Closed
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Closed
Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Conversation
@thomash-acinq
@thomash-acinqthomash-acinq
commented
Dec 6, 2022

Copy link


Copy Markdown

Contributor
This is an implementation of the fat error proposal lightning/bolts#1044
@joostjager
joostjager
commented
Dec 8, 2022•

edited

Loading

Copy link


Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
1e54913 to
f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager
mentioned this pull request
May 15, 2023

Closed

@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
517301d to
2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq
changed the title
Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq
mentioned this pull request
Aug 11, 2023
 Merged

@codecov-commenter
codecov-commenter
commented
Aug 11, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.

Report is 1 commits behind head on master.

The diff coverage is 84.29%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8 
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more
... and 4 files with indirect coverage changes
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
912fda0 to
f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq
thomash-acinq
commented
Apr 24, 2025

Copy link


Copy Markdown

ContributorAuthor
Replaced by #3065
@t-bast
t-bast
deleted the

fat-errors

branch
July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Attributable errors - #2519
Closed
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Closed
Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Conversation
@thomash-acinq
@thomash-acinqthomash-acinq
commented
Dec 6, 2022

Copy link


Copy Markdown

Contributor
This is an implementation of the fat error proposal lightning/bolts#1044
@joostjager
joostjager
commented
Dec 8, 2022•

edited

Loading

Copy link


Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
1e54913 to
f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager
mentioned this pull request
May 15, 2023

Closed

@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
517301d to
2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq
changed the title
Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq
mentioned this pull request
Aug 11, 2023
 Merged

@codecov-commenter
codecov-commenter
commented
Aug 11, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.

Report is 1 commits behind head on master.

The diff coverage is 84.29%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8 
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more
... and 4 files with indirect coverage changes
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
912fda0 to
f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq
thomash-acinq
commented
Apr 24, 2025

Copy link


Copy Markdown

ContributorAuthor
Replaced by #3065
@t-bast
t-bast
deleted the

fat-errors

branch
July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Attributable errors - #2519
Closed
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Closed
Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Conversation
@thomash-acinq
@thomash-acinqthomash-acinq
commented
Dec 6, 2022

Copy link


Copy Markdown

Contributor
This is an implementation of the fat error proposal lightning/bolts#1044
@joostjager
joostjager
commented
Dec 8, 2022•

edited

Loading

Copy link


Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
1e54913 to
f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager
mentioned this pull request
May 15, 2023

Closed

@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
517301d to
2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq
changed the title
Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq
mentioned this pull request
Aug 11, 2023
 Merged

@codecov-commenter
codecov-commenter
commented
Aug 11, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.

Report is 1 commits behind head on master.

The diff coverage is 84.29%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8 
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more
... and 4 files with indirect coverage changes
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
912fda0 to
f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq
thomash-acinq
commented
Apr 24, 2025

Copy link


Copy Markdown

ContributorAuthor
Replaced by #3065
@t-bast
t-bast
deleted the

fat-errors

branch
July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Universal Dark Mode - works on any site
(function() {
var enabled = true;
function applyDarkMode() {
if (!enabled) return;
// Create style element if it doesn't exist
var style = document.getElementById('universal-dark-mode-style');
if (!style) {
style = document.createElement('style');
style.id = 'universal-dark-mode-style';
document.head.appendChild(style);
}
// Dark mode CSS - inverts colors but preserves images/video
style.textContent = '
/* Invert everything except media */
html {
filter: invert(1) hue-rotate(180deg) !important;
background: #1a1a2e !important;
}
/* Restore images, videos, iframes, canvas */
img, video, iframe, canvas, svg, picture, [style*="background-image"] {
filter: invert(1) hue-rotate(180deg) !important;
}
/* Preserve specific elements that should not be inverted */
.no-dark-mode, .no-dark-mode *,
[data-theme="light"], [data-theme="light"],
.ace_editor, .ace_editor *,
.CodeMirror, .CodeMirror *,
.monaco-editor, .monaco-editor *,
.markdown-body pre, .markdown-body pre *,
.highlight, .highlight *,
pre code, pre code * {
filter: none !important;
}
/* Fix common UI elements */
.modal, .popup, .dropdown-menu, .tooltip, .popover {
filter: invert(1) hue-rotate(180deg) !important;
background: #2d2d44 !important;
border-color: #444 !important;
}
/* Scrollbars */
::-webkit-scrollbar { background: #1a1a2e !important; }
::-webkit-scrollbar-thumb { background: #444 !important; }
::-webkit-scrollbar-thumb:hover { background: #555 !important; }
/* Selection */
::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }
';
}
function removeDarkMode() {
var style = document.getElementById('universal-dark-mode-style');
if (style) style.remove();
}
// Toggle with Alt+Shift+D
document.addEventListener('keydown', function(e) {
if (e.altKey && e.shiftKey && e.key === 'D') {
e.preventDefault();
enabled = !enabled;
if (enabled) {
applyDarkMode();
console.log('[Universal Dark Mode] Enabled');
} else {
removeDarkMode();
console.log('[Universal Dark Mode] Disabled');
}
}
});
// Apply on load
applyDarkMode();
// Re-apply on dynamic content
var observer = new MutationObserver(function(mutations) {
if (enabled && !document.getElementById('universal-dark-mode-style')) {
applyDarkMode();
}
});
observer.observe(document.head, { childList: true });
console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');
})();
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Attributable errors - #2519
Closed
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Closed
Attributable errors#2519
thomash-acinq wants to merge 6 commits into
masterfrom 
fat-errors
Conversation
@thomash-acinq
@thomash-acinqthomash-acinq
commented
Dec 6, 2022

Copy link


Copy Markdown

Contributor
This is an implementation of the fat error proposal lightning/bolts#1044
@joostjager
joostjager
commented
Dec 8, 2022•

edited

Loading

Copy link


Copy Markdown

If you want to do interop testing, you can use lightningnetwork/lnd#7139. It supports fat errors as sender/intermediate/final node and populates the hold time field as well.
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
1e54913 to
f370fa5CompareDecember 12, 2022 11:43
@joostjagerjoostjager
mentioned this pull request
May 15, 2023

Closed

@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
517301d to
2f84f91CompareAugust 11, 2023 14:29
@thomash-acinqthomash-acinq
changed the title
Fat errorsAttributable errorsAug 11, 2023
@thomash-acinqthomash-acinq
mentioned this pull request
Aug 11, 2023
 Merged

@codecov-commenter
codecov-commenter
commented
Aug 11, 2023•

edited

Loading

Copy link


Copy Markdown

Codecov Report
Merging #2519 (5858fed) into master (772e2b2) will increase coverage by 0.02%.

Report is 1 commits behind head on master.

The diff coverage is 84.29%.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@ Coverage Diff @@## master #2519 +/- ##
==========================================
+ Coverage 85.84% 85.86% +0.02% 
==========================================
Files 216 217 +1 Lines 18158 18242 +84 Branches 760 798 +38 ==========================================
+ Hits 15588 15664 +76 - Misses 2570 2578 +8 
FilesCoverage Δ
...core/src/main/scala/fr/acinq/eclair/Features.scala100.00% <100.00%> (ø)
...in/scala/fr/acinq/eclair/channel/ChannelData.scala100.00% <ø> (ø)
...q/eclair/payment/receive/MultiPartPaymentFSM.scala95.12% <ø> (ø)
...a/fr/acinq/eclair/payment/relay/ChannelRelay.scala95.90% <100.00%> (+0.03%)⬆️
.../eclair/payment/relay/PostRestartHtlcCleaner.scala90.55% <100.00%> (ø)
.../fr/acinq/eclair/wire/internal/CommandCodecs.scala100.00% <ø> (ø)
...a/fr/acinq/eclair/wire/protocol/CommonCodecs.scala97.33% <100.00%> (+0.03%)⬆️
...fr/acinq/eclair/wire/protocol/FailureMessage.scala80.23% <100.00%> (ø)
...cala/fr/acinq/eclair/payment/relay/NodeRelay.scala96.57% <87.50%> (ø)
.../scala/fr/acinq/eclair/payment/relay/Relayer.scala89.13% <66.66%> (ø)
... and 6 more
... and 4 files with indirect coverage changes
@thomash-acinq
thomash-acinqforce-pushed
the
fat-errors
branch
2 times, most recently
from
912fda0 to
f31f81eCompareNovember 6, 2023 15:22
@thomash-acinq
Basic support for attributable errors
85317eb
This commit adds support for creating and relaying attributable errors but does not ask for others to use them.
Also doe snot advertize the feature.
@thomash-acinq
Add feature
e15ae71
@thomash-acinq
Better JSON handling in test
b20a26a
@thomash-acinq
36/37
363c167
@thomash-acinq
Default to legacy
bfdb39e
@thomash-acinq
Fill with zeros if the error to relay is too short
df0dab1
@thomash-acinq
thomash-acinq
commented
Apr 24, 2025

Copy link


Copy Markdown

ContributorAuthor
Replaced by #3065
@t-bast
t-bast
deleted the

fat-errors

branch
July 31, 2025 09:24
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@t-bastt-bastAwaiting requested review from t-bast

Assignees


No one assigned


Labels

Optech Make Me Famous!

Projects


None yet


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

4 participants

@thomash-acinq@joostjager@codecov-commenter@t-bast