Uh oh!
There was an error while loading. Please reload this page.
cmake build - #17
Open
gf712 wants to merge 9 commits into
Open
Conversation
added 9 commits
February 9, 2018 16:36
also changed the tests: - tmp directory might only be accessible with sudo rights in some systems causing tests to fail
- it does not make sense to check if boolean is less than 0 -> ABS(pdb->formal_charge <= 8) - this is probably meant to be ABS(pdb->formal_charge) <= 8)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wrote CMakeList.txt files that use cmake to generate Makefiles.
This makes it easier for any user to write to install and has the same behaviour as the current Makefiles. The main advantage is that it looks for dependencies and adds the corresponding libraries.
So to build bioplib, it would be something like this:
Note that all other original make recipies are included in the CMakeList.txt, e.g.
make shared.The root CMakeList.txt file also calls another CMakeList.txt file in the test/ directory which builds the test files.
(I also moved the test directory to the project directory to make it easier to find..)
I hope this is helpful, as I found it really convenient to install bioplib this way on my machine and I am working on something similar with bioptools!