Removed threshold_idx field and fixed class field in output - #1399
Draft
tobyallwood wants to merge 1 commit into
Draft
Removed threshold_idx field and fixed class field in output#1399tobyallwood wants to merge 1 commit into
tobyallwood wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1397
I previously misunderstood part of the big refactor and added a
threshold_idxfield to the output stats even though theclassfield should already show that data but that was broken. This has been rectified.Also because of the same misunderstanding some of the code in find_grains() was run multiple times on the same data so that has been changed too, meaning compute time and code complexity has been reduced there.
docs/usage/data_dictionary.md