Skip to content
This repository was archived by the owner on Jan 17, 2023. It is now read-only.

Compatibility with AFNetworking 3 and HTTP/2 - #22

Open
abbasmousavi wants to merge 8 commits into
AFNetworking:masterfrom
abbasmousavi:master
Open

Compatibility with AFNetworking 3 and HTTP/2#22
abbasmousavi wants to merge 8 commits into
AFNetworking:masterfrom
abbasmousavi:master

Conversation

@abbasmousavi

@abbasmousaviabbasmousavi commented Jun 1, 2016•
edited
Loading

Copy link
Copy Markdown

Using AFHTTPSessionManager instead of AFHTTPRequestOperation so that we can use AFJSONRPCClient with AFNetworking 3 and send JSON-RPC request over HTTP/2

@abbasmousaviabbasmousavi changed the title Using AFHTTPSessionManager instead of AFHTTPRequestOperationCompatibility with AFNetworking 3 and HTTP/2. Using AFHTTPSessionManager instead of AFHTTPRequestOperationJun 1, 2016
@abbasmousaviabbasmousavi changed the title Compatibility with AFNetworking 3 and HTTP/2. Using AFHTTPSessionManager instead of AFHTTPRequestOperationCompatibility with AFNetworking 3 and HTTP/2Jun 1, 2016
@abbasmousaviabbasmousavi mentioned this pull request Jun 13, 2016
Closed
@abbasmousavi

abbasmousavi commented Jun 26, 2016

Copy link
Copy Markdown
Author

@mattt@kylef@cnoon@kcharwood@wiistriker
Would you please review this PR.

kylef
kylef reviewed Jun 27, 2016
View reviewed changes
Comment threadAFJSONRPCClient/AFJSONRPCClient.h Outdated
// THE SOFTWARE.

#import "AFHTTPRequestOperationManager.h"
#import "AFHTTPSessionManager.h"

@kylefkylefJun 27, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably just import AFNetworkings framework header.

#import<AFNetworking/AFNetworking.h>

@abbasmousavi

abbasmousavi commented Aug 24, 2016

Copy link
Copy Markdown
Author

@kylef Yes, I have fixed it. Thanks.

kylef
kylef reviewed Dec 11, 2016
View reviewed changes
Comment threadAFJSONRPCClient.podspec Outdated
s.tvos.deployment_target = '9.0'

s.dependency 'AFNetworking', '~> 2.1'
s.dependency 'AFNetworking', '> 2.1'

@kylefkylefDec 11, 2016

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to lock to ~> 3.0 or perhaps a range of > 2.1, < 4.0 if AFNetworking 2 should still be supported. Otherwise any breaking changes in AFNetworking 4.0 would break AFJSONRPCClient.

@abbasmousaviabbasmousaviDec 12, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code only works with AFNetworking 3.0, It is better to lock it to ~> 3.0.
We can create a branch with current code for AFNetworking 2.0 if anyone uses it.
I have changed it in a new commit.
@kylef

@abbasmousavi

abbasmousavi commented Feb 22, 2018•
edited
Loading

Copy link
Copy Markdown
Author

@kylef@handya
Could you please merge this pull request and release a new pod version?

@abbasmousavi

abbasmousavi commented Mar 19, 2018

Copy link
Copy Markdown
Author

@kylef@handya

@dents

dents commented Apr 27, 2018

Copy link
Copy Markdown

Any chance of getting this checked in?

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers
@kylefkylefkylef left review comments
@handyahandyahandya approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@abbasmousavi@dents@kylef@handya