feat: help key + broader keybinding modifier support - #168
Open
Squirreljetpack wants to merge 1 commit into
Open
feat: help key + broader keybinding modifier support#168Squirreljetpack wants to merge 1 commit into
Squirreljetpack wants to merge 1 commit into
Conversation
AMythicDev
commented
Aug 21, 2026
Owner
Do not base your commits on
|
Squirreljetpackforce-pushed
the
feat/help-key-modifier-support
branch
from
August 22, 2026 07:55
709c65d to
986e6f9CompareContributorAuthor
Can't do 1 because I don't have write permissions here, so I chose 2. I think if you use merge instead of squash and merge the subsequent ones will resolve cleanly. btw, if they get there, the final pr has been updated to fix lints. |
AMythicDev
commented
Aug 22, 2026
Owner
Yeah it's fine, #167 is already good. You just needed to rebase the subsequent PRs which you already did as I see. I will review it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds help key display and broader modifier support for keybindings.
Stacked on #167