Skip to content

GCS ACLE - #364

Merged
vhscampos merged 4 commits into
ARM-software:mainfrom
yury-khrustalev:gcs
Jan 15, 2025
Merged

GCS ACLE#364
vhscampos merged 4 commits into
ARM-software:mainfrom
yury-khrustalev:gcs

Conversation

@yury-khrustalev

@yury-khrustalevyury-khrustalev commented Nov 25, 2024•
edited
Loading

Copy link
Copy Markdown
Contributor

This is to continue discussion started in #260.

name: Pull request
about: Technical issues, document format problems, bugs in scripts or feature proposal.

@yury-khrustalevyury-khrustalev mentioned this pull request Nov 25, 2024
Closed
8 tasks
@yury-khrustalev

yury-khrustalev commented Nov 25, 2024

Copy link
Copy Markdown
ContributorAuthor

The only difference compared to #260 is use of non-const type for GCS pointer (an relevant change in wording).

DanielKristofKiss
DanielKristofKiss reviewed Nov 25, 2024
View reviewed changes
Comment threadmain/design_documents/gcs.md Outdated
DanielKristofKiss
DanielKristofKiss approved these changes Nov 25, 2024
View reviewed changes

@DanielKristofKissDanielKristofKiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from me, just a note from me.
let see what others says.

@yury-khrustalev
yury-khrustalevforce-pushed the gcs branch 2 times, most recently from 70ac9c6 to a6e18ddCompareDecember 2, 2024 11:37
@nsz-arm@yury-khrustalev
Add GCS design document
df9b82b
Co-authored-by: Yury Khrustalev <yury.khrustalev@arm.com>
@john-brawn-arm

john-brawn-arm commented Jan 14, 2025

Copy link
Copy Markdown

LGTM

DanielKristofKiss
DanielKristofKiss approved these changes Jan 15, 2025
View reviewed changes

@DanielKristofKissDanielKristofKiss left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vhscampos
vhscampos merged commit 67e0c53 into ARM-software:mainJan 15, 2025
philgee-oss
philgee-oss reviewed Feb 18, 2025
View reviewed changes
Comment threadmain/acle.md
Comment threadmain/acle.md
Comment threadmain/acle.md
Comment threadmain/acle.md
Comment threadmain/acle.md
Comment threadmain/design_documents/gcs.md
Comment threadmain/design_documents/gcs.md
Comment threadmain/design_documents/gcs.md
Comment threadmain/design_documents/gcs.md
Comment threadmain/design_documents/gcs.md
sivan-shani added a commit to sivan-shani/llvm-project that referenced this pull request Apr 23, 2025
@sivan-shani
[AArch64] Update __gcsss intrinsic to match revised ACLE specification
d23df8b
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)
Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the signature accordingly to:
void *__gcsss(void *)
This aligns the implementation with the latest ACLE definition.
@sivan-shanisivan-shani mentioned this pull request Apr 23, 2025
Merged
sivan-shani added a commit to sivan-shani/llvm-project that referenced this pull request Apr 23, 2025
@sivan-shani
[AArch64] Update __gcsss intrinsic to match revised ACLE specification
a3cc71e
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)
Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the signature accordingly to:
void *__gcsss(void *)
This aligns the implementation with the latest ACLE definition.
sivan-shani added a commit to llvm/llvm-project that referenced this pull request Apr 24, 2025
@sivan-shani
[AArch64] Update __gcsss intrinsic to match revised ACLE specification (
be04497
#136850)
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)
Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)
This aligns the implementation with the latest ACLE definition.
llvm-syncBot pushed a commit to arm/arm-toolchain that referenced this pull request May 6, 2025
@sivan-shani@github-actions
Automerge: [AArch64] Update __gcsss intrinsic to match revised ACLE s…
9f27c59
…pecification (#136850)
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)
Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)
This aligns the implementation with the latest ACLE definition.
IanWood1 pushed a commit to IanWood1/llvm-project that referenced this pull request May 6, 2025
@sivan-shani@IanWood1
[AArch64] Update __gcsss intrinsic to match revised ACLE specification (
7a34ba7
llvm#136850)
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)
Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)
This aligns the implementation with the latest ACLE definition.
@vhscampos

vhscampos commented Jun 6, 2025

Copy link
Copy Markdown
Member

@all-contributors please add @yury-khrustalev for code.

@allcontributorsallcontributorsBot mentioned this pull request Jun 6, 2025
Merged
@allcontributors

allcontributorsBot commented Jun 6, 2025

Copy link
Copy Markdown
Contributor

@vhscampos

I've put up a pull request to add @yury-khrustalev! 🎉

vhscampos added a commit that referenced this pull request Jun 6, 2025
@allcontributors@vhscampos
docs: add yury-khrustalev as a contributor for code (#397)
d38f242
Adds @yury-khrustalev as a contributor for code.
This was requested by vhscampos [in this
comment](#364 (comment))
[skip ci]
---------
Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
Co-authored-by: Victor Campos <victor.campos@arm.com>
OpenHarmonySCM-noreply pushed a commit to openharmony/third_party_llvm-project that referenced this pull request Jul 19, 2026
@sivan-shani
[AArch64] Update __gcsss intrinsic to match revised ACLE specificatio…
1216ea2
…n (#136850)
The original __gcsss intrinsic was implemented based on:
ARM-software/acle#260
with the signature: const void *__gcsss(const void *)
Per the updated specification in:
ARM-software/acle#364
both const qualifiers have been removed. This commit updates the
signature accordingly to: void *__gcsss(void *)
This aligns the implementation with the latest ACLE definition.
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vhscamposvhscamposvhscampos left review comments
@DanielKristofKissDanielKristofKissDanielKristofKiss approved these changes
+1 more reviewer
@philgee-ossphilgee-ossphilgee-oss left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

proposal

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@yury-khrustalev@john-brawn-arm@vhscampos@DanielKristofKiss@philgee-oss@nsz-arm