Uh oh!
There was an error while loading. Please reload this page.
Fix linking to self-built deps on Windows + Clang - #2273
Merged
doug-walker merged 1 commit intoApr 1, 2026
Merged
Conversation
|
cozdas
reviewed
Mar 17, 2026
cozdas
left a comment
Collaborator
There was a problem hiding this comment.
Changes look good but the DCO check should pass and need to have the PR built first.
dimula73
commented
Mar 17, 2026
ContributorAuthor
What is DCO? Isn't the author field enough? I always thought it is reviewers, who sign-off commits... |
dimula73
commented
Mar 17, 2026
ContributorAuthor
Anyway, I'll rebase and add the lines a bit later :) |
cozdas
commented
Mar 17, 2026
Collaborator
Thanks. Please check the contribution process doc at https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/CONTRIBUTING.md for the details. |
dimula73force-pushed
the
kazakov/fix-linking-to-self-built-deps-win
branch
from
March 17, 2026 19:23
ded5d08 to
9a4cdfeComparedimula73
commented
Mar 17, 2026
ContributorAuthor
Okay, I think it should be fixed now. |
cozdas
approved these changes
Mar 17, 2026
remia
approved these changes
Mar 28, 2026
1) Expat: 'MD' suffix is added on MSVC only, 'd' suffix is added on WIN32 2) ZLib: 'd' suffix is added only on MSVC Signed-off-by: Dmitry Kazakov <dimula73@gmail.com>
dimula73force-pushed
the
kazakov/fix-linking-to-self-built-deps-win
branch
from
March 28, 2026 15:00
9a4cdfe to
59b6ab0CompareUh oh!
There was an error while loading. Please reload this page.
Merged
doug-walker pushed a commit
that referenced
this pull request
May 13, 2026
1) Expat: 'MD' suffix is added on MSVC only, 'd' suffix is added on WIN32 2) ZLib: 'd' suffix is added only on MSVC Signed-off-by: Dmitry Kazakov <dimula73@gmail.com> (cherry picked from commit 75bb9d0) Signed-off-by: Doug Walker <doug.walker@autodesk.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OCIO fails to build on Windows when llvm-mingw environment is used. It happens because of incorrect conditions are used to mimic the static library names. This patch makes these names generation consistent with the CMakeLists.txt files of the corresponding deps.