Skip to content

Adsk Contrib - Hue curve python binding was not copying all parameters - #2276

Merged
doug-walker merged 4 commits into
AcademySoftwareFoundation:mainfrom
autodesk-forks:walker/hue-issue
Apr 3, 2026
Merged

Adsk Contrib - Hue curve python binding was not copying all parameters#2276
doug-walker merged 4 commits into
AcademySoftwareFoundation:mainfrom
autodesk-forks:walker/hue-issue

Conversation

@doug-walker

Copy link
Copy Markdown
Collaborator

When setting a GradingBSplineCurve on a GradingHueCurve using the Python binding, the spline type and slopes were not being copied correctly. This issue does not affect the C++ interface.

In addition, fixed a minor problem in CTFReaderHelper.cpp that was causing the Platform Latest Action to fail.

Signed-off-by: Doug Walker <doug.walker@autodesk.com>
@doug-walker
doug-walker requested a review from cozdasMarch 19, 2026 21:47
@doug-walkerdoug-walker added the Bug Unwanted or incorrect behavior in currently available functionality. label Mar 19, 2026
Comment threadsrc/OpenColorIO/fileformats/ctf/CTFReaderHelper.cpp Outdated

@cozdascozdas left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested fix to the language attribute handler's pointer check mistake.

Comment threadsrc/OpenColorIO/fileformats/ctf/CTFReaderHelper.cpp Outdated
Comment threadsrc/OpenColorIO/fileformats/ctf/CTFReaderHelper.cpp Outdated
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
@doug-walkerdoug-walker changed the title Hue curve python binding was not copying all parametersAdsk Contrib - Hue curve python binding was not copying all parametersMar 28, 2026
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
@doug-walker
doug-walker merged commit 044f66b into AcademySoftwareFoundation:mainApr 3, 2026
26 checks passed
@doug-walker
doug-walker deleted the walker/hue-issue branch April 3, 2026 19:49
@doug-walkerdoug-walker mentioned this pull request May 6, 2026
doug-walker added a commit that referenced this pull request May 13, 2026
#2276)
* Fix bug in hue curve python binding
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
* Pointer check improvement
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
* Dangling reference fix
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
---------
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
(cherry picked from commit 044f66b)
Signed-off-by: Doug Walker <doug.walker@autodesk.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BugUnwanted or incorrect behavior in currently available functionality.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@doug-walker@remia@zachlewis@cozdas