Skip to content

Crashes when Clip parent is null #2044

Description

@jminor

An LLM-based code review claims that there are some bugs related to orphaned clips (Clip instances with a null parent).

item.cpp:87-109 — range_in_parent/trimmed_range_in_parent on an orphan clip set the error then still call parent()->... on null. Same pattern in transition.cpp:58-90.
composition.cpp:254-273 — _path_from_child walks current->parent() off the end for orphan/foreign children: track->range_of_child(orphan) crashes.

Could we get a volunteer to verify if this is a real bug? It sounds plausible, and could be easily verified by writing a test case and/or a test OTIO file that creates the scenario described.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    devdays26good first issueIf you're looking for a way to contribute, but not sure where to start. This is a good first issue.help wantedWe're looking for help from the community - you're weclome to volunteer!

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions