Skip to content

Draft: Fix 0 fps - #2054

Draft
O-Minor wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
O-Minor:fix-0-fps
Draft

O-Minor wants to merge 3 commits into
AcademySoftwareFoundation:mainfrom
O-Minor:fix-0-fps

Conversation

@O-Minor

@O-Minor O-Minor commented Sep 18, 2026

Copy link
Copy Markdown

The list of valid FPS values had allocated 11 elements but 1 element was not used so it was auto filled with the value 0, allowing 0 fps as a valid value.

Tests: Added tests for value that rounds to 0, 0 itself, and negative value that rounds to zero inside the test that checks for correct rounding, correct value for all of these should be the value a little under 24.

Fix: Changed number of elements of the list from 11 to 10 to get rid of the hidden 0 entry.

Note, I had difficulty compiling so the tests have been verified but not the fix.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.48%. Comparing base (a639246) to head (9681ab0).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2054   +/-   ##
=======================================
  Coverage   83.48%   83.48%           
=======================================
  Files         182      182           
  Lines       13517    13517           
  Branches     1254     1254           
=======================================
  Hits        11284    11284           
  Misses       2060     2060           
  Partials      173      173           
Flag Coverage Δ
py-unittests 83.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/opentime/rationalTime.cpp 84.76% <ø> (ø)
tests/test_opentime.py 99.75% <ø> (ø)

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a639246...9681ab0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants