Draft: Fix 0 fps - #2054
Draft
O-Minor wants to merge 3 commits into
Draft
Draft: Fix 0 fps#2054O-Minor wants to merge 3 commits into
O-Minor wants to merge 3 commits into
Conversation
Signed-off-by: Opal Oliver Minor <42308423+O-Minor@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2054 +/- ##
=======================================
Coverage 83.48% 83.48%
=======================================
Files 182 182
Lines 13517 13517
Branches 1254 1254
=======================================
Hits 11284 11284
Misses 2060 2060
Partials 173 173
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The list of valid FPS values had allocated 11 elements but 1 element was not used so it was auto filled with the value 0, allowing 0 fps as a valid value.
Tests: Added tests for value that rounds to 0, 0 itself, and negative value that rounds to zero inside the test that checks for correct rounding, correct value for all of these should be the value a little under 24.
Fix: Changed number of elements of the list from 11 to 10 to get rid of the hidden 0 entry.
Note, I had difficulty compiling so the tests have been verified but not the fix.