Trip Scheduling Choice -- Same Results Single Process and Multi-Process by dhensle · Pull Request #1005 · ActivitySim/activitysim

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

dhensle · 2025-10-21T17:58:03Z

Fix for #891

This pull request introduces several improvements and refactors to the trip scheduling and departure choice components, settings, and configuration files in the ActivitySim ABM prototype and test suite. The main changes include updating configuration schemas for consistency, refactoring settings classes for better inheritance and maintainability, improving sorting and spec reading logic, and enhancing test coverage and utility functions.

Configuration and Settings Refactoring

Updated the trip scheduling and departure choice configuration files to use SPEC instead of SPECIFICATION, standardized preprocessor settings, and added compute_settings and protect_columns for consistency and clarity. (activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml, activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml, [1][2][3]
Refactored the TripSchedulingChoiceSettings class to inherit from LogitComponentSettings and removed redundant fields, streamlining the settings schema for trip scheduling choice. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL347-R352)

Logic and Code Improvements

Added sorting by tour_id and SCHEDULE_ID in the schedule generation function to ensure deterministic and organized output. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyR85) (This was the actual fix to Reproducible random does not work in trip scheduling choice #891)
Changed the specification file reference from SPECIFICATION to SPEC in the segment spec reading function for consistency with configuration changes. (activitysim/abm/models/trip_scheduling_choice.py, activitysim/abm/models/trip_scheduling_choice.pyL210-R212)

Testing Enhancements

Un-commented and improved the trip departure choice test suite, added utility for canonical directory setup, and updated tests to use the new settings schema and workflow state initialization. (activitysim/abm/test/test_misc/test_trip_departure_choice.py, activitysim/abm/test/test_misc/test_trip_departure_choice.pyL1-R177)

Prototype and Test Configuration Updates

Added new and updated test configuration files for network level-of-service and time period settings, improving test coverage for different scenarios. (activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml, [1]; activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml, [2]
Updated prototype settings to sample households, disable parking location, and enable multiprocessing for more flexible and efficient runs. (activitysim/examples/prototype_arc/configs/settings.yaml, [1][2]

Miscellaneous

Removed unnecessary .gitignore entries in test output directories for cleaner repository management. (activitysim/examples/prototype_arc/test/output/.gitignore, [1]; activitysim/examples/prototype_arc/test/output/cache/.gitignore, [2]; activitysim/examples/prototype_arc/test/output/trace/.gitignore, [3]

single process run with

…ctivitysim into trip_scheduling_rng_fix

Copilot

Pull Request Overview

This PR makes several updates to the trip scheduling and departure choice models and their test configurations:

Migrates TripSchedulingChoiceSettings to inherit from LogitComponentSettings instead of defining fields manually
Updates configuration files to use standardized field names (SPEC instead of SPECIFICATION, preprocessor instead of PREPROCESSOR)
Un-comments and updates trip scheduling and departure choice tests to be functional again
Adds new test configuration files and fixtures
Removes placeholder .gitignore files from output directories
Adds a new simulation script and test configuration for the prototype_arc example

Reviewed Changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
activitysim/examples/prototype_arc/test/simulation.py	Adds a command-line script to run simulations via ActivitySim's CLI
activitysim/examples/prototype_arc/test/output/trace/.gitignore	Removes .gitignore for trace output directory
activitysim/examples/prototype_arc/test/output/cache/.gitignore	Removes .gitignore for cache output directory
activitysim/examples/prototype_arc/test/output/.gitignore	Removes .gitignore for main output directory
activitysim/examples/prototype_arc/configs/trip_scheduling_choice.yaml	Updates to use standard field names and adds compute_settings with protect_columns
activitysim/examples/prototype_arc/configs/settings.yaml	Adds test configuration settings including sample size, model settings check flag, and multiprocessing settings
activitysim/abm/test/test_misc/test_trip_scheduling_choice.py	Un-comments and updates tests with proper imports and fixtures, including state initialization
activitysim/abm/test/test_misc/test_trip_departure_choice.py	Un-comments and updates tests with state initialization and model settings loading
activitysim/abm/test/test_misc/configs_test_misc/trip_scheduling_choice.yaml	Adds test configuration file with standardized field names
activitysim/abm/test/test_misc/configs_test_misc/trip_departure_choice.yaml	Adds test configuration file using legacy field names
activitysim/abm/test/test_misc/configs_test_misc/settings_60_min.yaml	Adds skim settings configuration for 60-minute time periods
activitysim/abm/test/test_misc/configs_test_misc/network_los.yaml	Adds network level-of-service configuration
activitysim/abm/models/trip_scheduling_choice.py	Refactors TripSchedulingChoiceSettings to inherit from LogitComponentSettings, adds line to sort schedule alternatives

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-10-30T16:14:12Z

+ A pytest fixture that returns the data folder location.
+ :return: folder location for any necessary data to initialize the tests


The docstring incorrectly states that this fixture 'returns the data folder location', but it actually returns the module name string 'summarize'. The docstring should be updated to accurately describe what the fixture returns and its purpose.
Suggested change
Apytestfixturethatreturnsthedatafolderlocation.
:return: folderlocationforanynecessarydatatoinitializethetests
Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
:return: modulenamestring ("summarize")

jpn--

Some changes...

* improved testing * blacken * stable sorting * blacken

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

juangacostaand others added 11 commits October 13, 2025 12:41

single process run with
41e9a04

Merge pull request#9from juangacosta/trip_scheduling_rng_fix
39de183
single process run with

ensured schedule order when generating alternatives
5024ccb

Merge branch 'trip_scheduling_rng_fix' ofhttps://github.com/RSGInc/a…
437aa76
…ctivitysim into trip_scheduling_rng_fix

trip scheduling choice test fix
41edca3

scheduling choice fix with linting
c6b65f8

trip departture choice test fix
75c4024

deleted extra outputs folder
141f876

restoring deleted arc test files
22d662f

deleting extra added files
3246168

more file cleanup
84ac97b

jpn-- mentioned this pull request Oct 23, 2025
2025-10-23 Engineering Team ActivitySim/meeting-notes#37
Closed

removing arc from CI test list
f07ec1d

dhensle marked this pull request as ready for review October 30, 2025 03:32

jpn-- requested review from Copilot and jpn--October 30, 2025 16:11

jpn-- mentioned this pull request Oct 30, 2025
2025-10-30 Engineering Team ActivitySim/meeting-notes#40
Closed

CopilotAI reviewed Oct 30, 2025
View reviewed changes

jpn-- requested changes Nov 1, 2025
View reviewed changes

jpn--and others added 3 commits November 12, 2025 13:05

improved testing (#10)
8f52e7c
* improved testing * blacken * stable sorting * blacken

addressing review comments
4cef631

Merge branch 'main' into trip_scheduling_rng_fix
4124ea6

jpn-- approved these changes Dec 2, 2025
View reviewed changes

jpn-- merged commit 3b59725 into ActivitySim:mainDec 2, 2025
19 checks passed

jpn-- deleted the trip_scheduling_rng_fix branch December 2, 2025 23:22

jpn-- added this to Phase 11 Dec 4, 2025

github-project-automationBot moved this to Done in Phase 11 Dec 4, 2025

jpn-- moved this from Done to Under Review in Phase 11 Dec 4, 2025

jpn-- moved this from Under Review to Done in Phase 11 Dec 4, 2025

janzill mentioned this pull request Apr 11, 2026
Explicit error terms production code #1064
Merged

		A pytest fixture that returns the data folder location.
		:return: folder location for any necessary data to initialize the tests

-Apytestfixturethatreturnsthedatafolderlocation.
- :return: folderlocationforanynecessarydatatoinitializethetests
+Apytestfixturethatreturnsthemodulenamestringusedinthetestsetup.
+ :return: modulenamestring ("summarize")

Uh oh!

Conversation

dhensle commented Oct 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

CopilotAIOct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jpn-- left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dhensle commented Oct 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

CopilotAIOct 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jpn-- left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Conversation

dhensle commented Oct 21, 2025• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

dhensle commented Oct 21, 2025•
edited
Loading

dhensle commented Oct 21, 2025•
edited
Loading

dhensle commented Oct 21, 2025•
edited
Loading

dhensle commented Oct 21, 2025•
edited
Loading