Repair CDAP estimation

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.

[jpn--]

This pull request fixes an error in Larch estimation of the CDAP model, reported in #595. There was a bug in the code, where interaction terms for 3, 4, and 5 person households adopting an all-M, all-N, or all-H patterns were all mapped to the same coefficient; the original model structure has unique parameters for each household size. [1][2]

Testing and validation

• Expanded the test_cdap_model test to include assertions verifying the correct assignment of interaction parameters, specifically checking the presence and absence of wildcard coefficients for different model sizes.
• Updated the regression test data in test_cdap_model_loglike.csv to reflect changes in log-likelihood values resulting from the repaired coefficient mapping logic.

[dhensle]

Fix looks good. Suggest we add more detail to the change log, and one minor typo to fix.

[dhensle]

Happy to see the additional coef_xxx and coef_xxxx coefficients. All these coefficients across M,N, and H make a lot more sense now with a strong negative coefficient for everyone in a 5-person household doing the same thing.