Config Settings and Documentation - #758

Merged
jpn-- merged 459 commits into
ActivitySim:developfrom
camsys:cfg-documentation-vy
Feb 1, 2024
Merged

Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom
camsys:cfg-documentation-vy

Conversation

@jpn--

@jpn--jpn-- commented Nov 2, 2023•
edited
Loading

Copy link
Copy Markdown
Member

This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646

Settings migration progress:

  • Initialize LOS
  • Initialize Tours
  • Accessibility
  • Disaggregate Accessibility
  • Work from Home
  • School Location
  • Work Location
  • Shadow Pricing
  • Transit Pass Subsidy
  • Transit Pass Ownership
  • Auto Ownership
  • Vehicle Type Choice
  • Telecommute Frequency
  • Free Parking Eligibility
  • Coordinated Daily Activity Pattern
  • Mandatory Tour Frequency
  • Mandatory Tour Scheduling
  • School Escorting
  • Joint Tour Composition
  • Joint Tour Participation
  • Joint Tour Destination
  • Joint Tour Scheduling
  • Joint Tour Frequency Composition
  • Non-Mandatory Tour Frequency
  • Non-Mandatory Tour Destination Choice
  • Non-Mandatory Tour Scheduling
  • Vehicle Allocation
  • Tour Mode Choice
  • At-work Subtours Frequency
  • At-work Subtour Destination
  • At-work Subtour Mode Choice
  • At-work Subtour Scheduling
  • Intermediate Stop Frequency
  • Trip Purpose
  • Trip Destination Choice
  • Trip Purpose and Destination
  • Trip Scheduling (Probabilistic)
  • Trip Scheduling Choice (Logit Choice)
  • Trip Departure Choice (Logit Choice)
  • Trip Mode Choice
  • Parking Location Choice
  • Write Trip Matrices
  • summarize
  • tour_od_choice
  • Tour Scheduling Probalistic

jpn-- added 30 commits May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia requested changes Jan 3, 2024
View reviewed changes

@i-am-sijiai-am-sijia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes

Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py Outdated
Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia reviewed Jan 4, 2024
View reviewed changes

@i-am-sijiai-am-sijia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.

Comment threadactivitysim/core/configuration/base.py
@jpn--jpn-- added the Usability Changes that improve usability label Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn-- merged commit 25e4f6c into ActivitySim:developFeb 1, 2024
@jpn--jpn-- mentioned this pull request Feb 14, 2024
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
Config Settings and Documentation - #758
Merged
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Feb 1, 2024
Merged
Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Conversation
@jpn--
@jpn--jpn--
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress:
  •  Initialize LOS
  •  Initialize Tours
  •  Accessibility
  •  Disaggregate Accessibility
  •  Work from Home
  •  School Location
  •  Work Location
  •  Shadow Pricing
  •  Transit Pass Subsidy
  •  Transit Pass Ownership
  •  Auto Ownership
  •  Vehicle Type Choice
  •  Telecommute Frequency
  •  Free Parking Eligibility
  •  Coordinated Daily Activity Pattern
  •  Mandatory Tour Frequency
  •  Mandatory Tour Scheduling
  •  School Escorting
  •  Joint Tour Composition
  •  Joint Tour Participation
  •  Joint Tour Destination
  •  Joint Tour Scheduling
  •  Joint Tour Frequency Composition
  •  Non-Mandatory Tour Frequency
  •  Non-Mandatory Tour Destination Choice
  •  Non-Mandatory Tour Scheduling
  •  Vehicle Allocation
  •  Tour Mode Choice
  •  At-work Subtours Frequency
  •  At-work Subtour Destination
  •  At-work Subtour Mode Choice
  •  At-work Subtour Scheduling
  •  Intermediate Stop Frequency
  •  Trip Purpose
  •  Trip Destination Choice
  •  Trip Purpose and Destination
  •  Trip Scheduling (Probabilistic)
  •  Trip Scheduling Choice (Logit Choice)
  •  Trip Departure Choice (Logit Choice)
  •  Trip Mode Choice
  •  Parking Location Choice
  •  Write Trip Matrices
  •  summarize
  •  tour_od_choice
  •  Tour Scheduling Probalistic
jpn--
added 30 commits
May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia
requested changes
Jan 3, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes
Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py
Outdated

Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia
reviewed
Jan 4, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
Comment threadactivitysim/core/configuration/base.py
@jpn--jpn--
added
the 
Usability
Changes that improve usability
label
Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn--
merged commit 25e4f6c
into
ActivitySim:developFeb 1, 2024
@jpn--jpn--
mentioned this pull request
Feb 14, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Config Settings and Documentation - #758
Merged
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Feb 1, 2024
Merged
Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Conversation
@jpn--
@jpn--jpn--
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress:
  •  Initialize LOS
  •  Initialize Tours
  •  Accessibility
  •  Disaggregate Accessibility
  •  Work from Home
  •  School Location
  •  Work Location
  •  Shadow Pricing
  •  Transit Pass Subsidy
  •  Transit Pass Ownership
  •  Auto Ownership
  •  Vehicle Type Choice
  •  Telecommute Frequency
  •  Free Parking Eligibility
  •  Coordinated Daily Activity Pattern
  •  Mandatory Tour Frequency
  •  Mandatory Tour Scheduling
  •  School Escorting
  •  Joint Tour Composition
  •  Joint Tour Participation
  •  Joint Tour Destination
  •  Joint Tour Scheduling
  •  Joint Tour Frequency Composition
  •  Non-Mandatory Tour Frequency
  •  Non-Mandatory Tour Destination Choice
  •  Non-Mandatory Tour Scheduling
  •  Vehicle Allocation
  •  Tour Mode Choice
  •  At-work Subtours Frequency
  •  At-work Subtour Destination
  •  At-work Subtour Mode Choice
  •  At-work Subtour Scheduling
  •  Intermediate Stop Frequency
  •  Trip Purpose
  •  Trip Destination Choice
  •  Trip Purpose and Destination
  •  Trip Scheduling (Probabilistic)
  •  Trip Scheduling Choice (Logit Choice)
  •  Trip Departure Choice (Logit Choice)
  •  Trip Mode Choice
  •  Parking Location Choice
  •  Write Trip Matrices
  •  summarize
  •  tour_od_choice
  •  Tour Scheduling Probalistic
jpn--
added 30 commits
May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia
requested changes
Jan 3, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes
Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py
Outdated

Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia
reviewed
Jan 4, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
Comment threadactivitysim/core/configuration/base.py
@jpn--jpn--
added
the 
Usability
Changes that improve usability
label
Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn--
merged commit 25e4f6c
into
ActivitySim:developFeb 1, 2024
@jpn--jpn--
mentioned this pull request
Feb 14, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Config Settings and Documentation - #758
Merged
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Feb 1, 2024
Merged
Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Conversation
@jpn--
@jpn--jpn--
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress:
  •  Initialize LOS
  •  Initialize Tours
  •  Accessibility
  •  Disaggregate Accessibility
  •  Work from Home
  •  School Location
  •  Work Location
  •  Shadow Pricing
  •  Transit Pass Subsidy
  •  Transit Pass Ownership
  •  Auto Ownership
  •  Vehicle Type Choice
  •  Telecommute Frequency
  •  Free Parking Eligibility
  •  Coordinated Daily Activity Pattern
  •  Mandatory Tour Frequency
  •  Mandatory Tour Scheduling
  •  School Escorting
  •  Joint Tour Composition
  •  Joint Tour Participation
  •  Joint Tour Destination
  •  Joint Tour Scheduling
  •  Joint Tour Frequency Composition
  •  Non-Mandatory Tour Frequency
  •  Non-Mandatory Tour Destination Choice
  •  Non-Mandatory Tour Scheduling
  •  Vehicle Allocation
  •  Tour Mode Choice
  •  At-work Subtours Frequency
  •  At-work Subtour Destination
  •  At-work Subtour Mode Choice
  •  At-work Subtour Scheduling
  •  Intermediate Stop Frequency
  •  Trip Purpose
  •  Trip Destination Choice
  •  Trip Purpose and Destination
  •  Trip Scheduling (Probabilistic)
  •  Trip Scheduling Choice (Logit Choice)
  •  Trip Departure Choice (Logit Choice)
  •  Trip Mode Choice
  •  Parking Location Choice
  •  Write Trip Matrices
  •  summarize
  •  tour_od_choice
  •  Tour Scheduling Probalistic
jpn--
added 30 commits
May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia
requested changes
Jan 3, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes
Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py
Outdated

Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia
reviewed
Jan 4, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
Comment threadactivitysim/core/configuration/base.py
@jpn--jpn--
added
the 
Usability
Changes that improve usability
label
Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn--
merged commit 25e4f6c
into
ActivitySim:developFeb 1, 2024
@jpn--jpn--
mentioned this pull request
Feb 14, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
Config Settings and Documentation - #758
Merged
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Feb 1, 2024
Merged
Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Conversation
@jpn--
@jpn--jpn--
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress:
  •  Initialize LOS
  •  Initialize Tours
  •  Accessibility
  •  Disaggregate Accessibility
  •  Work from Home
  •  School Location
  •  Work Location
  •  Shadow Pricing
  •  Transit Pass Subsidy
  •  Transit Pass Ownership
  •  Auto Ownership
  •  Vehicle Type Choice
  •  Telecommute Frequency
  •  Free Parking Eligibility
  •  Coordinated Daily Activity Pattern
  •  Mandatory Tour Frequency
  •  Mandatory Tour Scheduling
  •  School Escorting
  •  Joint Tour Composition
  •  Joint Tour Participation
  •  Joint Tour Destination
  •  Joint Tour Scheduling
  •  Joint Tour Frequency Composition
  •  Non-Mandatory Tour Frequency
  •  Non-Mandatory Tour Destination Choice
  •  Non-Mandatory Tour Scheduling
  •  Vehicle Allocation
  •  Tour Mode Choice
  •  At-work Subtours Frequency
  •  At-work Subtour Destination
  •  At-work Subtour Mode Choice
  •  At-work Subtour Scheduling
  •  Intermediate Stop Frequency
  •  Trip Purpose
  •  Trip Destination Choice
  •  Trip Purpose and Destination
  •  Trip Scheduling (Probabilistic)
  •  Trip Scheduling Choice (Logit Choice)
  •  Trip Departure Choice (Logit Choice)
  •  Trip Mode Choice
  •  Parking Location Choice
  •  Write Trip Matrices
  •  summarize
  •  tour_od_choice
  •  Tour Scheduling Probalistic
jpn--
added 30 commits
May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia
requested changes
Jan 3, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes
Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py
Outdated

Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia
reviewed
Jan 4, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
Comment threadactivitysim/core/configuration/base.py
@jpn--jpn--
added
the 
Usability
Changes that improve usability
label
Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn--
merged commit 25e4f6c
into
ActivitySim:developFeb 1, 2024
@jpn--jpn--
mentioned this pull request
Feb 14, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Config Settings and Documentation - #758
Merged
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Feb 1, 2024
Merged
Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Conversation
@jpn--
@jpn--jpn--
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress:
  •  Initialize LOS
  •  Initialize Tours
  •  Accessibility
  •  Disaggregate Accessibility
  •  Work from Home
  •  School Location
  •  Work Location
  •  Shadow Pricing
  •  Transit Pass Subsidy
  •  Transit Pass Ownership
  •  Auto Ownership
  •  Vehicle Type Choice
  •  Telecommute Frequency
  •  Free Parking Eligibility
  •  Coordinated Daily Activity Pattern
  •  Mandatory Tour Frequency
  •  Mandatory Tour Scheduling
  •  School Escorting
  •  Joint Tour Composition
  •  Joint Tour Participation
  •  Joint Tour Destination
  •  Joint Tour Scheduling
  •  Joint Tour Frequency Composition
  •  Non-Mandatory Tour Frequency
  •  Non-Mandatory Tour Destination Choice
  •  Non-Mandatory Tour Scheduling
  •  Vehicle Allocation
  •  Tour Mode Choice
  •  At-work Subtours Frequency
  •  At-work Subtour Destination
  •  At-work Subtour Mode Choice
  •  At-work Subtour Scheduling
  •  Intermediate Stop Frequency
  •  Trip Purpose
  •  Trip Destination Choice
  •  Trip Purpose and Destination
  •  Trip Scheduling (Probabilistic)
  •  Trip Scheduling Choice (Logit Choice)
  •  Trip Departure Choice (Logit Choice)
  •  Trip Mode Choice
  •  Parking Location Choice
  •  Write Trip Matrices
  •  summarize
  •  tour_od_choice
  •  Tour Scheduling Probalistic
jpn--
added 30 commits
May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia
requested changes
Jan 3, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes
Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py
Outdated

Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia
reviewed
Jan 4, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
Comment threadactivitysim/core/configuration/base.py
@jpn--jpn--
added
the 
Usability
Changes that improve usability
label
Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn--
merged commit 25e4f6c
into
ActivitySim:developFeb 1, 2024
@jpn--jpn--
mentioned this pull request
Feb 14, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
Config Settings and Documentation - #758
Merged
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Feb 1, 2024
Merged
Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Conversation
@jpn--
@jpn--jpn--
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress:
  •  Initialize LOS
  •  Initialize Tours
  •  Accessibility
  •  Disaggregate Accessibility
  •  Work from Home
  •  School Location
  •  Work Location
  •  Shadow Pricing
  •  Transit Pass Subsidy
  •  Transit Pass Ownership
  •  Auto Ownership
  •  Vehicle Type Choice
  •  Telecommute Frequency
  •  Free Parking Eligibility
  •  Coordinated Daily Activity Pattern
  •  Mandatory Tour Frequency
  •  Mandatory Tour Scheduling
  •  School Escorting
  •  Joint Tour Composition
  •  Joint Tour Participation
  •  Joint Tour Destination
  •  Joint Tour Scheduling
  •  Joint Tour Frequency Composition
  •  Non-Mandatory Tour Frequency
  •  Non-Mandatory Tour Destination Choice
  •  Non-Mandatory Tour Scheduling
  •  Vehicle Allocation
  •  Tour Mode Choice
  •  At-work Subtours Frequency
  •  At-work Subtour Destination
  •  At-work Subtour Mode Choice
  •  At-work Subtour Scheduling
  •  Intermediate Stop Frequency
  •  Trip Purpose
  •  Trip Destination Choice
  •  Trip Purpose and Destination
  •  Trip Scheduling (Probabilistic)
  •  Trip Scheduling Choice (Logit Choice)
  •  Trip Departure Choice (Logit Choice)
  •  Trip Mode Choice
  •  Parking Location Choice
  •  Write Trip Matrices
  •  summarize
  •  tour_od_choice
  •  Tour Scheduling Probalistic
jpn--
added 30 commits
May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia
requested changes
Jan 3, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes
Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py
Outdated

Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia
reviewed
Jan 4, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
Comment threadactivitysim/core/configuration/base.py
@jpn--jpn--
added
the 
Usability
Changes that improve usability
label
Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn--
merged commit 25e4f6c
into
ActivitySim:developFeb 1, 2024
@jpn--jpn--
mentioned this pull request
Feb 14, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
Config Settings and Documentation - #758
Merged
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Feb 1, 2024
Merged
Config Settings and Documentation#758
jpn-- merged 459 commits into
ActivitySim:developfrom 
camsys:cfg-documentation-vy
Conversation
@jpn--
@jpn--jpn--
commented
Nov 2, 2023•

edited

Loading

Copy link


Copy Markdown

Member
This PR migrates configuration settings from the existing free-form YAML format to Pydantic format, as per #646
Settings migration progress:
  •  Initialize LOS
  •  Initialize Tours
  •  Accessibility
  •  Disaggregate Accessibility
  •  Work from Home
  •  School Location
  •  Work Location
  •  Shadow Pricing
  •  Transit Pass Subsidy
  •  Transit Pass Ownership
  •  Auto Ownership
  •  Vehicle Type Choice
  •  Telecommute Frequency
  •  Free Parking Eligibility
  •  Coordinated Daily Activity Pattern
  •  Mandatory Tour Frequency
  •  Mandatory Tour Scheduling
  •  School Escorting
  •  Joint Tour Composition
  •  Joint Tour Participation
  •  Joint Tour Destination
  •  Joint Tour Scheduling
  •  Joint Tour Frequency Composition
  •  Non-Mandatory Tour Frequency
  •  Non-Mandatory Tour Destination Choice
  •  Non-Mandatory Tour Scheduling
  •  Vehicle Allocation
  •  Tour Mode Choice
  •  At-work Subtours Frequency
  •  At-work Subtour Destination
  •  At-work Subtour Mode Choice
  •  At-work Subtour Scheduling
  •  Intermediate Stop Frequency
  •  Trip Purpose
  •  Trip Destination Choice
  •  Trip Purpose and Destination
  •  Trip Scheduling (Probabilistic)
  •  Trip Scheduling Choice (Logit Choice)
  •  Trip Departure Choice (Logit Choice)
  •  Trip Mode Choice
  •  Parking Location Choice
  •  Write Trip Matrices
  •  summarize
  •  tour_od_choice
  •  Tour Scheduling Probalistic
jpn--
added 30 commits
May 5, 2023 16:23
@jpn--
yaml.dump paths to strings
1681445
@jpn--
logit configs in separate file [makedocs]
aa1b058
@jpn--
configs for trip dest
9b78306
@jpn--
cleanup
69b93c8
@jpn--
deprecate DESTINATION_SAMPLE_SPEC and DESTINATION_SPEC
a918c9c
@jpn--
cfg for mandatory locations
18ec447
@jpn--
shadow pricing cfg
a349d93
@jpn--
COEFFS file is optional
609086b
@jpn--
common tour location component settings
0f9cb3b
@jpn--
pop include_settings
d382bb5
@jpn--
fix SHADOW_PRICE_METHOD
95c01ab
@jpn--
fix bugs
cc452cc
@jpn--
repair
3fa10a6
@jpn--
TourODSettings
45e057b
@jpn--
robust write_spec
6fad550
@jpn--
accessibility config
4037af5
@jpn--
tour mode
ef4346a
@jpn--
prefer float to str
ee71901
@jpn--
clean up
9806b3b
@jpn--
overflow protection in utils_to_probs
7f4eb0b
@jpn--
only enable overflow_protect when not allow_zero_probs
c40632a
@jpn--
logsums w probs
532e9e9
@jpn--
tweaks in regression test due to overflow protection
c6b15c7
@jpn--
Merge branch 'develop' into overflow-protection
dad22d0
@jpn--
Merge branch 'overflow-protection' into cfg-TourMode
52b8b79
@jpn--
test logging
3a3088d
@jpn--
annotate rng
f1e894d
@jpn--
Merge branch 'upstream-develop' into generic-whale
b483556
@jpn--
update semcog model
325eb3d
@jpn--
docs for logging
939f323
i-am-sijia
i-am-sijia
requested changes
Jan 3, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of my initial comments. Still need to go through the implementation changes
Comment threadactivitysim/core/configuration/base.py
Comment threadactivitysim/core/configuration/filesystem.py
Outdated

Comment threadactivitysim/abm/models/joint_tour_frequency.py
Comment threadactivitysim/abm/models/location_choice.py
Comment threadactivitysim/workflows/steps/contrast/load_tables.py
i-am-sijia
i-am-sijia
reviewed
Jan 4, 2024
View reviewed changes
@i-am-sijiai-am-sijia
left a comment


Copy link


Copy Markdown

Member
Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue that this PR can be linked to? Perhaps this one #646? The technical changes make sense to me, but I think it could be more beneficial to users if there is a bit documentation on the background.
Comment threadactivitysim/core/configuration/base.py
@jpn--jpn--
added
the 
Usability
Changes that improve usability
label
Jan 29, 2024
@jpn--
Merge branch 'develop' into cfg-documentation-vy
b24874a
# Conflicts:
#	activitysim/abm/models/util/tour_frequency.py
#	activitysim/examples/production_semcog/configs/logging.yaml
#	conda-environments/activitysim-dev-base.yml
#	conda-environments/activitysim-dev.yml
#	conda-environments/docbuild.yml
#	docs/models.rst
@jpn--
jpn--
merged commit 25e4f6c
into
ActivitySim:developFeb 1, 2024
@jpn--jpn--
mentioned this pull request
Feb 14, 2024
 Merged

Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment

Reviewers

@i-am-sijiai-am-sijiai-am-sijia approved these changes

Assignees

@i-am-sijiai-am-sijia

Labels

UsabilityChanges that improve usability

Projects

Phase 9 Work

Status: Done


Milestone


No milestone


Development

Successfully merging this pull request may close these issues.

5 participants

@jpn--@i-am-sijia@dhensle@vivekyadav26@navsarmajs