Vehicle Type Alts Filtering Bug Fix

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.

[dhensle]

PR for #789

[jpn--]

When we fix a bug, we need to have a test that proves it's fixed (and so it stays fixed).

[i-am-sijia]

Need to update documentation:

Ok, let's add REQUIRE_DATA_FOR_ALL_ALTS to the model documentation, and update the following blurb to remove "must be included in the file" -

activitysim/docs/models.rst

Lines 448 to 451 in a8e755f

	* ``VEHICLE_TYPE_DATA_FILE``: Filename for input vehicle type data. Must have columns ``body_type``, ``fuel_type``, and ``vehicle_year``.
	Vehicle ``age`` is computed using the ``FLEET_YEAR`` option. Data for every alternative specified in the ``combinatorial_alts`` option must be included
	in the file. Vehicle type data file will be joined to the alternatives and can be used in the utility expressions if ``PROBS_SPEC`` is not provided.
	If ``PROBS_SPEC`` is provided, the vehicle type data will be joined after a vehicle type is decided so the data can be used in downstream models.

[jpn--]

I opened a PR #796 to bring ActivitySim's config settings up-to-date with Pydantic 2.0, which should address your most recent test failure (at least in part).

[dhensle]

Thanks! The test was passing locally, so I expect the update should fix the test completely.