ci: scope test workflows to the domains a change actually touches by willwashburn · Pull Request #1271 · AgentWorkforce/relay

willwashburn · 2026-07-15T19:33:45Z

Summary

CI currently runs the full Rust suite (cargo test debug+release, clippy, cross-compile on Ubuntu + macOS) on TS-only PRs, and runs everything on docs-only PRs. The only existing filter was a copy-pasted "skip if swift-only" job in four workflows. This PR replaces that with a shared reusable workflow, .github/workflows/detect-changes.yml, that classifies changed files into rust / node / swift / inert domains, and gates each workflow's jobs on the domain it actually depends on:

rust-ci.yml — cargo test/clippy/fmt/cross-compile skip on TS-only, docs-only, and swift-only changes; the sdk-check TypeScript job gates on node changes instead of rust.
test.yml, node-compat.yml, package-validation.yml — node jobs now also skip docs-only changes (previously only swift-only). Rust changes still run the TS suite deliberately: npm test's pretest hook runs build:rust, so the TS tests exercise a broker built from the PR's Rust sources.
security.yml — npm-audit, CodeQL (javascript-typescript), and license-check gate on node changes; secret scanning still runs on every PR since any file can leak a secret.
Swift-only changes now run only swift build && swift test.

Detection fails open: on API errors, truncated file lists (compareCommits' 300-file cap), or unexpected events, all domains report changed and everything runs — a skip is never the result of an error. Jobs skipped via if: report "skipped", which satisfies required status checks (same mechanism as the existing swift-only gate).

Also fixes three under-triggering gaps in the opposite direction:

e2e-tests.yml builds the broker (npm run build → build:rust) but never triggered on crates/** changes.
fleet-e2e.yml and build-broker-binary.yml watched crates/broker/** but not crates/relay-pty/** (a workspace crate the broker depends on) or Cargo.lock — a relay-pty change on main could ship a stale prebuilt binary.

Note: the change-scope check now reports as "changes / Detect change scope" (reusable workflow naming). If branch protection required the old "Detect change scope" name, that entry needs updating; all test/lint job names are unchanged.

Test Plan

Classification logic unit-tested locally against 12 change-set scenarios (swift-only, ts-only, rust-only, relay-pty-only, docs-only, nested markdown, CI-config, mixed, root config, empty/fail-open)
All 9 modified workflows pass YAML parsing and prettier --check
Observe the changes job output on this PR (workflow-file changes classify as all-domains, so every suite should run here)

Screenshots

N/A

🤖 Generated with Claude Code

https://claude.ai/code/session_018xpYY8uoeGnxT3Fpt6XcNs

Generated by Claude Code

Replace the four copy-pasted 'sdk_swift_only' change-detection jobs with a shared reusable workflow (detect-changes.yml) that classifies changed files into rust / node / swift / inert domains and fails open (runs everything) when the scope is unknown. - rust-ci: cargo test/clippy/fmt/cross-compile now skip on TS-only, docs-only, and swift-only changes; the sdk-check TS job gates on node changes instead. - test, node-compat, package-validation: node jobs also skip docs-only changes (previously only swift-only). Rust changes still run the TS suite because pretest builds the broker from source. - security: npm-audit, CodeQL (js-ts), and license-check gate on node changes; secret scanning still runs on every PR. - e2e-tests now triggers on crates/** (the e2e script builds the broker); fleet-e2e and build-broker-binary now trigger on crates/relay-pty/** and Cargo.lock, which the broker binary depends on. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xpYY8uoeGnxT3Fpt6XcNs

gemini-code-assist · 2026-07-15T19:33:49Z

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

coderabbitai · 2026-07-15T19:33:54Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0f2de6c-81a6-41a9-a442-d56b98ae03c0

📥 Commits

Reviewing files that changed from the base of the PR and between f2abd67 and 3ef1443.

📒 Files selected for processing (1)

.github/workflows/detect-changes.yml

🚧 Files skipped from review as they are similar to previous changes (1)

.github/workflows/detect-changes.yml

📝 Walkthrough

Walkthrough

CI workflows now share reusable changed-file classification, expose Rust/Node/Swift scope outputs, gate jobs accordingly, broaden Rust-related triggers, and build the root Swift manifest before Swift tests.

Changes

CI scope detection and gating

Layer / File(s)	Summary
Reusable change-scope detection `.github/workflows/detect-changes.yml`	Adds paginated pull-request and push change detection, path classification, fail-open handling, and `rust_changed`, `node_changed`, and `sdk_swift_changed` outputs.
CI job gating integration `.github/workflows/node-compat.yml`, `.github/workflows/package-validation.yml`, `.github/workflows/rust-ci.yml`, `.github/workflows/security.yml`, `.github/workflows/test.yml`	Replaces inline detection with the reusable workflow and gates Node, Rust, package, security, test, coverage, and lint jobs using scope outputs.
Trigger expansion and Swift manifest validation `.github/workflows/build-broker-binary.yml`, `.github/workflows/e2e-tests.yml`, `.github/workflows/fleet-e2e.yml`, `.github/workflows/test.yml`	Adds Rust and Cargo path triggers and builds the repository root Swift manifest before Swift tests.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Suggested reviewers:khaliqgant

Sequence Diagram(s)

sequenceDiagram
participant GitHub
participant DetectChanges
participant CIJobs
GitHub->>DetectChanges: Invoke reusable workflow
DetectChanges->>DetectChanges: Fetch and classify changed files
DetectChanges-->>CIJobs: Return rust_changed and node_changed
CIJobs->>CIJobs: Run matching jobs

Poem

A rabbit hops through workflows bright,
Sorting changed paths left and right.
Rust runs here, Node runs there,
Swift builds roots with careful care.
CI now knows which tests to bear.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the CI workflow scoping changes and matches the PR's main goal.
Description check	✅ Passed	The description follows the template with Summary, Test Plan, and Screenshots, and the key details are filled in.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch claude/ci-test-filtering-yumxsn

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit:0e323d0e75

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

cubic-dev-ai

All reported issues were addressed across 9 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

…wift build - Fail open when the paginated pulls.listFiles result hits GitHub's 3000-file cap, matching the push-path compareCommits handling. - Classify the tracked .agents/ skills directory as inert (nothing in CI consumes it; the skills installer only writes such paths in target projects). - Build the root Package.swift in the Swift SDK job: git-URL consumers resolve the root manifest, which no job validated before. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xpYY8uoeGnxT3Fpt6XcNs

coderabbitai

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/detect-changes.yml:
- Around line 16-18: Add explicit read-only permissions to the reusable
workflow’s top-level on.workflow_call configuration: grant contents read for
compareCommits and pull-requests read for listFiles, ensuring the workflow token
does not inherit broader caller permissions.
- Around line 53-67: Update the changed-file collection in both the `listFiles`
and `compareCommits` branches to include each record’s `previous_filename`
alongside `filename`, so renamed files classify both old and new paths. Keep
`unknownScope` cap checks based on the number of API records, not the expanded
path list length.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

Push a commit to this branch (recommended)
Create a new PR with the fixes

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 1f26f15c-4136-4505-83d5-7ec9370c0aa9

📥 Commits

Reviewing files that changed from the base of the PR and between 765e425 and f2abd67.

📒 Files selected for processing (9)

.github/workflows/build-broker-binary.yml
.github/workflows/detect-changes.yml
.github/workflows/e2e-tests.yml
.github/workflows/fleet-e2e.yml
.github/workflows/node-compat.yml
.github/workflows/package-validation.yml
.github/workflows/rust-ci.yml
.github/workflows/security.yml
.github/workflows/test.yml

Include previous_filename when collecting changed paths so a rename out of a domain (e.g. crates/foo.rs -> docs/foo.md) still triggers that domain's jobs; keep truncation-cap checks on the raw API record count. Declare explicit read-only permissions on the reusable workflow instead of inheriting the caller's defaults. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xpYY8uoeGnxT3Fpt6XcNs

cubic-dev-ai

All reported issues were addressed across 9 files

_{Reply with feedback, questions, or to request a fix.

Re-trigger cubic}

tests/mcp_merge_e2e.rs lives outside crates/, so a change to it skipped the Rust suite; match .rs files anywhere plus .cargo/ and rust-toolchain files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xpYY8uoeGnxT3Fpt6XcNs

cubic-dev-ai

All reported issues were addressed across 1 file (changes from recent commits).

_{Tip: Review your code locally with the cubic CLI to iterate faster.

Re-trigger cubic}

A .rs code example under docs/ or specs/ matched the new suffix rule and ran the full Rust CI; exclude inert paths from the Rust predicate. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_018xpYY8uoeGnxT3Fpt6XcNs

willwashburn requested a review from khaliqgant as a code owner July 15, 2026 19:33

chatgpt-codex-connectorBot reviewed Jul 15, 2026
View reviewed changes

Comment thread.github/workflows/detect-changes.yml Outdated

cubic-dev-aiBot reviewed Jul 15, 2026
View reviewed changes

Comment thread.github/workflows/detect-changes.yml Outdated
Comment thread.github/workflows/test.yml
Comment thread.github/workflows/detect-changes.yml

coderabbitaiBot reviewed Jul 15, 2026
View reviewed changes

Comment thread.github/workflows/detect-changes.yml
Comment thread.github/workflows/detect-changes.yml Outdated

cubic-dev-aiBot reviewed Jul 15, 2026
View reviewed changes

Comment thread.github/workflows/detect-changes.yml

cubic-dev-aiBot reviewed Jul 15, 2026
View reviewed changes

Comment thread.github/workflows/detect-changes.yml

willwashburn merged commit 1653c31 into mainJul 16, 2026
7 checks passed

willwashburn deleted the claude/ci-test-filtering-yumxsn branch July 16, 2026 00:40

coderabbitaiBot mentioned this pull request Jul 18, 2026
fix(ci): restore durable test execution #1330
Merged

coderabbitaiBot mentioned this pull request Aug 18, 2026
fix(ci): reuse standalone smoke workspace #1567
Merged

Navigation Menu

Uh oh!

ci: scope test workflows to the domains a change actually touches - #1271

ci: scope test workflows to the domains a change actually touches#1271
willwashburn merged 5 commits into
mainfrom
claude/ci-test-filtering-yumxsn

willwashburn commented Jul 15, 2026•
edited by cubic-dev-ai Bot
Loading

Uh oh!

gemini-code-assistBot commented Jul 15, 2026

Uh oh!

coderabbitaiBot commented Jul 15, 2026•
edited
Loading

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

chatgpt-codex-connectorBot left a comment

Uh oh!

Uh oh!

cubic-dev-aiBot left a comment •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitaiBot left a comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-aiBot left a comment •
edited
Loading

Uh oh!

Uh oh!

cubic-dev-aiBot left a comment •
edited
Loading

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

willwashburn commented Jul 15, 2026• edited by cubic-dev-ai BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Test Plan

Screenshots

Uh oh!

gemini-code-assistBot commented Jul 15, 2026

Uh oh!

coderabbitaiBot commented Jul 15, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Uh oh!

chatgpt-codex-connectorBot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

cubic-dev-aiBot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

coderabbitaiBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

cubic-dev-aiBot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cubic-dev-aiBot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

willwashburn commented Jul 15, 2026•
edited by cubic-dev-ai Bot
Loading

coderabbitaiBot commented Jul 15, 2026•
edited
Loading

cubic-dev-aiBot left a comment •
edited
Loading

cubic-dev-aiBot left a comment •
edited
Loading

cubic-dev-aiBot left a comment •
edited
Loading