fix(agent): make feature guardian silent on success

[khaliqgant]

Summary

• keep the hourly Relay feature-catalog traversal running while recording healthy manifest/model/state traversal as structured log-only evidence
• remove the scheduled Slack gate, writeback, mentions, receipt polling, and success-message inputs/integration
• migrate exact progress state from v3 Slack receipts to v4 log-only checkpoints while continuing to read deployed v3 state
• fail the deployment run on genuine manifest, empty-catalog, exact-state load/CAS/save, and reconciliation failures so deployment monitoring can alert
• retain deterministic evidence fallback for an optional model failure so a transient generation issue does not create a false canary incident
• describe the scope accurately: catalog traversal does not claim per-feature functional E2E verification

This removes the stale production channel-join receipt assertion path entirely; channel-join was the selected catalog label, not a channel-join API invocation.

RED-first evidence

The first commit adds the silent-success contract before the implementation commit. Before implementation, the healthy tick failed because it wrote one Slack message; the final test requires zero writes even with no channel configured. Genuine manifest/state failures separately require handler rejection.

Verification

• focused Vitest: 28/28
• targeted strict TypeScript: pass
• Prettier and git diff --check: pass
• agentworkforce deploy ... --bundle-out: pass (one schedule, one non-Slack integration)
• automated review finding fixed: bounded legacy Slack epoch conversion with regression coverage

No merge or deployment was performed.

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[coderabbitai]

📝 Walkthrough

Walkthrough

The relay-feature-guardian now generates structured log-only verification evidence, persists it in version 4 progress state, migrates legacy Slack receipts, removes Slack writeback behavior, tightens checkpoint failures, and removes Slack configuration from its persona.

Changes

Guardian verification flow

Layer / File(s)	Summary
Progress state migration and validation .agentworkforce/agents/relay-feature-guardian/agent.ts, .agentworkforce/agents/relay-feature-guardian/agent.test.ts	Progress state now uses version 4 lastCheck records, supports legacy v3 normalization, preserves evidence during reconciliation, and validates updated HTTP/CAS and bounded-state behavior.
Log-only execution and failure handling .agentworkforce/agents/relay-feature-guardian/agent.ts, .agentworkforce/agents/relay-feature-guardian/agent.test.ts	The guardian generates structured evidence, saves log-only checkpoints, removes Slack posting, and throws on manifest, selection, reconciliation, and checkpoint failures.
Persona configuration and test contract updates .agentworkforce/agents/relay-feature-guardian/persona.json, .agentworkforce/agents/relay-feature-guardian/agent.test.ts	Persona inputs and integrations no longer configure Slack, and related tests update fixture typing and persona assertions.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
participant Scheduler
participant runGuardian
participant ProgressStore
participant ctx.llm
participant GuardianLogs
Scheduler->>runGuardian: trigger hourly cycle
runGuardian->>ProgressStore: load and reconcile progress
runGuardian->>ctx.llm: generate feature evidence
ctx.llm-->>runGuardian: evidence or deterministic fallback
runGuardian->>ProgressStore: save version 4 lastCheck
runGuardian->>GuardianLogs: record checkpoint result

Loading

Possibly related PRs

• AgentWorkforce/relay#1283: Earlier changes to the same guardian feature-check flow and Slack-based progress semantics.
• AgentWorkforce/relay#1331: Related progress-state and Slack receipt changes in agent.ts.
• AgentWorkforce/relay#1332: Related HTTP cycle-state persistence and progress-schema test updates.

Suggested labels:size:L

Suggested reviewers:willwashburn

Poem

I’m a rabbit with logs in my burrow tonight,
No Slack quiz hops—just evidence bright.
Version four leaves a careful trace,
Failed checkpoints now show their face.
Thump thump! The guardian checks with grace.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Title check	✅ Passed	The title matches the main change: making the agent silent on successful runs.
Description check	✅ Passed	The description is detailed and aligned with the PR, though it doesn't use the template's exact Test Plan and Screenshots sections.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/guardian-silent-success

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[khaliqgant]

RED-first attestation:

• Before the implementation change, the new healthy-run assertion failed: expected zero human Slack writes, received one.
• At this exact head, the full guardian test file passes 27/27.
• The failure contract is covered separately: malformed/empty manifest, exact progress checkpoint, unsafe reconciliation, and missing production credentials reject the handler; optional model evidence uses a warn-only deterministic fallback.
• Healthy traversal is also proven with persona inputs cleared, so Slack channel configuration cannot gate the canary.

Independent runtime diagnosis classified the deployed channel-join incident as the stale receipt assertion path and signed off this final signal boundary as green.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.agentworkforce/agents/relay-feature-guardian/agent.ts:
- Around line 158-162: Update slackTsToIso to validate the Slack timestamp’s
epoch value is within the supported Date range before constructing the Date.
Preserve the existing safe-integer validation, and reject out-of-range values
with the established invalid lastPost error instead of allowing toISOString to
throw a RangeError.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f459f484-1307-4eda-8286-94373299d0d7

📥 Commits

Reviewing files that changed from the base of the PR and between b2b609b and 55eca1f.

📒 Files selected for processing (3)

• .agentworkforce/agents/relay-feature-guardian/agent.test.ts
• .agentworkforce/agents/relay-feature-guardian/agent.ts
• .agentworkforce/agents/relay-feature-guardian/persona.json