Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 64
fix(deps): pin @vitejs/devtools-vitest's vitest peer so fresh installs survive vitest 5#1649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
willwashburn
wants to merge
8
commits into
mainChoose a base branch
from
claude/fix-fresh-install-vitest-peer-rsucow
base:main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Uh oh!
There was an error while loading. Please reload this page.
Open
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
8334fbf
fix(deps): pin @vitejs/devtools-vitest's vitest peer to the workspace…
claude e6f02bb
chore: record trajectory for the vitest peer override
claude 26998a3
style: auto-format with Prettier
github-actions[bot] 67cea9c
test(relayflows): prove the fresh-install fix red/green with a pinned…
claude 7487cb7
test(relayflows): report a resolver timeout as a timeout, not a launc…
claude 26ff86d
test(relayflows): make the fresh-install proof report its resolver an…
claude b7a17b5
test(relayflows): keep the vitest lookup as the only gating preflight
claude 9e981bc
test(relayflows): bound the proof preflight inside the case timeout
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Jump to file
Failed to load files.
Loading
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
25 changes: 25 additions & 0 deletions
25 .agentworkforce/trajectories/completed/2026-09/traj_pwl779phg4f3.trace.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| { | ||
| "version": "1.0.0", | ||
| "id": "82c0908d-132f-4835-b47e-e76385858bb9", | ||
| "timestamp": "2026-09-03T14:45:29.548Z", | ||
| "trajectory": "traj_pwl779phg4f3", | ||
| "files": [ | ||
| { | ||
| "path": "package.json", | ||
| "conversations": [ | ||
| { | ||
| "contributor": { | ||
| "type": "ai" | ||
| }, | ||
| "ranges": [ | ||
| { | ||
| "start_line": 155, | ||
| "end_line": 163, | ||
| "revision": "8334fbf7efd9f983bb0712c13783e91096f25390" | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
| ] | ||
| } | ||
38 changes: 38 additions & 0 deletions
38 .agentworkforce/trajectories/completed/2026-09/traj_pwl779phg4f3/summary.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| # Trajectory: Pin @vitejs/devtools-vitest's vitest peer so fresh installs survive vitest 5 | ||
| > **Status:** ✅ Completed | ||
| > **Confidence:** 90% | ||
| > **Started:** September 3, 2026 at 02:45 PM | ||
| > **Completed:** September 3, 2026 at 02:45 PM | ||
| --- | ||
| ## Summary | ||
| Nested npm override pins @vitejs/devtools-vitest's wildcard vitest peer to the workspace range; verified fresh install with npm 10.9.2 against main's manifests | ||
| **Approach:** Standard approach | ||
| --- | ||
| ## Key Decisions | ||
| ### Nested override on @vitejs/devtools-vitest rather than a root vitest override | ||
| - **Chose:** Nested override on @vitejs/devtools-vitest rather than a root vitest override | ||
| - **Reasoning:** Only the wildcard peer edge is rewritten; the root range and every workspace range stay untouched, and npm 10.9's $vitest reference resolution fails on peer edges so the range is literal | ||
| --- | ||
| ## Chapters | ||
| ### 1. Work | ||
| *Agent: default* | ||
| - Nested override on @vitejs/devtools-vitest rather than a root vitest override: Nested override on @vitejs/devtools-vitest rather than a root vitest override | ||
| --- | ||
| ## Artifacts | ||
| **Commits:** 8334fbf | ||
| **Files changed:** 1 |
58 changes: 58 additions & 0 deletions
58 .agentworkforce/trajectories/completed/2026-09/traj_pwl779phg4f3/trajectory.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| { | ||
| "id": "traj_pwl779phg4f3", | ||
| "version": 1, | ||
| "task": { | ||
| "title": "Pin @vitejs/devtools-vitest's vitest peer so fresh installs survive vitest 5" | ||
| }, | ||
| "status": "completed", | ||
| "startedAt": "2026-09-03T14:45:26.950Z", | ||
| "completedAt": "2026-09-03T14:45:29.522Z", | ||
| "agents": [ | ||
| { | ||
| "name": "default", | ||
| "role": "lead", | ||
| "joinedAt": "2026-09-03T14:45:28.154Z" | ||
| } | ||
| ], | ||
| "chapters": [ | ||
| { | ||
| "id": "chap_uhzfixybx5dw", | ||
| "title": "Work", | ||
| "agentName": "default", | ||
| "startedAt": "2026-09-03T14:45:28.154Z", | ||
| "endedAt": "2026-09-03T14:45:29.522Z", | ||
| "events": [ | ||
| { | ||
| "ts": 1788446728155, | ||
| "type": "decision", | ||
| "content": "Nested override on @vitejs/devtools-vitest rather than a root vitest override: Nested override on @vitejs/devtools-vitest rather than a root vitest override", | ||
| "raw": { | ||
| "question": "Nested override on @vitejs/devtools-vitest rather than a root vitest override", | ||
| "chosen": "Nested override on @vitejs/devtools-vitest rather than a root vitest override", | ||
| "alternatives": [], | ||
| "reasoning": "Only the wildcard peer edge is rewritten; the root range and every workspace range stay untouched, and npm 10.9's $vitest reference resolution fails on peer edges so the range is literal" | ||
| }, | ||
| "significance": "high" | ||
| } | ||
| ] | ||
| } | ||
| ], | ||
| "retrospective": { | ||
| "summary": "Nested npm override pins @vitejs/devtools-vitest's wildcard vitest peer to the workspace range; verified fresh install with npm 10.9.2 against main's manifests", | ||
| "approach": "Standard approach", | ||
| "confidence": 0.9 | ||
| }, | ||
| "commits": [ | ||
| "8334fbf" | ||
| ], | ||
| "filesChanged": [ | ||
| "package.json" | ||
| ], | ||
| "projectId": "AgentWorkforce/relay", | ||
| "tags": [], | ||
| "_trace": { | ||
| "startRef": "e87f186938d125811c74341d4371f4f021115b01", | ||
| "endRef": "8334fbf7efd9f983bb0712c13783e91096f25390", | ||
| "traceId": "82c0908d-132f-4835-b47e-e76385858bb9" | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 21 additions & 0 deletions
21 tests/relayflows/cases/1649-fresh-install-vitest-peer/case.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| { | ||
| "version": 1, | ||
| "id": "1649-fresh-install-vitest-peer", | ||
| "kind": "bugfix", | ||
| "title": "A lockfile-less npm install on npm 10.9 survives the vitest 5 wildcard peer", | ||
| "runner": { | ||
| "command": ["node", "tests/relayflows/cases/1649-fresh-install-vitest-peer/run.mjs"] | ||
| }, | ||
| "requirements": [], | ||
| "timeoutSeconds": 900, | ||
| "expected": { | ||
| "base": { | ||
| "outcome": "bug", | ||
| "signature": "fresh_install_crashes_on_wildcard_vitest_peer" | ||
| }, | ||
| "head": { | ||
| "outcome": "fixed", | ||
| "signature": "fresh_install_resolves_vitest_4" | ||
| } | ||
| } | ||
| } |
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Oops, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.