Teach workflow repairs from failed attempts

[khaliqgant]

Summary

• feed failed runtime workflow repair attempts back into the next Workforce repair persona call
• include pre-write persona repair history when generated workflow validation keeps failing
• escalate repair persona resolution to tier best after the third repair attempt

Tests

• npm run typecheck
• npm test

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: df396fca-df40-483b-b574-42b474219dbd

📥 Commits

Reviewing files that changed from the base of the PR and between 0300c5f and d89eb2f.

📒 Files selected for processing (3)

• src/product/generation/pipeline.ts
• src/product/generation/workforce-persona-repairer.test.ts
• src/product/generation/workforce-persona-repairer.ts

---

📝 Walkthrough

Walkthrough

Threads previous workforce-persona repair attempts through the auto-fix and prewrite repair flows, records structured repair-attempt metadata, surfaces prior attempts in repair prompts/tasks, and escalates persona resolver tier to "best" after repeated failures.

Changes

Repair Attempt History & Tier Escalation

Layer / File(s)	Summary
Data Shape src/product/generation/workforce-persona-repairer.ts, src/product/generation/workforce-persona-writer.ts, src/product/generation/types.ts	Adds WorkforcePersonaRepairAttempt, WorkforcePersonaValidationFeedback, WorkforcePersonaPrewriteRepairAttempt and repairAttempts?: number on GenerationInput.workforcePersonaWriter to represent previous attempts and prewrite attempt limits.
Core Implementation src/local/auto-fix-loop.ts, src/product/generation/workforce-persona-repairer.ts	Auto-fix loop collects completed repair attempts into previousRepairAttempts and forwards them as previousAttempts on WorkflowRepairInput. Repairer API extended to accept previousAttempts and includes logic to pick persona resolver tier (escalates to 'best' when attempt > 3).
Prewrite Repair Loop / Wiring src/product/generation/pipeline.ts, src/product/generation/workforce-persona-writer.ts	Pipeline adds a multi-step prewrite repair loop with configurable attempt limits, passes validation/repair feedback between iterations, and adjusts persona resolver tier per attempt. Writer accepts validationFeedback (including previousAttempts) and renders previous pre-write repair attempts into persona tasks.
Prompt / Messaging src/product/generation/workforce-persona-repairer.ts, src/product/generation/workforce-persona-writer.ts	Repair prompt/task now includes a serialized "Previous repair attempts" section and added guidance (e.g., MISSING_ENV_VAR handling, resumeability, side-effect constraints). renderValidationFeedbackForPersona emits prior pre-write repair attempt details when present.
Tests src/local/auto-fix-loop.test.ts, src/product/generation/workforce-persona-repairer.test.ts, src/product/generation/workforce-persona-writer.test.ts	New/updated tests assert previousAttempts are populated across retries, verify retry metadata and run-id propagation, and validate tier escalation behavior across multiple repair attempts.

Sequence Diagram(s)

sequenceDiagram
participant AutoFix as Auto-fix loop
participant Repairer as Workforce Persona Repairer
participant Pipeline as Generation Pipeline / Prewrite Loop
participant Writer as Workforce Persona Writer
AutoFix->>Repairer: call workflowRepairer(input with previousAttempts)
Repairer->>Repairer: evaluate options (attempt count -> tier)
Repairer-->>AutoFix: repair outcome (blocker / success + personaRunId)
AutoFix->>AutoFix: append pendingAttempt / aggregate previousAttempts
Pipeline->>Writer: buildWorkflowPersonaTask(validationFeedback with previousAttempts)
Writer-->>Pipeline: persona task (includes previousAttempts in prompt)
Pipeline->>Repairer: invoke prewrite repair iterations, passing previousAttempts
Repairer-->>Pipeline: updated repair attempt outcomes

Loading

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

• AgentWorkforce/ricky#47: Modifies auto-fix loop repair plumbing; related to retry and blocker handling.
• AgentWorkforce/ricky#54: Threads previous repair attempts through auto-fix and persona repair paths; overlaps heavily with these changes.
• AgentWorkforce/ricky#49: Alters auto-fix repair plumbing and MISSING_ENV_VAR handling in overlapping code paths.

"I nibbled at bugs through loops of lore,
Each attempt a carrot—tall, then more,
I noted what failed, then passed it on,
Escalated tiers until the dawn,
A rabbit's patchwork of fixes, stitched and sure."

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'Teach workflow repairs from failed attempts' directly and clearly summarizes the main change: enabling the repair system to learn from and reuse failed repair attempts.
Description check	✅ Passed	The description is clearly related to the changeset, outlining three key objectives that align with the modifications across multiple files for repair attempt tracking and escalation.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/ricky-persona-repair-learning

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 2

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/product/generation/pipeline.ts`:
- Around line 25-26: The default pre-write repair attempts constant
(DEFAULT_WORKFORCE_PERSONA_PREWRITE_REPAIR_ATTEMPTS) is set to 3 but the
escalation branch is gated on repairAttempt > 3, so the default never reaches
escalation; change DEFAULT_WORKFORCE_PERSONA_PREWRITE_REPAIR_ATTEMPTS to 4
(ensuring it remains <= MAX_WORKFORCE_PERSONA_PREWRITE_REPAIR_ATTEMPTS) so the
default retry budget will promote to the escalation/"best" path, and apply the
same change to the other matching default constant(s) referenced near the other
block (the ones around the 216-218 area) so both places use 4 as the default.
In `@src/product/generation/workforce-persona-repairer.ts`:
- Around line 219-225: personaResolverOptions currently defaults a missing tier
to DEFAULT_WORKFORCE_PERSONA_TIER (which is 'best'), so the attempt-based
escalation never changes behavior when callers (like the auto-fix loop in
src/local/auto-fix-loop.ts) omit a tier; change personaResolverOptions to treat
an omitted tier as a lower starting tier so escalation can take effect: compute
a baseTier = options.tier ?? 'standard' (or another non-'best' baseline), then
set tier = options.attempt !== undefined && options.attempt > 3 ? 'best' :
baseTier, and preserve the existing installRoot behavior.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: e1e95918-a797-493b-9580-1877231380f4

📥 Commits

Reviewing files that changed from the base of the PR and between d42ecb5 and 0300c5f.

📒 Files selected for processing (8)

• src/local/auto-fix-loop.test.ts
• src/local/auto-fix-loop.ts
• src/product/generation/pipeline.ts
• src/product/generation/types.ts
• src/product/generation/workforce-persona-repairer.test.ts
• src/product/generation/workforce-persona-repairer.ts
• src/product/generation/workforce-persona-writer.test.ts
• src/product/generation/workforce-persona-writer.ts

[khaliqgant]

Addressed the two review comments in d89eb2f:

• bumped default pre-write repair attempts from 3 to 4 so the default path reaches the attempt-4 best-tier escalation before fallback
• changed runtime workflow repair's omitted-tier baseline from best to best-value, because Workforce's router schema allows best/best-value/minimum and not standard; attempt 4+ still escalates to best

Validation:

• npx vitest run src/product/generation/workforce-persona-writer.test.ts src/product/generation/workforce-persona-repairer.test.ts src/local/auto-fix-loop.test.ts
• npm run typecheck
• npm test (843 tests passed)