Skip to content

Fix durable Factory lifecycle completion - #114

Merged
khaliqgant merged 1 commit into
mainfrom
agent/fix-durable-factory-completion
Jul 18, 2026
Merged

Fix durable Factory lifecycle completion#114
khaliqgant merged 1 commit into
mainfrom
agent/fix-durable-factory-completion

Conversation

@kjgbot

Copy link
Copy Markdown
Contributor

Summary

  • register a durable Factory lifecycle action on the authenticated Relay identity instead of relying on factory or broker DMs
  • turn implementer completion into PR publication and babysitter readiness into the guarded Human Review terminal transition
  • preserve terminal ordering so all agents release before the isolated worktree is removed, while suppressing shared-channel control noise
  • retain task-exit fallback for internal fleets and legacy message parsing for already-running agents

Validation

  • npm test (40 files, 877 tests)
  • npm run build
  • git diff --check

Regression coverage

  • absent factory and broker Relay identities
  • authenticated lifecycle action registration and invocation completion
  • ready-for-review PR publication
  • green babysitter transition to Human Review
  • implementer, reviewer, and babysitter release before worktree cleanup
  • no factory, broker, or #general control messages

@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

Copy link
Copy Markdown

Warning

Review limit reached

@kjgbot, you've reached your PR review limit, so we couldn't start this review.

Next review available in:53 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8d3508cc-dd41-4f92-beda-18d5ba5196c1

📥 Commits

Reviewing files that changed from the base of the PR and between 1fa3646 and 5f23b37.

📒 Files selected for processing (11)
  • src/dispatch/templates.test.ts
  • src/dispatch/templates.ts
  • src/fleet/internal-fleet-client.test.ts
  • src/fleet/internal-fleet-client.ts
  • src/fleet/relay-fleet-client.test.ts
  • src/fleet/relay-fleet-client.ts
  • src/orchestrator/factory.test.ts
  • src/orchestrator/factory.ts
  • src/ports/fleet.ts
  • src/ports/index.ts
  • src/testing/fakes.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch agent/fix-durable-factory-completion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@khaliqgant
khaliqgant merged commit ca1634f into mainJul 18, 2026
3 checks passed
@khaliqgant
khaliqgant deleted the agent/fix-durable-factory-completion branch July 18, 2026 20:14
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@kjgbot@khaliqgant