Uh oh!
There was an error while loading. Please reload this page.
fix(config): support label-only safety gates - #459
Conversation
Session-Id: 01a0679f-5165-75f2-a0e6-1f3f6771261a
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Warning Review limit reachedNext included review available in 24 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (8)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
@coderabbitai review Requested for exact head |
Why
@agentworkforce/factory-clouddocuments and testssafety.requireTitlePrefix: nullas the explicit way for an instance overlay to clear the inherited title gate.@agent-relay/factory@0.1.85rejects that rendered config during preflight because its schema only accepts non-empty strings. The result is a deployed, isolated Container whose/healthzreportsfactoryProcess: not-runningbefore it can dispatch.This is currently blocking
AgentWorkforce/hoopsheet-gardenfrom proving a real label-gated dispatch ofhoopsheet#80.What changed
nullis accepted as an explicit opt-out for the title path.[factory-e2e]and an empty string is still rejected.Verification
npm run buildnpx vitest run src/config/schema.test.ts src/safety/factory-scope.test.ts src/writeback/writeback.test.ts --maxWorkers=1— 157 passednpm pack --dry-runA full-suite run completed 2,426/2,436 tests and hit nine unrelated timing failures across five integration-heavy files while two other orphaned Vitest workers were consuming this host. The changed files' focused suite is green both before and after the final test addition, and the full type build is green.
Summary by cubic
Accepts
nullforsafety.requireTitlePrefixso deployments can use label-only safety gates. Previously preflight rejected the config, leaving deployed Containers reportingfactoryProcess: not-running; nownulldisables the title path explicitly while omission keeps the[factory-e2e]default and empty strings stay rejected.Bug Fixes
Written for commit 774ab7d. Summary will update on new commits.