Uh oh!
There was an error while loading. Please reload this page.
feat(deploy): support deploy input overrides - #101
Merged
Conversation
Contributor
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR implements deploy-time persona input overrides via repeatable ChangesDeploy Input Overrides Feature
Sequence DiagramsequenceDiagram
participant CLI as parseDeployArgs
participant Deploy as deploy
participant Persona as preflightPersona
participant Validator as validateDeployInputs
participant Wrapper as wrapInputResolvers
participant Launcher as dev/sandbox/cloudLauncher
participant Cloud as Cloud API
CLI->>Deploy: deploy(opts with inputs)
Deploy->>Persona: preflightPersona(personaPath)
Deploy->>Validator: validateDeployInputs(inputs, persona)
Validator-->>Deploy: validated inputs
Deploy->>Wrapper: wrapInputResolvers(validated inputs, cloudUrl)
Wrapper->>Launcher: launch(input {inputs, env, cloudUrl})
Launcher->>Cloud: POST /deployments { persona, bundle, packageJson, inputs? }
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~25 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
khaliqgant
marked this pull request as ready for review
May 13, 2026 04:49
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/deploy/src/modes/cloud.ts (1)
9-22: ⚡ Quick winUpdate the launcher docblock to match current behavior.
The header comment still says cloud mode is unavailable and describes multipart + polling, but the implementation now does a JSON POST and returns immediately.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/deploy/src/modes/cloud.ts` around lines 9 - 22, The top docblock in packages/deploy/src/modes/cloud.ts is outdated: update the comment for `--mode cloud` to remove the multipart/polling description (steps 1–4) and explicitly describe the current behavior: the CLI performs a single JSON POST to `POST /api/v1/workspaces/:id/deployments` with the persona and bundle, the server returns immediately, and the function returns a deployment handle without polling; adjust wording to reflect that cloud deploys return immediately and mention how stop() on the returned handle behaves (e.g., issues a DELETE) so the docblock matches the implementation.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/deploy/src/modes/cloud.ts`:
- Around line 41-59: The fetch POST to
`${cloudUrl}/api/v1/workspaces/.../deployments` has no timeout; wrap the request
with an AbortController: create an AbortController before calling fetch, set a
timer (e.g. with setTimeout) that calls controller.abort() after a chosen
timeout, pass controller.signal in the fetch options, and clear the timer once
fetch resolves or throws; update the block that builds the request body
(references: cloudUrl, input, workspaceToken, readFile) to include the signal
and ensure any AbortError is handled/propagated appropriately so `workforce
deploy` cannot hang indefinitely.
---
Nitpick comments:
In `@packages/deploy/src/modes/cloud.ts`:
- Around line 9-22: The top docblock in packages/deploy/src/modes/cloud.ts is
outdated: update the comment for `--mode cloud` to remove the multipart/polling
description (steps 1–4) and explicitly describe the current behavior: the CLI
performs a single JSON POST to `POST /api/v1/workspaces/:id/deployments` with
the persona and bundle, the server returns immediately, and the function returns
a deployment handle without polling; adjust wording to reflect that cloud
deploys return immediately and mention how stop() on the returned handle behaves
(e.g., issues a DELETE) so the docblock matches the implementation.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 4b91f72e-dccb-4cd2-9744-1695b6274f0a
📒 Files selected for processing (7)
docs/plans/deploy-v1.mdpackages/cli/src/deploy-command.test.tspackages/cli/src/deploy-command.tspackages/deploy/src/index.tspackages/deploy/src/modes/cloud.tspackages/deploy/src/modes/input-values.test.tspackages/deploy/src/types.ts
Uh oh!
There was an error while loading. Please reload this page.
Comment on lines
+53
to
+54
| const inputs = opts.inputs && Object.keys(opts.inputs).length > 0 ? opts.inputs : undefined; | ||
| if (!inputs) return deployInternal(opts, resolvers); |
Contributor
There was a problem hiding this comment.
🔴 --cloud-url CLI flag silently ignored when no --input flags are provided
The new deploy() wrapper in index.ts only forwards opts.cloudUrl to the cloud launcher through wrapLauncher (line 110), which is only invoked when inputs are present (line 58). When there are no inputs, the wrapper calls deployInternal(opts, resolvers) directly, and deployInternal at packages/deploy/src/deploy.ts:177-183 never passes cloudUrl in the launcher.launch(...) call. As a result, the cloud launcher at packages/deploy/src/modes/cloud.ts:25 sees input.cloudUrl as undefined and falls back to process.env.WORKFORCE_CLOUD_URL. This means workforce deploy persona.json --mode cloud --cloud-url https://custom.example.com (without --input) silently ignores --cloud-url, and if WORKFORCE_CLOUD_URL env var is not set, the deployment fails with the "not yet available" error despite a valid cloud URL being specified.
Prompt for agents
The deploy() wrapper in packages/deploy/src/index.ts only wraps launchers (to inject cloudUrl into ModeLaunchInput) when inputs are present. When no inputs are provided, it calls deployInternal directly, and deployInternal in packages/deploy/src/deploy.ts:177-183 does not pass opts.cloudUrl to the launcher.
The cloud launcher (packages/deploy/src/modes/cloud.ts:25) reads input.cloudUrl as its primary source, falling back to env var. So --cloud-url is silently lost in the no-inputs path.
Two possible approaches:
1. Have deployInternal (deploy.ts) pass cloudUrl to launcher.launch() from opts.cloudUrl, so it always reaches launchers regardless of the wrapper.
2. Ensure the deploy() wrapper in index.ts also wraps launchers for cloudUrl when opts.cloudUrl is set, not just when inputs are present. This would mean the wrapper calls wrapInputResolvers even when inputs are empty but cloudUrl is present.
Was this helpful? React with 👍 or 👎 to provide feedback.
- Pass opts.cloudUrl through launcher.launch in deployInternal so --cloud-url reaches the cloud launcher even when --input is not used. - Wrap the cloud deploy fetch in an AbortController with a 30s timeout so a stalled network request can no longer hang `workforce deploy` indefinitely. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec reference
Source spec: workforce/docs/plans/deploy-v1-schema-cascade-spec.md
Track section: Track I — Deploy CLI flags
Final signoff
Final gate (typecheck + tests)
Self-reflection report
Known gaps after this PR
Co-Authored-By: Ricky deploy-v1 schema cascade noreply@agentworkforce.com