chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all \u003cpre\u003e\u003ccode\u003e blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks"); } } catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); } })(); (function(){ try { var __m = "github.com"; var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length \u003e 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build#104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
khaliqgant merged 5 commits into from
May 13, 2026
Merged

chore(publish): cover new packages in publish.yml allow-list + fix mcp-workforce build #104

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c319d15
chore(publish): add runtime + deploy + mcp-workforce to the publish a…
May 13, 2026
0d90878
fix(mcp-workforce): align memory scope enum with PersonaMemoryScope
May 13, 2026
c3e478f
fix(publish): sync release-notes packageOrder with expanded allow-list
May 13, 2026
4581946
fix(examples): linear-shipper read spec metadata from inputSpecs
May 13, 2026
f68e999
fix(persona-kit): make integration-source fixtures pass the schema test
May 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 24 additions & 6 deletions .github/workflows/publish.yml
View file
Open in desktop

@devin-ai-integrationdevin-ai-integrationBotMay 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 packageOrder array in release notes not updated with new packages, causing incorrect sort order

The packageOrder array at line 698 still lists only the old set of packages (persona-kit, workload-router, cli, daytona-runner, agentworkforce) and is missing the three new packages added by this PR: runtime, deploy, and mcp-workforce. Since Array.prototype.indexOf() returns -1 for missing elements, all three new packages will sort before every known package (including persona-kit), producing an incorrect ordering in the GitHub Release notes body. The intended topological order from publish.yml:88-98 is not reflected here.

(Refers to line 698)

Open in Devin Review

Was this helpful? React with 👍 or 👎 to provide feedback.

Original file line numberDiff line numberDiff line change
Expand Up@@ -85,11 +85,17 @@ jobs:
- name: Resolve target packages
id: targets
run: |
# Dependency order: persona-kit → workload-router → cli → agentworkforce.
# persona-kit is a leaf dep consumed by workload-router and cli, so it
# must publish first. The top-level `agentworkforce` wrapper depends on
# `@agentworkforce/cli`, so it must publish last.
echo "packages=persona-kit workload-router cli daytona-runner agentworkforce" >> "$GITHUB_OUTPUT"
# Dependency order (topological):
# persona-kit (leaf — consumed by everyone)
# runtime (→ persona-kit; consumed by deploy + mcp-workforce)
# workload-router (→ persona-kit; consumed by cli)
# deploy (→ persona-kit + runtime; consumed by cli)
# mcp-workforce (→ persona-kit + runtime)
# daytona-runner (no workspace deps)
# cli (→ persona-kit + workload-router + deploy)
# agentworkforce (→ cli — umbrella wrapper, must publish last)
# personas-core publishes via the separate publish-personas.yml workflow.
echo "packages=persona-kit runtime workload-router deploy mcp-workforce daytona-runner cli agentworkforce" >> "$GITHUB_OUTPUT"

Comment thread
coderabbitai[bot] marked this conversation as resolved.
# Lockstep baseline heal. The workspace publishes every package at the
# same version, so if any package's local version lags either its own
Expand DownExpand Up@@ -689,7 +695,19 @@ jobs:
// didn't publish an umbrella stamp (e.g. version: none re-runs).
const releaseVersion = process.env.RELEASE_VERSION || canonicalVersion;

const packageOrder = ['persona-kit', 'workload-router', 'cli', 'daytona-runner', 'agentworkforce'];
// Mirrors the topological order used in the "Resolve target
// packages" step. Sorting release-notes entries by this order
// ensures missing packages don't all collapse to indexOf=-1.
const packageOrder = [
'persona-kit',
'runtime',
'workload-router',
'deploy',
'mcp-workforce',
'daytona-runner',
'cli',
'agentworkforce',
];
const entries = versionsRaw.trim().split(/\s+/).filter(Boolean).map((entry) => {
const idx = entry.indexOf(':');
return { pkg: entry.slice(0, idx), ver: entry.slice(idx + 1) };
Expand Down
15 changes: 12 additions & 3 deletions examples/linear-shipper/agent.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6,11 +6,20 @@ type LinearIssueEvent = {

function inputDefault(ctx: Parameters<Parameters<typeof handler>[0]>[0], name: string): string {
// Mirror `resolvePersonaInputs` precedence (packages/persona-kit/src/inputs.ts):
// explicit env var (spec.env ?? input name) wins over the static JSON default.
const spec = ctx.persona.inputs?.[name];
// explicit env var (spec.env ?? input name) wins over the runtime-resolved
// value, which in turn wins over the static spec default.
//
// NOTE: the raw spec lives at `ctx.persona.inputSpecs` (Record<string, PersonaInputSpec>);
// `ctx.persona.inputs` is the already-resolved Record<string, string>. The earlier
// version of this helper read .env / .default off `inputs` directly, which only
// worked because the type was looser before the WorkforceCtx readonly tightening.
const spec = ctx.persona.inputSpecs?.[name];
const envName = spec?.env ?? name;
const fromEnv = process.env[envName];
const value = (fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ?? spec?.default;
const value =
(fromEnv !== undefined && fromEnv !== '' ? fromEnv : undefined) ??
ctx.persona.inputs?.[name] ??
spec?.default;
if (!value) throw new Error(`${name} input is required`);
return value;
}
Expand Down
4 changes: 2 additions & 2 deletions packages/mcp-workforce/src/server.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -10,7 +10,7 @@ import {
type IntegrationToolName
} from './tools/integrations.js';

const MEMORY_SCOPE_ENUM = z.enum(['session', 'user', 'workspace', 'org', 'object']);
const MEMORY_SCOPE_ENUM = z.enum(['workspace', 'user', 'global']);

/**
* Build an `McpServer` with workforce-flavored tools registered. Exposed
Expand DownExpand Up@@ -62,7 +62,7 @@ export function createWorkforceMcpServer(config: WorkforceMcpConfig): McpServer
{
title: 'Save a memory entry',
description:
'Persist a memory entry for the active workspace. Scopes follow @agent-assistant/memory semantics: session, user, workspace, org, object. Tags are deduped; workspace/scope tags are added automatically.',
'Persist a memory entry for the active workspace. Scope is one of workspace (default) / user / global, matching @agentworkforce/persona-kit\'s PersonaMemoryScope. Tags are deduped; workspace/scope tags are added automatically.',
inputSchema: {
content: z.string().min(1),
tags: z.array(z.string()).optional(),
Expand Down
6 changes: 2 additions & 4 deletions packages/mcp-workforce/src/tools/memory.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,11 +36,9 @@ export interface MemoryToolDeps {
}

const VALID_SCOPES: ReadonlySet<PersonaMemoryScope> = new Set([
'session',
'user',
'workspace',
'org',
'object'
'user',
'global'
]);

/**
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-deployer.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration with no explicit source. Exercises the default-injection path that fills in { kind: 'deployer_user' } during parse.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource default-injection. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"scope": { "repo": "AgentWorkforce/workforce" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-service-account.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a GitHub integration resolved via a named workspace service account ('release-bot').",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace_service_account', name: 'release-bot' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"github": {
"source": { "kind": "workspace_service_account", "name": "release-bot" },
Expand Down
2 changes: 2 additions & 0 deletions packages/persona-kit/src/__fixtures__/personas/integration-source-workspace.json
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -3,11 +3,13 @@
"intent": "documentation",
"tags": ["documentation"],
"description": "Fixture: persona declaring a Slack integration resolved from the workspace's default workspace_integrations row.",
"skills": [],
"harness": "claude",
"model": "anthropic/claude-3-5-sonnet",
"systemPrompt": "Fixture persona for IntegrationSource={ kind: 'workspace' }. Not used at runtime.",
"harnessSettings": { "reasoning": "medium", "timeoutSeconds": 300 },
"cloud": true,
"onEvent": "./agent.ts",
"integrations": {
"slack": {
"source": { "kind": "workspace" },
Expand Down
3 changes: 3 additions & 0 deletions packages/persona-kit/src/emit-schema.test.ts
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -19,6 +19,9 @@ test('persona fixtures validate against generated schema and parse', async () =>
assert.deepEqual(fixtureNames, [
'cron-only.json',
'full.json',
'integration-source-deployer.json',
'integration-source-service-account.json',
'integration-source-workspace.json',
'invalid-unknown-trigger.json',
'minimal.json'
]);
Expand Down
Loading